Bug 99840 - 'Mouse pointer as pen' actual trail saved in Presentation
Summary: 'Mouse pointer as pen' actual trail saved in Presentation
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2016-05-14 17:14 UTC by John Rose
Modified: 2016-08-17 20:09 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing problem (216.66 KB, image/png)
2016-05-14 17:14 UTC, John Rose
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Rose 2016-05-14 17:14:46 UTC
Created attachment 125046 [details]
Screenshot showing problem

When I run the Slide Show the 'Mouse pointer as pen' actual trail (i.e. the red curved 'line' drawn on a slide is saved in the .odp file Show. Thus, when the Presentation's .odp file is subsequently loaded, it is still shown in the Slide Show Sorter. Also, there seems to be no mechanism to select it and then delete it.
Comment 1 Buovjaga 2016-05-15 16:38:57 UTC
I don't have the problem.
Please test with version 5.1.3.

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away.

64-bit, KDE Plasma 5
Build ID: 5.1.3.2 Arch Linux build-1
CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)
Comment 2 John Rose 2016-05-16 15:36:51 UTC
Installed LibreOffice 5.1.3.2. Problems still the same.
Comment 3 A (Andy) 2016-05-26 20:23:32 UTC
For me not reproducible under Win 8.1 (LO 5.1.3.2).
Comment 4 raal 2016-05-27 05:01:42 UTC
I can not confirm with Version: 5.2.0.0.alpha1+
Build ID: fa9416906e615f5f19ad8524176d2ed693662769
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-05-24_00:05:55
Comment 5 Aron Budea 2016-06-02 02:32:36 UTC
I can consistently reproduce it with the following steps:
-set: Slide Show -> Slide Show Settings -> Mouse pointer as pen
-start slide show
-during slide show, draw stuff with left mouse button pressed
-save and reload the file.

Observe how drawing is kept after the slide show, and after saving/reloading.
(help specifically states: "Anything you write with the pen is not saved when you exit the slide show. The color of the pen cannot be changed.")

Reproduced:
-Windows 7: 4.2.0.4, 5.1.2.3, 5.2 beta 1
-Linux: 5.1.2.3

Not reproduced:
-Windows 7: 4.1.2.3

=> regression

John, just a note, I can select and delete the drawing either by clicking on specific segments with the Select tool (which is tedious), or using area selection on the whole drawing.
Comment 6 Caolán McNamara 2016-07-20 20:22:15 UTC
This is from...

commit 516ecd072f9dbfbacce77127a02b666ce387982d
Author: Thorsten Behrens <tbehrens@suse.com>
Date:   Fri Oct 11 18:07:37 2013 +0200

    Restore persistent userpaint functionality in slideshow.
    
    This was part of i103174 - Code from the ecntablet and eraser CWS;
    optionally improves user paint interactions in slideshow, and got
    accidentally cleaned away for being commented out.
    
    Change-Id: I4fb87a3e1cb834e10ae766ed8c58cd6f2397c45f

err, is this intentional ?
Comment 7 Thorsten Behrens (allotropia) 2016-07-20 23:38:34 UTC
(In reply to Caolán McNamara from comment #6)
> err, is this intentional ?
>

Sure - I fail to see the confusion - quite the contrary, we got
complaints that user input was silently dropped (some artful drawings
generated on-stage).

As Aron states, removing is like with any other impress shape
(admittedly, we could stick that into a group shape, making deletion a
bit easier).
Comment 8 Aron Budea 2016-07-21 00:05:59 UTC
(In reply to Thorsten Behrens (CIB) from comment #7)
> Sure - I fail to see the confusion - quite the contrary, we got
> complaints that user input was silently dropped (some artful drawings
> generated on-stage).

They might not necessarily want to keep their drawings. Though it's likely they wouldn't save the presentation afterwards in that case.
It would probably be nice if the whole drawing that was made during the presentation could be discarded with a single click.
Comment 9 Aron Budea 2016-07-22 00:53:06 UTC
Actually, there is still an issue with the documentation.

It's specifically stated that:

"Anything you write with the pen is not saved when you exit the slide show. The color of the pen cannot be changed."
https://help.libreoffice.org/index.php?title=5.1/Impress/Slide_Show_Settings&Language=en-US&System=WIN&Version=5.1#Mouse_pointer_as_pen

This needs to be updated to reflect the current behavior.
Comment 10 Stanislav Horacek 2016-08-12 19:45:31 UTC
Help patch is in Gerrit:
https://gerrit.libreoffice.org/#/c/28093/
Comment 11 Commit Notification 2016-08-17 19:17:08 UTC
Stanislav Horacek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=641b43850cb2903e640bfbdd5df413e80aff2b68

tdf#99840 update info on saving of pen drawings in Impress
Comment 12 Caolán McNamara 2016-08-17 20:09:43 UTC
Seeing as the documentation now says this is supposed to happen I'll close the bug. No problem in a new bug for "single button to throw away pen trail" or any remaining gripes, but this bug tagged regression I'll close.