Created attachment 129117 [details] Image in the header Attached document has an image in the header and a few lines of text next to it. When opened in Writer the text gets behind the image making the text unreadable.
Created attachment 129118 [details] The file opened in Word 2013 and LO 5.4.1 side by side Screenshot shows LO 5.1, but the same happens with an uptodate master build too.
Confirmed in Version: 5.4.0.0.alpha0+ Build ID: ef0e1c05c32a5a69502e0f0d1d97789c125345a2 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group - Version: 4.5.0.0.alpha0+ Build ID: 2851ce5afd0f37764cbbc2c2a9a63c7adc844311 Locale: ca_ES -Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still present in q8p26‖Version: 6.1.0.0.alpha0+ XZmEs‖Build ID: 7886de305809e265cd2126d39912147131d3a004 Dk4vc‖CPU threads: 4; 5DyEd‖OS: Linux 4.4; Yqrwo‖UI render: ZitRE‖default; VCL: gtk2; Ru2AA‖Locale: hu-HU (hu_HU.UTF-8); Calc: group threaded
Dear Gabor Kelemen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Created attachment 155631 [details] Simplified example file from Word
Created attachment 155632 [details] The simplified example file in Word and Writer master Simplified file shows that the problem is specific to the header, as the same content appears correctly in the document body. Version: 6.4.0.0.alpha1+ (x86) Build ID: 80109586e6cb6d3e2e0a53a9079c3125ec9b8368 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: hu-HU (hu_HU); UI-Language: en-US Calc: CL
Created attachment 171616 [details] problem with the suggested patch regression with the suggested patch of https://gerrit.libreoffice.org/c/core/+/113098 using the test document of https://bz.apache.org/ooo/show_bug.cgi?id=13832 Patch: diff --git a/sw/source/core/text/txtfly.cxx b/sw/source/core/text/txtfly.cxx index a5fb1f6..ca040b5 100644 --- a/sw/source/core/text/txtfly.cxx +++ b/sw/source/core/text/txtfly.cxx @@ -843,7 +843,7 @@ const bool bAllowCompatWrap = m_pCurrFrame->IsInTab() && (bFooterHeader || m_pCurrFrame->IsInFootnote()); const bool bWrapAllowed = ( pIDSA->get(DocumentSettingId::USE_FORMER_TEXT_WRAPPING) || bAllowCompatWrap || - (!m_pCurrFrame->IsInFootnote() && !bFooterHeader)); + !m_pCurrFrame->IsInFootnote() ); m_bOn = false;
Daniel Arato (NISZ) committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/798b69087119c01a3b51e0bb3240ef35cfededeb tdf#104254 sw DOCX import: fix text wrapping in headers It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: threaded
As seen in bug 80392, this fixed original 66 pages file MSO 14 attachment 115772 [details] DOCX. It didn't fix shorter 3 page reproducer MSO 15 attachment 131068 [details] DOCX.
*** Bug 135940 has been marked as a duplicate of this bug. ***
Created attachment 174021 [details] 104254_imageInheaderMinimalc14.docx: comment 6's flle, but at compatibilityMode 14 I'm very surprised that comment 9's patch has not triggered all kinds of regression reports already. I would recommend reverting it, and trying to redo the fix for 7.3. It is VERY intentional that headers/footers are explicitly excluded from considering wrapping. That should be fairly obvious from the code context. There is already a compat flag to turn on "old behaviour" that allows wrapping in these situations. (for example, see the commit memesage in https://cgit.freedesktop.org/libreoffice/core/commit/?id=e4635544b816d1ca27bd1ebba60f51444b0a898e) It looks like DOCX 2013 did a major reversal in how it handles wrapping in headers. Changing the compatibilityMode from 15 to 14 causes a very different layout in Word - which LibreOffice matched by ignoring the wrapping. So any fix here MUST take into consideration the compatibility level. (P.S. When saving to DOC format, that also ignores the wrapping.)
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d03aaef3dcb5d142955457ae9b8ca4469cfafa38 Revert "tdf#104254 sw DOCX import: fix text wrapping in headers" It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Patch reverted since it overturns an old decision to act like MS formats - when the USE_FORMER_TEXT_WRAPPING compat flag was introduced. This affects ALL formats, including ODT, not just DOCX.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/ff91ddf0a3992b58112f3ffc3e76735b9d66e514 Revert "tdf#104254 sw DOCX import: fix text wrapping in headers" It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2-0": https://git.libreoffice.org/core/commit/c5abee7aefb088a11fc1618bc1512413e9bde682 Revert "tdf#104254 sw DOCX import: fix text wrapping in headers" It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
bug 143793 has a lot of comments relevant to this issue. -LO "native" handling was changed to match MS Word. So do we change again to be compatible with only modern DOCX? -attachment 174179 [details] UseFormerTextWrapping.odt attempts to show the relevant situations.
I'd say this depends on bug 143793 being solved first. The two are completely intertwined, and solving one will effectively solve the other, but that report is more generic and broader in scope, and better documented, so best to deal with it first.
I might consider proposing http://gerrit.libreoffice.org/c/core/+/124931 for LO 7.4. However, the test documents I'm playing with act strangely and easily enter into either long loading/layout loops or perhaps even loop infinitely. So any changes here can easily throw our horrible layout code into a funk.
Justin, please consider adding to https://wiki.documentfoundation.org/Development/Budget2022. IIUC, seems like a complex issue that's hardly solvable with single patches. I don't know what's accepted, but frequent problems should be there IMO.
Created attachment 176461 [details] patch_104254.diff Abandoning my proposal, but archiving the suggestion here. The patch itself is fine, but the layout code in general is too fragile. So it exposes a lot of situations that layout hasn't had to deal with before and so will easily lock up or loop, and I don't have the skills to deal with that kind of fallout.
*** Bug 150192 has been marked as a duplicate of this bug. ***
(In reply to Timur from comment #21) > Justin, please consider adding to > https://wiki.documentfoundation.org/Development/Budget2024 Re-allow wrapping around frames in header/footer (tdf#143793)