Bug 128074 - SPELLCHECK: Writer freezes when trying to "Ignore All" in Spell Check when the flagged word is the next flagged word too.
Summary: SPELLCHECK: Writer freezes when trying to "Ignore All" in Spell Check when th...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 127060 127879 (view as bug list)
Depends on:
Blocks: Spell-Checking-Dialog
  Show dependency treegraph
 
Reported: 2019-10-10 12:50 UTC by Dana
Modified: 2024-05-25 06:38 UTC (History)
5 users (show)

See Also:
Crash report or crash signature: ["SalComWndProc(HWND__ *,unsigned int,unsigned __int64,__int64,bool &)"]


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dana 2019-10-10 12:50:46 UTC
This bug was filed from the crash reporting server and is br-a889543a-a63a-41fb-bf79-1bf9bdca531e.
=========================================
Writer crashes when trying to "Ignore All" in Spell Check when the flagged word is the next flagged word too.
Comment 1 Dieter 2019-10-10 13:30:42 UTC
Havin a look at the crash reports I could see that there is no crash for this signature with LO 6.3.2. So could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. Change to RESOLVED WORKSFORME, if the problem went away.
Comment 2 Mike Kaganski 2019-10-11 09:34:30 UTC
With Version: 6.3.2.2 (x64)
Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

I could reproduce a *hang* using this:

in a new text document, type "These are twoo twoo identical typos"; F7 -> Ignore All.

Couldn't repro with current master. Possibly a reverse bibisect needed to find a backport a fix?
Comment 3 Dieter 2019-10-11 09:52:40 UTC Comment hidden (obsolete)
Comment 4 Dieter 2019-10-11 09:56:16 UTC
I confirm this with

Version: 6.3.2.2 (x64)
Build-ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

We have some problems with freeze in spell checking; see bug 128035 and bug 128081. And there was also a bug with freeze of spellchecking after press "Ignore all" button, but I couldn't find it.

Cpuldn't try it with master, because I don't have a dictionary there.
Comment 5 Dieter 2019-10-13 05:32:28 UTC
(In reply to Dieter Praas from comment #4)
> We have some problems with freeze in spell checking; see bug 128035 and bug
> 128081.

Of course 128035 is wrong.
Comment 6 Xisco Faulí 2019-10-16 14:36:44 UTC
(In reply to Mike Kaganski from comment #2)
> Couldn't repro with current master. Possibly a reverse bibisect needed to
> find a backport a fix?

I tried with bisect repository 6.4 and I can't reproduce it in the oldest nor the newest commit, sigh...
Comment 7 Xisco Faulí 2019-10-16 14:49:19 UTC
*** Bug 127879 has been marked as a duplicate of this bug. ***
Comment 8 Xisco Faulí 2019-10-16 14:58:53 UTC
*** Bug 127060 has been marked as a duplicate of this bug. ***
Comment 9 Xisco Faulí 2019-10-16 15:03:48 UTC
Also reproducible in

Versió: 6.3.2.2
ID de la construcció: 1:6.3.2-0ubuntu0.18.04.1~lo1
Fils de CPU: 4; SO: Linux 4.15; Renderitzador de la IU: per defecte; VCL: gtk3; 
Configuració local: es-ES (ca_ES.UTF-8); Llengua de la IU: ca-ES
Calc: threaded
Comment 10 Xisco Faulí 2019-10-16 15:51:05 UTC
Good news. It seems it can't be reproduced in

Versión: 6.3.3.1 (x86)
Id. de compilación: f41f4c7f9507aeca13cb9df51f34d80e8ba30a99
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

While i could reproduce it in 6.3.1.2.
it would be good if other could also verify it on their side. You can download 6.3.1.2 from https://www.libreoffice.org/download/pre-releases/.
Closing as RESOLVED WORKSFORME
Comment 11 Dieter 2019-10-16 20:18:09 UTC
(In reply to Xisco Faulí from comment #10)
> it would be good if other could also verify it on their side. You can
> download 6.3.1.2 from https://www.libreoffice.org/download/pre-releases/.
> Closing as RESOLVED WORKSFORME

I also can't reproduce in

Version: 6.3.3.1 (x64)
Build-ID: f41f4c7f9507aeca13cb9df51f34d80e8ba30a99
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 12 Mike Kaganski 2019-10-16 20:21:24 UTC
Confirm normal operation in Version: 6.3.3.1 (x64)
Build ID: f41f4c7f9507aeca13cb9df51f34d80e8ba30a99
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 13 Xisco Faulí 2019-10-16 21:55:31 UTC
Happy to hear.
Mike, Dieter, thanks for doublechecking!!