Description: Image on wrong page after undo rejecting track changes Steps to Reproduce: 1. Open the attached file 2. Set the cursor at the last paragraph in the document Insert a chart/image/ 3. Edit -> Track changes -> Reject all 4. Undo Actual Results: Image moves to the second page Expected Results: First page Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.1.0.0.alpha0+ (x64) Build ID: <buildversion> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL and in 4.4.7.2 not in 4.3.7.2
Created attachment 163698 [details] Example file
Working well in Version: 7.1.0.0.alpha0+ Build ID: d57b14e3394b081adf0888ed8dcb7b86d66c246c CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (ro_RO.UTF-8); UI: en-US Calc: threaded everything disappeared, except the chart which is on page 1.
I don't repro. Telesto: could you re-test? Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62 CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded Jumbo Arch Linux 64-bit Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: c6595e781cf20ab2825e9a2bd8592688f26448e3 CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 3 June 2021
Still repro related to step 2: -> Place cursor at the end/bottom of the document (toggle formatting marks on to see where) Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
I confirm this bug. In the step 2 there are 2 steps: set the cursor plus insert a chart. The chart is on page 2 after the undo. Version: 7.1.3.2 / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
(In reply to BogdanB from comment #5) > I confirm this bug. In the step 2 there are 2 steps: set the cursor plus > insert a chart. The chart is on page 2 after the undo. Ok, I repro with chart, but not with image. Arch Linux 64-bit Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: c6595e781cf20ab2825e9a2bd8592688f26448e3 CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 3 June 2021
Maybe depends of image size. If the image is taller, filing the page, on undo will move on the next one.
Tried bibisecting with Linux 44max, but got a bogus result. Someone else could try
This seems to have begun at the below commit. Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? Thanks @buovjaga - is it the same commit as yours? @Miklos - I see, the commit looks unrelated, but I can repeat that one commit before your commit it worked (git checkout c8369a9a3c22dd47486a7ce36a108d52e5f2b96e -> bug is here; git checkout HEAD~1 -> bug is not here). Maybe related to empty lines, which exist after your commit? c8369a9a3c22dd47486a7ce36a108d52e5f2b96e is the first bad commit commit c8369a9a3c22dd47486a7ce36a108d52e5f2b96e Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Mar 14 21:37:38 2015 +0800 source-hash-0d602133d627c1837eb64895855c2a7ed0144de6 commit 0d602133d627c1837eb64895855c2a7ed0144de6 Author: Miklos Vajna <vmiklos@collabora.co.uk> AuthorDate: Mon Jun 16 18:45:05 2014 +0200 Commit: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Tue Jun 17 01:16:20 2014 +0200 svx: fix VML export of rectangles imported from drawingML This wasn't a problem before, as EnhancedCustomShapeTypeNames wasn't involved for the export of rectangles, as those were handled in sw directly. CppunitTest_sw_ooxmlsdrexport's testFdo69636 is a reproducer for this problem, the VML fallback part was empty due to this. Change-Id: Ib2622fe05ddaa66bb3231977e30a8a1ca8748001
Created attachment 184348 [details] empty lines after the commit 0d602133d627c1837eb64895855c2a7ed0144de6
(In reply to raal from comment #9) > This seems to have begun at the below commit. > Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? > Thanks > > @buovjaga - is it the same commit as yours? Could have been, sorry for not sharing it in 2021. Now I checked in 44max the commit you shared and the previous and I confirm. I also see that the example document contains three drawing shapes. There is also a difference between the two commits in how the elements on the page are laid out upon opening.
Oh wow, a 4.4 bug, that's really old. :-) Thanks for looking into this. The commit is related because even if the bugdoc is an odt file, it contains shapes where the shape type is set to "ooxml-rect". I tried reverting the mentioned commit, bit I can still reproduce the bug, so something else broke this in the meantime as well. Otherwise it would not be a huge problem to just revert the above commit: VML export is only relevant for MSO 2007 and earlier, which is EOL more than 5 years ago. If somebody wants to do that, you could do a bisect (not bibisect) with the above commit reverted to find the other commit(s) that breaks this scenario. Oh, and for me inserting a random image didn't reproduce, I had to use the toolbar button to insert a chart. Adjusting keywords accordingly.