Bug 137117 - Limit dragging of sidebar to the title bar (not the whole deck) (see comment 5)
Summary: Limit dragging of sidebar to the title bar (not the whole deck) (see comment 5)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-UI-UX
  Show dependency treegraph
 
Reported: 2020-09-29 08:15 UTC by Telesto
Modified: 2020-10-05 14:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screencast (1.04 MB, video/mp4)
2020-10-03 07:16 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-09-29 08:15:06 UTC
Description:
Slightly to easy for certain panels to make they sidebar floating 

Steps to Reproduce:
1. Open Writer
2. open the sidebar -> Page deck
3. Left Click somewhere in the gray area and drag slightly

Actual Results:
The full gray area can be used to make deck floating. Depends on how much gray there is in the deck (compare Inspector or Navigator)

Expected Results:
Limited by the title bar of the deck? Would limited the unintended 'make floating'. I don't see the point of the ability to having make float everywhere


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-09-29 08:16:29 UTC
Later on it can be expanded to 'headings of decks'. See bug 85905
Comment 2 Heiko Tietze 2020-09-29 09:45:05 UTC
Don't see the problem. You have to drag quite far to make the sidebar floating and feedback is clear with dashed frame vs. dotted. There will be always white space and we cannot fill up the sidebar with controls to avoid dragging. Using a dedicated action (like Hamburger Menu > Start dragging) is also not a solution. => WF
Comment 3 Telesto 2020-09-29 09:52:33 UTC
(In reply to Heiko Tietze from comment #2)
> Don't see the problem. You have to drag quite far to make the sidebar
> floating and feedback is clear with dashed frame vs. dotted. There will be
> always white space and we cannot fill up the sidebar with controls to avoid
> dragging. Using a dedicated action (like Hamburger Menu > Start dragging) is
> also not a solution. => WF

Hmm OK.. lets limit to my specific issue which I did encounter (which why I requested it)

1. Open Writer
2. Sidebar Properties deck
3. Switch to Page Deck
4. Check Margin checkbox -> Drag to float is being activated too
Comment 4 Heiko Tietze 2020-09-29 10:18:38 UTC
(In reply to Telesto from comment #3)
> 4. Check Margin checkbox -> Drag to float is being activated too

Still don't see an issue.
Comment 5 V Stuart Foote 2020-09-29 13:38:51 UTC
This is valid.

Seems the GUI target for the drag action is the whole deck including the content panels. Drag-n-undock probably should be limited to just the Deck's Title bar, rather than the Deck's frame.  More consistent to how the drag-n-dock action is targeted for Sidebar in undocked state.
Comment 6 andreas_k 2020-10-01 15:12:24 UTC
It's true but I didn't see there a big issue. you can maybe say only if an user use the undock command (from the configuration menu button).
Comment 7 Telesto 2020-10-03 07:16:34 UTC
Created attachment 166048 [details]
Screencast

For the record.. the issue I reported started with this
1. Open Writer
2. Sidebar Properties deck
3. Switch to Page Deck
4. Check Margin checkbox -> Drag to float is being activated too

Apparently a right click on the deck is needed too. So it does not happen 'always'

So in doing think clicking everywhere is huge problem (except if you hit the example above). OTOH, don't see the advantage. As this heavily dependent on the content of the deck. 

So I'm going with Stuart his opinion in principle.