Bug 142668 - Reject all doesn't delete text caption frame + image after ODT to DOCX conversion (working for DOC)
Summary: Reject all doesn't delete text caption frame + image after ODT to DOCX conver...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: DOCX-Track-Changes
  Show dependency treegraph
 
Reported: 2021-06-05 07:31 UTC by Telesto
Modified: 2023-07-29 15:31 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Simple reproducer with shape, shape+textbox and image caption frame (27.61 KB, application/vnd.oasis.opendocument.text)
2021-06-24 06:16 UTC, NISZ LibreOffice Team
Details
The simple reproducer saved as docx with current master (18.89 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-06-24 06:17 UTC, NISZ LibreOffice Team
Details
The reproducer file and its docx version before rejecting changes (83.14 KB, image/png)
2021-06-24 06:20 UTC, NISZ LibreOffice Team
Details
The reproducer file and its docx version after rejecting changes (63.82 KB, image/png)
2021-06-24 06:21 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-06-05 07:31:36 UTC
Description:
Reject all doesn't delete text caption frame + image after ODT to DOCX conversion

Steps to Reproduce:
1. Open attachment 163698 [details]
2. Save as DOCX
3. Edit -> Track Changes -> Reject all 

(Compare with ODT -> where document will be empty)

Actual Results:
Caption frames still present

Expected Results:
Empty document


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-06-05 07:37:44 UTC
Found in
Versie: 6.0.4.1
Build ID: a63363f6506b8bdc5222481ce79ef33b2d13c741
CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: GL; 
Locale: nl-NL (nl_NL); Calc: CL

and in
4.4.7.2

and in 
4.2

and in
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
Comment 2 Telesto 2021-06-05 07:38:25 UTC
STR correction:
1. Open attachment 163698 [details]
2. Save as DOCX
3. File reload
4. Edit -> Track Changes -> Reject all
Comment 3 Dieter 2021-06-21 06:06:28 UTC
I confirm the dscribed behaviour, but I don't know, what the bug is. In original file frames aren't marked as changes and therefor behaviour in docx-file could be correct.
Comment 4 NISZ LibreOffice Team 2021-06-24 06:14:35 UTC
There are many things in play with this document.
First the caption frames (anchored to paragraph) are copy-pasted with text into a new change-tracked document.

The frame is anchored to a pasted paragraph, so it's recorded in odt.
Then on docx export the frame is converted into a shape with textbox, and it seems like change tracking of such shapes is not properly supported in Writer.

Normal shapes anchored to inserted text can be rejected with the text, see bug 139228 and bug 139229 - those situations works even with docx. The more I look at them and what Word does (the same: added text + a shape anchored it is one change), the more I think those two are fine behavior and this one is a real docx bug.
Comment 5 NISZ LibreOffice Team 2021-06-24 06:16:23 UTC
Created attachment 173130 [details]
Simple reproducer with shape, shape+textbox and image caption frame
Comment 6 NISZ LibreOffice Team 2021-06-24 06:17:05 UTC
Created attachment 173131 [details]
The simple reproducer saved as docx with current master

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: f6b9f671d128c989ce223d61d0d5d43ff1dc9fcb
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 7 NISZ LibreOffice Team 2021-06-24 06:20:32 UTC
Created attachment 173132 [details]
The reproducer file and its docx version before rejecting changes

These are all anchored as character.

Don't be distracted by the doubling triangles with textboxes, that's a separate issue.
Comment 8 NISZ LibreOffice Team 2021-06-24 06:21:33 UTC
Created attachment 173133 [details]
The reproducer file and its docx version after rejecting changes

The simple triangle disappears, the caption frame stays.
Comment 9 QA Administrators 2023-06-25 03:13:28 UTC Comment hidden (obsolete)
Comment 10 Dieter 2023-07-29 15:31:11 UTC
Still present. tested with attachment 173130 [details] and

Version: 7.6.0.1 (X86_64) / LibreOffice Community
Build ID: 776eaf34564cbf3f034a0ba1fd1d5c32ff9ccf1c
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded