Bug 143260 - FILEOPEN DOCX After rejecting a table insert change, Writer leaves an empty table
Summary: FILEOPEN DOCX After rejecting a table insert change, Writer leaves an empty t...
Status: VERIFIED DUPLICATE of bug 143215
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX-Track-Changes
  Show dependency treegraph
 
Reported: 2021-07-08 12:59 UTC by NISZ LibreOffice Team
Modified: 2021-08-04 06:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
The example file with the inserted table created in Word (12.81 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-07-08 12:59 UTC, NISZ LibreOffice Team
Details
Screenshot of the document with the inserted tables side by side in Writer and Word (95.60 KB, image/png)
2021-07-08 13:00 UTC, NISZ LibreOffice Team
Details
The example file in 7.3 (155.77 KB, image/png)
2021-07-23 07:43 UTC, NISZ LibreOffice Team
Details
The example file in 7.3 (162.36 KB, image/png)
2021-07-23 07:52 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-07-08 12:59:44 UTC
Created attachment 173451 [details]
The example file with the inserted table created in Word

Insert a new table in MS Word with Track Changes turned on. Opening this .docx in Writer and rejecting the change in the Manage Changes panel will leave an empty table in the document.


Steps to reproduce:
1.	Open attached .docx file in MS Word.
2.	In the Reviewing pane, we can see the changes (inserted a new table).
3.	Open attached .docx file in LO Writer.
4.	Under the Manage Changes panel, reject the change.

Actual results:
After opening the file in Writer and rejecting the change, it leaves an empty table in the document. 

Expected results:
Rejecting the change should delete the table.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bd2f2273d83dcca43eb6b465308707efd45e7adf
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Also in 6.0, 5.0.

But not yet in 4.4, which saw one insertion and rejecting it removed the empty table as well.
Comment 1 NISZ LibreOffice Team 2021-07-08 13:00:33 UTC
Created attachment 173452 [details]
Screenshot of the document with the inserted tables side by side in Writer and Word
Comment 2 NISZ LibreOffice Team 2021-07-09 08:08:56 UTC
Seems to have started with:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c4cf85766453982f1aa94a7f2cb22af19ed100be

author	Michael Stahl <mstahl@redhat.com>	2015-05-05 23:15:20 +0200
committer	Michael Stahl <mstahl@redhat.com>	2015-05-06 00:10:17 +0200
commit c4cf85766453982f1aa94a7f2cb22af19ed100be (patch)

sw: fix crash due to redlines on tables on ooo121112-2.docx
Comment 3 Buovjaga 2021-07-19 16:32:43 UTC
Repro, when I reject the first change

NixOS
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 4 NISZ LibreOffice Team 2021-07-23 07:43:39 UTC
Created attachment 173792 [details]
The example file in 7.3

This changed with:
https://git.libreoffice.org/core/+/03b29d4ddb99337c4d54b241020c95e8b2a66991
tdf#143278 DOCX: support tracked table (row) insertion

Now the first row of the inserted table disappears, but the second (which had no content) stays.
Comment 5 NISZ LibreOffice Team 2021-07-23 07:52:00 UTC
Created attachment 173793 [details]
The example file in 7.3

This got fixed by

https://git.libreoffice.org/core/+/a483a44ca00f43a64ae51d62b8fbb4129a413f6d%5E%21

author	László Németh <nemeth@numbertext.org>	Tue Jul 13 13:35:15 2021 +0200
committer	László Németh <nemeth@numbertext.org>	Tue Jul 13 16:48:46 2021 +0200

tdf#143215 DOCX import: fix tracked empty row insertion/deletion
Comment 6 NISZ LibreOffice Team 2021-07-23 07:52:18 UTC

*** This bug has been marked as a duplicate of bug 143215 ***
Comment 7 NISZ LibreOffice Team 2021-08-04 06:04:29 UTC
Verified in: 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ad1b12686da88bea57582df10fa85268ada209b8
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded