The sidebar .ui files are gtkboxes, gtkgrids, boxes within boxes, ... As the construction is nearly always different I would suggest to harmonize the structure so that if someone will theme the sidebar the structure is always the same and it's than way easier to do any generic stuff for all sidebar elements. From my point of view, I would have gtkbox gtkbox (label left aligned) space gtkbox (right aligned) that's it. So if someone want to define a fix width for the right aligned gtkwidgets (dropdown, input field, ...) everything will be aligned.
And yes this harmonization will help also CollaboraOnline sidebar .css theming.
Heiko, what do you think? Personally I always support simplification ideas =) Btw, gtkGrid may be more universal?
In most cases a GtkGrid should result in a cleaner layout. The sidebar consists however of a number of different UIs and it depends.
I agree with @Heiko grid gives us warranty all the rows will be equally aligned. If we have box for every row - all the cells will be positioned individually. Also sometimes we don't use "merging cells" feature of a grid so there is a box inside grid and things become more complex :)
Ok than let's go with a grid for all sidebar UI files. It will take some time, but I will propose some Merge Requests.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e960180092a30738655e7e091b51f690914461ce tdf#148017 harmonize sidebar .ui files It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fixed?
Charts ui files will come soon.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0f0fd9c6e35a86f03606361211067c7887c3e0fc tdf#148017 harmonize sidebar .ui files for chart2 It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.