Bug 149589 - Calc fails to open context menu in edit-mode for some cell contents (breaks spell checker and other features)
Summary: Calc fails to open context menu in edit-mode for some cell contents (breaks s...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-06-16 18:20 UTC by OfficeUser
Modified: 2022-10-22 22:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Testkit (8.00 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-06-16 18:20 UTC, OfficeUser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description OfficeUser 2022-06-16 18:20:46 UTC
Created attachment 180801 [details]
Testkit

Hi,

- please open the attached spreadsheet file

- (Cell A1 should be already selected. If not, select it.)

- Press F2 to enter cell-edit mode

- Move the mouse pointer over cell A1 and click the right mouse button

Result: The context menu does NOT appear!

Expected result: The context menu should appear.

If you copy the cell content text of A1 into other cells the target cells are affected by the same bug.


A fix is important because a missing context menu breaks many common used features. A very critical problem is that the suggestions of the automatic spelling correction cannot be accepted due to this.
Comment 1 m_a_riosv 2022-06-16 20:53:32 UTC
Repro.
The issue looks relative, with the text beginning with a hyphen.

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL
Comment 2 m_a_riosv 2022-06-16 20:55:46 UTC
When beginning with a minus '-' or a plus '+'.
Comment 3 Buovjaga 2022-06-17 08:27:01 UTC
Bibisected with linux-64-7.3 to
https://git.libreoffice.org/core/commit/5cc40c5b89c8d651e9d38d2b6d388399c3fe8664
ScInputHandler::UpdateFormulaMode() also for multi-line formulas
Comment 4 Eike Rathke 2022-06-20 20:55:32 UTC
Yeah it's the dreaded "+ and - may start a formula" thing, which for already existing cell content is nonsense because if that was already a formula it would start with = nevertheless (though the input handler doesn't know about whether it edits already existing content, needs to be decided earlier). Previously a formula could not be multi-line but now it can, so it triggers for such content as well.
Comment 5 Eike Rathke 2022-06-21 12:30:33 UTC
Fixed by
https://git.libreoffice.org/core/commit/909cdd552199d35f7c10be0a8be370158aea0815
on master for 7.5.0,
https://git.libreoffice.org/core/commit/34745c2fdc6a9f75512f793310f95e17c72b6267
on libreoffice-7-4 for 7.4.0.0.beta2
(both erroneously tagged with tdf#142293)

Pending review https://gerrit.libreoffice.org/c/core/+/136173 for 7-3
Comment 6 Commit Notification 2022-06-22 18:44:29 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/2f6b667ce9bf3d3d1bfd13d25b6c7605fc01577c

Resolves: tdf#149589 No "+ or - may start formula" when editing content

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.