Bug 151658 - Track change: accept of deletion of a table row with nested table deletes only the text content, but not the table row
Summary: Track change: accept of deletion of a table row with nested table deletes onl...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: Track-Changes-Table
  Show dependency treegraph
 
Reported: 2022-10-20 13:09 UTC by NISZ LibreOffice Team
Modified: 2022-11-28 12:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (10.98 KB, application/vnd.oasis.opendocument.text)
2022-10-20 13:10 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-10-20 13:09:47 UTC
Description:
If delete selected row of embadded table, after accepting the change, only deleted the content of the line, not the line (as opposed to the other "pink" lines).

Steps to Reproduce:
1. Open the attached file
2. Edit -> Track Changes -> Record ON (Show ON/OFF; no difference
3. Place cursor in the yellow cell (Row B)
4. Press Delete Row
5. Edit -> Track Changes -> Manage Changes -> Accept All

Actual Results:
Accepting a change only deleted the content of the line, not the line.

Expected Results:
Full row removed.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5a1f41a0d3aab15c113651f2edc9d4137ae99063
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded
Comment 1 NISZ LibreOffice Team 2022-10-20 13:10:17 UTC
Created attachment 183163 [details]
Example file
Comment 2 Commit Notification 2022-11-07 15:51:36 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d295ee0c34ed505a9673580b40ade3ce6947d99

tdf#151658 sw: accept of row deletions with nested tables

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 NISZ LibreOffice Team 2022-11-28 12:10:04 UTC
Verified in:
Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 5b18eebc2c95321ce7e6edf10f4df81557382a48
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded