Created attachment 115945 [details] Attachement is "Add Field Dialog". Insert button is right Insert icon is not shown on report builder "add field dialog". Insert button is shown. is it true? Insert icon on LibreOffice 4.4 is shown. OS : Linux
I could confirm a button is shown. In older version appears a icon - but this icon doesn't look as a icon for inserting anything. The same icon has been used in older LO-versions for deleting or sorting groups in a report. It seems to be a default-icon, if there couldn't be found any icon, but a icon had been planned. So the short-help while pushing the mouse over the icon is needed to understand the reason for the icon. I set this bug to New, but the Importance to low. I would prefer the button instead of an icon without relationship to the command "Insert".
Is the 'Insert' icon shown when you have the Galaxy icon theme selected (Tools > Options > View )?
(In reply to Yousuf (Jay) Philips from comment #2) > Is the 'Insert' icon shown when you have the Galaxy icon theme selected > (Tools > Options > View )? On pc Debian x86-64 with master sources updated today, default theme is Tango for me. In this case, no icon, just "Insert". If I choose Galaxy theme, there's an icon, but its purpose is not very clear if we don't hover the mouse on it to have the short help as Robert indicated.
(In reply to Julien Nabet from comment #3) > On pc Debian x86-64 with master sources updated today, default theme is > Tango for me. In this case, no icon, just "Insert". Means that the change in the icon system in 5.0 isnt working correctly if galaxy is installed and the galaxy icon isnt showing in tango when tango doesnt have the icon. > If I choose Galaxy theme, there's an icon, but its purpose is not very clear > if we don't hover the mouse on it to have the short help as Robert indicated. Would be useful to get a screenshot of the dialog with galaxy icons, Digging through the source code, i found references to the insert button as RID_STR_INSERT and m_aInsertButton in the following files, but couldnt track down the uno command or icon filename path. reportdesign/source/ui/report/report.src reportdesign/source/ui/dlg/AddField.cxx reportdesign/source/ui/inc/AddField.hxx It would be useful to know some exact steps to open this dialog in Base. @Maxim: Could you track down which icon it is?
Created attachment 119516 [details] screenshot To reproduce this: 1) create a brand new odb file (hsql embedded) 2) create a table with wizard with 2 fields taskid, Notes => finish button, close table 3) click Reports on Database pane (at left) 4) Create a report in Design view 5) Click on a field so the insert icon is enabled (see attachment)
This code pointer may help to start investigation: http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/CondFormat.src#57
(In reply to Julien Nabet from comment #5) > Created attachment 119516 [details] > screenshot The icon used for insert button is the broken image icon (/icon-themes/galaxy/res/grafikde.png), which explains why the icon wasnt understandable. (In reply to Julien Nabet from comment #6) > This code pointer may help to start investigation: > http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/ > CondFormat.src#57 Thanks for the pointer. Looking at link below, you can see that they have only assigned icons to 3 of the buttons in the dialog and the insert icon is likely just taking the broken image icon as none was assigned to it. http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/CondFormat.src#94 So i see the broken image icon has always been displayed in galaxy and tango all the way back to 3.5.7, so this has always been broken. So what is needed is to decide which icon should be used for the Insert button. We could use the 'Add Field' icon :- http://cgit.freedesktop.org/libreoffice/core/plain/icon-themes/galaxy/cmd/lc_addfield.png http://cgit.freedesktop.org/libreoffice/core/plain/icon-themes/tango/cmd/lc_addfield.png Would be useful to also change the tooltip from just 'Insert' to 'Insert Field' or something like that.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.6 or 5.2.3 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20161108
Nothing changed. No Icon for Insert in the dialog, only a button with "Insert" written on it.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Bug still exists with LO 6.0.5.2, OpenSUSE 42.3 Leap, 64bit rpm Linux.
Dear sawakaze, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Bug still exists on LO 6.2.4.2, OpenSUSE 15 64bit rpm Linux
Heiko/Xisco: any thoughts about UI point from https://bugs.documentfoundation.org/show_bug.cgi?id=91565#c7 ?
Reproducible with Karasa Jaga icons in 6.4 master build Version: 6.4.0.0.alpha0+ Build ID: ee8bc3fbd5aa83112cd9cfef6788d2b3a2e55afe CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-16_00:22:26 Locale: id-ID (id_ID.UTF-8); UI-Language: en-US Calc: threaded Though there's icon-themes/karasa_jaga/res/grafikde.png icon included. I have tried to copy Galaxy icons to the dev directory and the result is the same: there's no icons appear. Just tell us which icon should be added.
Let's put needsUXEval following Rizal's comment.
(In reply to Rizal Muttaqin from comment #15) > I have tried to copy Galaxy icons to the dev directory and the result is the > same: there's no icons appear. > > Just tell us which icon should be added. Rather a question to dev.
I submitted this patch: https://gerrit.libreoffice.org/c/core/+/92228 If something thinks about a more appropriate icon, don't hesitate to tell!
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d08e053f256bddeea9b96dbd73637ce360c32bf tdf#91565: Report builder, missing insert field icon It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Backport for 6.4 branch waiting for review here: https://gerrit.libreoffice.org/c/core/+/92323
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/644c9f8360818d37428d30bc5a6a90412d3983da tdf#91565: Report builder, missing insert field icon It will be available in 6.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.