In this case WollMux is conneted then: - Start writer, enter a text or open a document and change the text - then close the LO-window, the dialog "Save Document?" answer with "Save" - after save or save as, LO do not close the window The main problem is when you close or Log out over KDE, then this process is break and in some situations the KDE freeze. The problem is not only in WollMux it is in both. The background is in comment 1
Problem: - When the WollMux is connect, in this Line http://opengrok.libreoffice.org/xref/core/sfx2/source/control/bindings.cxx#1092 it is true. The problem here is here http://opengrok.libreoffice.org/xref/core/sfx2/source/control/bindings.cxx#1105 we get not a result and set always to false. - Without WollMux here http://opengrok.libreoffice.org/xref/core/sfx2/source/control/bindings.cxx#1148 we get the result, and in this case it works fine. - We need a return value but the main problem is the XDispatch-Interface this is asynchon and has no result Solution: - We using the XNotifyingDispatch in this case we get a result, in LO is that synchron, but in the extention i have not found for must synchron. Problem with XNotifyingDispatch: - In Lo i must wait of the result, but that run in the main-thread and hang when i wait, my momentan solution is, WollMux works synchron too. - The question here, exist a solution for this situation, i think a new thread is not possible, in case of KDE-Closing it must end with result. But when exist a extra Session-Manager-Thread in this case we can wait, but we should different between the main-thread and the session-manager-tread, i belive when the main-thread is come we start in this case a new thread, but i'm not sure Other Problem with this new patch is here http://opengrok.libreoffice.org/xref/core/sfx2/source/control/unoctitm.cxx#861 pItem is SfxBoolItem and the Value should be True or False but the test is only for a correct pointer that is always, in this case when save was not possible the windows was close, have fixed too. Here my Patch as a draft https://gerrit.libreoffice.org/24953
I've noticed some recent work from M Meeks, perhaps you should ping him on IRC or on dev mailing list? (see https://cgit.freedesktop.org/libreoffice/core/commit/?id=02833c03ee856a62d7185829b7c47bc088e086cc)
Hi Julien, thank you for the hint, but i think the stuff of M Meeks is a new feature, but my patch solved this above descript bug. I have set Thorsten Behrens as a reviewer, and he looks for other reviewer when it it possible
Juergen Funk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9bb13419549d621ffd55d9d81e0732a89560e2e tdf#99815 use XNotifyingDispatch in sfx2 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Juergen Funk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a5cb3dae1760283c2c9156de666964ea4794f0f tdf#99815 fixups after XNotifyingDispatch It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jürgen: can the status be set to FIXED?
Hi Buovjaga yes i thinks so, but in this dependent is here a other patch 903e60753f4cf8fb03e27ed312a699f72ac1649a and there is importent, too. In my case the patch working juergen