Created attachment 39112 [details]
patch to convert QueryValue() and PutValue() virtual funcitons to bool
The patch is very large (almost 1M), because both BOOL and sal_Bool are defined as unsigned char, and of course bool is... a boolean.
The C++ compiler doesn't like a virtual funciton declared as returning a unsigned char and re-implemented returnuing a bool.
So it is an all or nothing operation.
the only way to do that is phase would be:
1/ introduce a new typedef TBOOL as unsigned char
2/ do many small patchs to migrate the BOOL and sal_BOOL impacted by this patch to TBOOL
3/ a patch to change the typedef of TBOOL to bool
4/ another series of patch to change TBOOL to bool
5/ remove the TBOOL typdedef
committed; thanks ! :-)
Closing - Sophie