Download it now!
Bug 30801 - Removed tons of comments
Summary: Removed tons of comments
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 06:58 UTC by Gil Forcada
Modified: 2011-01-13 06:41 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Remove tons of comments (772.79 KB, patch)
2010-10-12 07:12 UTC, Gil Forcada
Details
Remove comments, death code and trailing spaces (510.42 KB, patch)
2010-10-12 13:48 UTC, Gil Forcada
Details
Removed comments, trailing spaces and death code (2) (302.46 KB, patch)
2010-10-12 14:54 UTC, Gil Forcada
Details
Removed comments, trailing spaces and death code (3) (44.66 KB, patch)
2010-10-12 15:15 UTC, Gil Forcada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gil Forcada 2010-10-12 06:58:34 UTC
As the patch weights 2.3 Mb I'm attaching it here.
Comment 1 Gil Forcada 2010-10-12 07:12:27 UTC
Created attachment 39384 [details]
Remove tons of comments
Comment 2 Michael Meeks 2010-10-12 08:57:43 UTC
Heh - sooo ... I'm torn on this one. Large automated code-cleanups like this are ok I guess but can create some merge problems.

Also - while I dislike the // ------------- stuff - it is nice to have at least a blank-line separating functions to make them more readable, and there is a good amount of:

 }
-// -------------------------------
 {

stuff in there :-) any chance of a new line instead ? or was this done manually ?

Thanks.
Comment 3 Michael Meeks 2010-10-12 13:36:40 UTC
Oh ! and I forgot to say - thanks for your patch ! :-) it's wonderful to have you contributing, sorry to be slightly nervous this once.
Comment 4 Gil Forcada 2010-10-12 13:48:09 UTC
Created attachment 39397 [details]
Remove comments, death code and trailing spaces

Sorry to send such a big patch before, here is a small more well-formed one.

It "fixes" the code for base/dbaccess/source/core/api/* files.
Comment 5 Gil Forcada 2010-10-12 14:54:31 UTC
Created attachment 39398 [details]
Removed comments, trailing spaces and death code (2)

This patch cleans the base/dbaccess/source/core/dataaccess/*.* files
Comment 6 Gil Forcada 2010-10-12 15:15:41 UTC
Created attachment 39400 [details]
Removed comments, trailing spaces and death code (3)

This patch cleans the base/dbaccess/source/core/inc/*.* files
Comment 8 sophie 2011-01-13 06:41:31 UTC
Closing - Sophie