Bug Hunting Session
Bug 31363 - "Insert OLE object" with no Icon
Summary: "Insert OLE object" with no Icon
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Windows (All)
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-03 10:50 UTC by Olivier Hallot
Modified: 2017-04-20 08:29 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Insert | Object | OLE Object on Ubuntu (54.30 KB, image/png)
2012-03-23 07:30 UTC, grofaty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2010-11-03 10:50:30 UTC
Hi,

On inserting an OLE object (a calc speradsheet or a pdf file) into a Writer document and choosing to display an icon instead of the content does not show the right icon at all.

steps to reproduce:

Open a writer file, insert an Object (Insert - Object - OLE Object)

Choose "Create new" and "Aditional objects", Click OK.

Whichever is the choice "create new" or "create from file", chose a file type.

Click "Change Icon" button

Select an Icon, click OK.

Icon is not shown in dialog.

Click OK

Icon is not shown in the document.

The bug exist in OO 3.2, 3.2.1, 3.3 RC2 and LibreOffice Beta 3.3 beta 2 for Windows.
Comment 1 Olivier Hallot 2010-11-04 09:12:32 UTC
more investigation on this:

When the OLE object is displayed as a (missing) icon, and user closes the document and opens it later, the OLE object is vanished.

No way to recover it unless reworking the OLE embed procedure.

Is this as a loss of data?
Comment 2 Petr Mladek 2010-11-04 11:33:03 UTC
It seems to be Windows specific. I do not see the "Aditional objects" option on Linux.

Tor, could you please have a look?
Comment 3 Olivier Hallot 2010-11-08 08:15:41 UTC
this may help

http://qa.openoffice.org/issues/show_bug.cgi?id=111444
Comment 4 Don't use this account, use tml@iki.fi 2010-11-17 02:35:55 UTC
For me, it says "Further objects" and not "Additional objects".

Anyway, as far as I could see, LibreOffice behaves like vanilla OOo 3.2.1 here.

If you see a difference in behaviour between LibreOffice 3.3 (some beta, or eventual official release), and vanilla OOo 3.2.1 or vanilla OOo 3.3 (some release candidate, or eventual official release), please provide *exact* reproduction instructions, and reopen.
Comment 5 markusbern 2011-01-25 09:26:51 UTC
the error, as descriped, is in the final version. OLE imports the complete document instead of creating an icon. Mac OS 10.6.7. Calc object to writer.
Comment 6 Noel Power 2011-01-25 11:50:27 UTC
well I can't reproduce this, e.g. true the icon isn't displayed but there is a placeholder frame ( with no image ) and some default text ( like 'Acrobat document' or 'Worksheet') 

There is afaics no data loss as the embedded document is still there and can be opened ( e.g. still works after closing and re-opening the document )

If the reporter of comment #5 is seeing that the document itself is being inserted instead of a document then that would seem to be a different bug ( probably macosx specific )
Comment 7 markusbern 2011-02-12 08:26:34 UTC
The bug (as described) is still here in 3.3.1 rc1
Comment 8 markusbern 2011-02-23 05:28:19 UTC
(In reply to comment #7)
> The bug (as described) is still here in 3.3.1
Comment 9 grofaty 2012-03-23 07:11:32 UTC
Tested on LibreOffice 3.5.1 on Windows XP. The same problem as in "bug report" (Note: as Tor has pointed out there is text "Further objects" and not "Additional objects"), but the problem is the same - no icon in target document.

I am changing the bug: Version=3.5.1 and Platform=All
Comment 10 grofaty 2012-03-23 07:30:47 UTC
Created attachment 58930 [details]
Insert | Object | OLE Object on Ubuntu
Comment 11 Andras Timar 2012-05-23 13:56:25 UTC
I can reproduce the bug on Windows XP. It seems that this "Insert Object" dialog, which is coming from Windows, can only handle 16 color icons. In LibreOffice, and in many other applications such as Adobe Reader, icons have 256 color or more. 

However, on Windows 7 is seems to be fixed, "Insert Object" dialog can display icons with higher color resolutions.
Comment 12 tommy27 2014-05-04 06:24:26 UTC
what should we do with XP-specific bugs since Microsoft declared end of life of that O/S?
Comment 13 Joel Madero 2014-11-02 16:06:30 UTC
NEW is appropriate status - updating per comment 11.
Comment 14 Matthew Francis 2015-04-06 12:39:21 UTC
As per comment 0:

-> Version: Inherited from OOo
Comment 15 tommy27 2016-04-16 07:28:33 UTC Comment hidden (obsolete)
Comment 16 grofaty 2016-11-23 12:31:23 UTC
Hi,
I rested the problem on master and it looks it works for me. I don't have 100% the same strings as it was at bug report in year 2010 (probably some strings have changed), but it works for me now.

Just to make sure here are the steps:
Note: Make sure you have some PDF file, because it will be inserted in Writer document.
1. Open Writer and new document.
2. Menu Insert | Object | OLE Object.
3. Leave default "Create new" selection and from Object Type select "Further objects".
4. New dialog opens. At left site select "Create from File".
5. Click on Browser button and point to just some PDF file and click on Open button.
6. Returned to previous dialog. Click on "Display As Icon" checkbox and click OK button.
7. In main Writer document "PDF File" icon is displayed.
8. Make sure you delete original "PDF file" (or rename it in file manager), to make sure this file is really embed in Writer.
9. In Writer double click on "PDF File" icon and embed PDF file is displayed. So problem solved.

I have left this bug status untouched, because my reproduce scenario has little bit different wordings, so I would like if someone else can check original bug report and compare it to instructions in this post to confirm problem does not appear anymore.

Regards

===============
MASTER VERSION
===============
Version: 5.3.0.0.alpha1+
Build ID: f965a629fba10ecba7bad938a0c1c9c3db1e510d
CPU Threads: 3; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-23_00:13:10
Locale: sl-SI (sl_SI); Calc: group
Comment 17 grofaty 2016-11-23 12:32:57 UTC
Additional info... in my previous post I forgot to write I have been performing this tests on LibreOffice master on Windows 7.
Comment 18 Dieter Praas 2017-04-20 08:29:23 UTC
grofaty: I can confirm your solution with LO 5.3.2.2 and Windows 10. I assume, that something in the dialog has changed, because I can't find a "change icon" button as described in the original bug report, but the "display as icon button" you described in your solution.

=> set to WORKSFORME