Bug 32635 - BrOffice and Windows desktop integration
Summary: BrOffice and Windows desktop integration
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
(earliest affected)
3.3.0 RC2
Hardware: Other Windows (All)
: medium normal
Assignee: Fridrich Strba
Depends on:
Blocks: 31865
  Show dependency treegraph
Reported: 2010-12-24 02:35 UTC by Olivier Hallot
Modified: 2011-01-14 01:07 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

screenshot of the situation (685.89 KB, image/png)
2010-12-24 02:38 UTC, Olivier Hallot
Another place where intregration fails (40.02 KB, image/png)
2010-12-24 02:46 UTC, Olivier Hallot
Suggestion to merge BROffice to LibreOffice (13.09 KB, image/png)
2010-12-31 03:49 UTC, Renato S. Yamane
patch to fix window start menu / shortcuts (3.94 KB, patch)
2011-01-07 09:34 UTC, Michael Meeks
patch to fix windows BrOffice branding (4.41 KB, patch)
2011-01-07 09:45 UTC, Michael Meeks
imagem with glitch indicated (686.37 KB, image/png)
2011-01-08 07:49 UTC, Olivier Hallot
test patch (4.32 KB, patch)
2011-01-12 06:12 UTC, Michael Meeks

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2010-12-24 02:35:07 UTC

The Mindows installation of BrOffice stille carries the name LibreOffice for the icons in the desktop an the menus.

It should be BrOffice.

See image attached.
Comment 1 Olivier Hallot 2010-12-24 02:38:54 UTC
Created attachment 41417 [details]
screenshot of the situation

Icons and menus of MS Windows still carries the name LibreOffice and should change to BrOffice.
Comment 2 Olivier Hallot 2010-12-24 02:46:25 UTC
Created attachment 41420 [details]
Another place where intregration fails

The screenshot shows the Windows control Panel where LibreOffice name still appears. Should be changed to BrOffice
Comment 3 Renato S. Yamane 2010-12-31 03:49:11 UTC
Created attachment 41546 [details]
Suggestion to merge BROffice to LibreOffice

I think is better try change slowly the brand "BROffice" to "LibreOffice", so, at this time maybe is a good idea add the warning on splash screen like this:

A suitable from LibreOffice

Check image attached.

This is necessary to users know that BROffice is just a LibreOffice.

Releases after release, BROffice must decrease the logo size and the name LibreOffice must increase, until the logo BROffice will be removed.
Comment 4 Michael Meeks 2011-01-06 03:07:40 UTC
Olivier - if this is a blocker for you, you need to add a comment to the 3.3 tracker bug here:


Almost all of these strings that mention the wrong name, and in the Brazilian translations; as such - of course, I can go manually changing them, but this should mostly be just a matter of finding / fixing Brazilian strings. I can have a look into that later.  I am not certain that we can fix the MSI / un-install stuff for 3.3 - but lets see.
Comment 5 Michael Meeks 2011-01-06 04:12:56 UTC
Renato: the decision was made, before TDF was formed to keep the BrOffice brand for Brazil, for the forseable future - it has great name recognition there, and gives us a nice clean switch from OO.o to LibreOffice; so we won't do that I think :-)
Comment 6 Michael Meeks 2011-01-06 09:09:12 UTC
I believe the menu/desktop icons come from Shortcut.idt.pt-BT, prodding that.
Comment 7 Michael Meeks 2011-01-07 09:06:57 UTC
Shortcut.idt.pt-BR is generated by solenv/bin/installer/modules/windows/shortcut.pm (2nd half of create_shortcut_table). It gets the strings from the Name property of FolderItems in the scp2 - which is un-translated; digging there.
Comment 8 Michael Meeks 2011-01-07 09:34:11 UTC
Created attachment 41752 [details]
patch to fix window start menu / shortcuts

Attached patch to handle the shortcuts; I could use some sanity checking, it works for me - at least when generating the .idt files - giving the right translation for pt-BR, and the original ones for en-US and de (eg.).

Whether it works of course, is a different question :-) lets see.
Comment 9 Michael Meeks 2011-01-07 09:45:06 UTC
Created attachment 41753 [details]
patch to fix windows BrOffice branding

this (I hope) might clobber the application name as well, running a test build; I really need a Brazilian windows box to test/install to - my local windows XP machine doesn't take kindly to being told it is in Brazil (sadly).
Comment 10 Michael Meeks 2011-01-07 13:58:28 UTC
I sent a URL to a test package to Olivier and Claudio
Comment 11 Olivier Hallot 2011-01-08 07:48:41 UTC

Thank you for the link to download and test. I removed previous RC2 and installed this one... 

WRT firts attachment, a small glitch is left. See new attachment, and the red underline.

WRT the second attachement: fixed.

Thank you
Comment 12 Olivier Hallot 2011-01-08 07:49:46 UTC
Created attachment 41771 [details]
imagem with glitch indicated
Comment 13 Michael Meeks 2011-01-10 01:37:50 UTC
Pushed the fix to libreoffice-3-3; the top-level menu item is indeed irritating, but is not in Shortcut.idt
Comment 14 Michael Meeks 2011-01-10 05:08:22 UTC
It seems this last glitch comes from Director.idt which contains two problematic keys: 'OfficeMenuFolder' and 'INSTALLLOCATION' which need per-language-izing.
Unfortunately, the perl that builds them doesn't have a per-lang appreciation; so that needs adding - then (if we are lucky) msidb et. al. will unwind everything for us - though I'm not -that- optimistic.
Comment 15 Michael Meeks 2011-01-12 06:12:12 UTC
Created attachment 41924 [details]
test patch

Test patch attached; Thorsten reports that this renders the start menu as "LibreOfficedefoo 3.3" in his start menu, and it renders as "LibreOfficeen-USfoo 3.3" in mine.

Hopefully something similar holds the key to cleaner BrOffice specific MSI branding for 3.3.1+

I'll re-work it now to do something sane product-name wise instead :-)
Comment 16 Michael Meeks 2011-01-12 06:26:35 UTC
So - I pushed a fix to master:

review much appreciated. FWIW, I left the install-directory as LibreOffice 3 - that should be much less visible to end-users, and I don't believe it is a great idea to fiddle with this at this stage :-)

Review / sign-offs much appreciated.
Comment 17 Michael Meeks 2011-01-12 07:40:52 UTC
Test package for windows here:
This is only to test the start-menu issue for pt-BR; though it may fix (or break) other pieces.
Feedback appreciated.
Comment 18 Olivier Hallot 2011-01-12 08:43:56 UTC
Hi Michael

Downloaded and tested (Win XP under VirtuaBox). 
Glitch vanished.

Thank you indeed.
Comment 19 Don't use this account, use tml@iki.fi 2011-01-12 09:31:35 UTC
Patch in comment #16 looks fine to me.

I set my locale in the Regional settings to Portuguese (Brazil), and tried running the installer in comment #17, but didn't see any BrOffice branding, but is that visible only when the Windows localisation is Portuguese (Brazil) ?
Comment 20 Michael Meeks 2011-01-12 12:56:44 UTC
Tor - yes; unfortunately I can't seem to persuade my windows (XP) that it is -really- brazilian portugese by fiddling the settings that they tell you to - I have to use LANG=pt_BR + wine - which does not help with the start menu.

/me special cased de instead and asked Thorsten to test on a German box. Anyhow - I'm glad it also worked for you in English (it did for me).

Anyhow - glad to get this one finally fixed. One more review from Fridrich, and I'll merge it. Thanks !
Comment 21 Fridrich Strba 2011-01-12 12:58:51 UTC
My son, you have my blessing for this patch
Comment 22 Michael Meeks 2011-01-12 13:13:56 UTC
great; third approval, and I've committed it to libreoffice-3-3-0 and libreoffice-3-3.
Thanks guys !.
Comment 23 Olivier Hallot 2011-01-13 11:08:18 UTC
I may have missed something, but the fix here was not included in LO 3.3. RC3.

At best we need a RC4.

Comment 24 Don't use this account, use tml@iki.fi 2011-01-13 15:32:27 UTC
See also the thread http://lists.freedesktop.org/archives/libreoffice/2011-January/005831.html , where http://lists.freedesktop.org/archives/libreoffice/2011-January/005850.html includes a patch that should fix a problem that prevented the MSI phase of the multi-lingual installer from showing correct localisation.
Comment 25 Michael Meeks 2011-01-14 01:07:42 UTC
> I may have missed something, but the fix here was not included in LO 3.3. RC3.

Sure it missed the deadline RC3; but the bug is fixed, it will be in the next build.