Bug 33683 - colorpicker for font and background color no longer resizable
Summary: colorpicker for font and background color no longer resizable
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.3.0 RC4
Hardware: x86-64 (AMD64) Windows (All)
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard: color_handling
Keywords: difficultyBeginner, easyHack, regression, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2011-01-29 03:02 UTC by Christoph Thielecke
Modified: 2022-11-07 08:47 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot, comparison beetween LibreOffice and OpenOffice (29.16 KB, image/png)
2012-02-12 07:02 UTC, Jonas Schürmann
Details
Proposed patch (1.19 KB, patch)
2012-03-11 07:29 UTC, Laurent Balland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Thielecke 2011-01-29 03:02:04 UTC
The colorpicker dialog is no longer resizable. This is bad for users which have a small screen. Please allow to resize the colorpickers again.

Btw: I could not select calc so I select writer (has colorpickers too)

It works fine with OOo 3.2.0.
Comment 1 Rainer Bielefeld Retired 2011-02-05 04:46:11 UTC
[Reproducible] with "LibreOffice 3.3.0 RC4 - WIN7  Home Premium (64bit) German UI  [OOO330m19 (build 6 / tag 3.3.0.4)]". Affected are color pickers for character, character background, paragraph background and may be others, that were resizable in OOo 3.1.1, but no longer in LibO.
In OOo 3.4.-dev still those pickers still are resizable.

@reporter:
What OS did you test?
Comment 2 daz-bugzilla 2011-08-05 14:10:23 UTC
Also non-resizeable on Mac OS X 10.6.8
LibreOffice 3.3.2 
OOO330m19 (Build:202)
tag libreoffice-3.3.2.2

Thanks
Comment 3 Björn Michaelsen 2011-11-22 14:48:55 UTC
Still there in 3.4.4-0ubuntu1. EasyHackifying.
Comment 4 Björn Michaelsen 2011-12-23 11:52:40 UTC
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Comment 5 Björn Michaelsen 2011-12-23 12:57:22 UTC
An EasyHack should have been checked by developers and thus is confirmed regardless of age. Moving back to NEW from NEEDINFO again. Sorry for the hassle.
Comment 6 Jonas Schürmann 2012-02-12 07:02:46 UTC
Created attachment 56918 [details]
Screenshot, comparison beetween LibreOffice and OpenOffice
Comment 7 saurabh.chakrabarti 2012-02-28 13:39:10 UTC
Is the colorpicker part of the code in vcl module? I'm just starting out debugging. Any help is appreciated
Comment 8 Björn Michaelsen 2012-03-11 06:27:41 UTC
@saurabh: The toolbox controller at http://opengrok.libreoffice.org/xref/core/svx/inc/svx/tbcontrl.hxx should be a good starting point.
See also https://bugs.freedesktop.org/show_bug.cgi?id=34425 which is discussing related issues.
Comment 9 Laurent Balland 2012-03-11 07:29:33 UTC
Created attachment 58284 [details]
Proposed patch

Hello,

These "colorpicker" (Font color, Highlighting, Background) are handled by SvxColorWindow_Impl class.
The patch adds WinBits to the constructor of SvxColorWindow_Impl: the same from OOo 3.2.

Laurent BP
Comment 10 Laurent Balland 2012-03-11 14:11:02 UTC
Sorry I went too fast, the patch is not correct: the color window does not close after selection, it is kept floating. It needs deeper reflection...
Comment 11 Laurent Balland 2012-03-18 14:41:05 UTC
Hi,

Sorry, I spent my spare time on the wiki, and not on this issue. I may look at it later.

Laurent BP
Comment 12 Florian Reisinger 2012-05-18 09:55:38 UTC
Deleted "Easyhack" from summary.
Comment 13 Travis Carter 2012-06-20 14:56:57 UTC
It seem OOo and Libreoffce have diverged a bit here. OOo has a floating window whilst Libre uses a popup menu now. Are we trying to reinstate the floating window or keep the popup and make it resizable?

Also, is there some documentation for WinBit's that I'm missing? I found the header that defines them, but I can only guess as to what any of them do.
Comment 14 Michael Stahl (allotropia) 2012-07-06 09:13:32 UTC
Comment on attachment 58284 [details]
Proposed patch

according to comment #10 this patch should not be integrated,
setting the "obsolete" flag so it does not turn up in bugzilla queries.
Comment 15 Jan Holesovsky 2013-04-04 14:43:53 UTC
Let's close this as wontfix - LibreOffice uses a different thing here.

But still it is possible to make this floating - when you drag the popup by the title, it turns into the floating window, so I hope this is satisfying for people who need to move this...
Comment 16 Robinson Tryon (qubit) 2015-12-16 00:12:20 UTC
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicUi )
[NinjaEdit]
Comment 17 lily watson 2022-11-07 08:47:59 UTC
Thanks  for every other informative site. The place else may just I get that kind of information written in such an ideal means? https://1v1-battle.com/