Bug 36495 - Extension updates which are unavailable online cause crash when checking "show all updates" in Extension Manager
Summary: Extension updates which are unavailable online cause crash when checking "sho...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
3.4.0 Beta2
Hardware: Other All
: medium normal
Assignee: Not Assigned
Keywords: regression
Depends on:
Reported: 2011-04-22 09:11 UTC by anon
Modified: 2011-12-23 14:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Error massage during update (108.17 KB, image/jpeg)
2011-05-09 23:23 UTC, salusa_secundus
Apple crash stack trace for OOOP extension caused crash (43.03 KB, text/plain)
2011-05-10 01:32 UTC, Alex Thurgood
simple extension to crash LibO on update (795 bytes, application/vnd.openofficeorg.extension)
2011-05-10 09:55 UTC, André Schnabel
Suggested patch (985 bytes, patch)
2011-05-20 06:12 UTC, Don't use this account, use tml@iki.fi

Note You need to log in before you can comment on or make changes to this bug.
Description anon 2011-04-22 09:11:19 UTC
XP Pro SP3 all updates installed 32bit

Open LibO, then Extension Manager, then Check for updates.
Extension Update window opens and after several seconds LibO closes "silently" with no error messages.  
Have noted that despite NOT being chosen on installation the following extensions had been installed: Afrikaans, Kurdish, Nepali, Romanian, Spanish, Ukranian, Zulu.
Could crash be due to this?
Same behaviour on 2 PCs both same XP OS.
Comment 1 André Schnabel 2011-05-09 09:21:19 UTC
I cannot reproduce the crash here - update works fine for me.

Can you please verify with Beta4 if the crash still happens for you?

If yes: did you install any additional extensiosn od did you have an OOo installed on the same machine with installed extensions?
Comment 2 anon 2011-05-09 12:24:29 UTC
In reply to André Schnabel:
When 3.3 Final release came out problem ceased.
However 3.4Beta3 and 3.4Beta4 are once again showing same behaviour. I reported problems on installation with the rebasegui.exe file given the bug number 36679 for beta 3 and problem has persisted with beta 4.
Whether or not the virus detected is a false positive is probably not resolved finally but it does seem that rebasegui.exe has given rise to some problems over the years. 
In my updated  comments submitted earlier today I note that Extension Manager Update does not crash LibO if the file is replaced by the version in the last stable release (3.3), although giving an error message without LibO crashing..
OOo is no longer installed on the PC I am using for this, but there could be some stray entries somewhere.
Comment 3 salusa_secundus 2011-05-09 23:23:39 UTC
Created attachment 46517 [details]
Error massage during update
Comment 4 salusa_secundus 2011-05-09 23:26:04 UTC
I'm using LO 3.4 Beta4 on Win7 SP1 32bit German

I start the extension manager, choose Update.
For the extension "OOOP-templates-unified-de-2.6" from OxygenOfficeProfessional, I get an error "link does not exist", after confirming this massage and marking the checkbox "Show all updates" the system "silently closes".

This behaviour is reproduceable.
Comment 5 Alex Thurgood 2011-05-10 01:29:05 UTC
Hi all,

I get the same error message as attached to the bug after installing OOOP-accessories-

This indicates that LibO can not find, or parse, the required XML. It may therefore be that the extension is wrongly packaged with regard to the new extension framework developed for 3.3.x.

I can also confirm the crash. I am enclosing an Apple stacktrace.

The app crashes here by the looks of it :

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libdeploymentmiscmxi.dylib    	0x003a6d95 dp_misc::DescriptionInfoset::DescriptionInfoset(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::xml::dom::XNode> const&) + 21

I must add, however, that the crash appears to be specific to this extension. I tried with the mysql connector extension, for example, with an old version, that was then suggested to be updated by the extensions manager, and it worked fine. This OOOP extension is the only one so far that caused LibO to die.

The title of the bug ought to be changed to reflect that, unless there are other extensions which cause the same behaviour.

Comment 6 Alex Thurgood 2011-05-10 01:32:11 UTC
Created attachment 46521 [details]
Apple crash stack trace for OOOP extension caused crash
Comment 7 Alex Thurgood 2011-05-10 01:33:20 UTC
This is Kami's stuff as far as I can recall.

Comment 8 André Schnabel 2011-05-10 09:55:32 UTC
Created attachment 46556 [details]
simple extension to crash LibO on update
Comment 9 André Schnabel 2011-05-10 09:56:25 UTC
the crash happens everytime, when the update URL is not accessible. 

So we are at risk to crash anytime the extension website has a timout or user is just behind a firewall.

As testcase you may use the very simple crash_me.oxt.

- download and install crash_me.oxt
- close and restart LibreOffice 3.4
- go to extension manager and check for updates
- click away the error message
- click "show all updates"
- wait 2 seconds

-> crash

LibO 3.3 correctly displays a warning for the extension and that there was an unkown error with it. LibO 3.3 did *not* crash.
Comment 10 Alex Thurgood 2011-05-10 10:03:41 UTC
Changing title again to reflect the circumstances

Comment 11 Alex Thurgood 2011-05-10 10:10:17 UTC
blocker for 35673 ?

Comment 12 Don't use this account, use tml@iki.fi 2011-05-10 11:25:57 UTC
One more reason to remove this extension update stuff from LibreOffice?
Comment 13 Michael Meeks 2011-05-20 04:33:52 UTC
Wow; it is late to notice this - and yes it should have been proposed as a 'most annoying bug' long ago - to get some more visibility; thanks for the report !
Comment 14 Don't use this account, use tml@iki.fi 2011-05-20 05:50:47 UTC
Reproduced, debugging this now.
Comment 15 Don't use this account, use tml@iki.fi 2011-05-20 05:53:16 UTC
Isn't the title of this bug misleading, if it is only when checking the "show all updates" box that the crash happens... (It was quite hard to even find that box, at first I thought I couldn't reproduce the problem...)
Comment 16 Alex Thurgood 2011-05-20 05:58:57 UTC
(In reply to comment #15)
> Isn't the title of this bug misleading, if it is only when checking the "show
> all updates" box that the crash happens... (It was quite hard to even find that
> box, at first I thought I couldn't reproduce the problem...)

Well it defines both the problem and the circumstance under which the problem occurs in nearly a single line of verbiage ;-) maybe I ought to start honing my Perl mongering skills ;-)) but feel free to change to something you think is more relevant.

Comment 17 Don't use this account, use tml@iki.fi 2011-05-20 06:04:28 UTC
Stack at crash:

deploymentguimi.uno.dll!std::vector<dp_gui::UpdateDialog::DisabledUpdate,std::allocator<dp_gui::UpdateDialog::DisabledUpdate> >::operator[](unsigned int _Pos=0x00000000)  Line 785	C++
 	deploymentguimi.uno.dll!dp_gui::UpdateDialog::selectionHandler(void * __formal=0x066df468)  Line 1266 + 0x13 bytes	C++
 	deploymentguimi.uno.dll!dp_gui::UpdateDialog::LinkStubselectionHandler(void * pThis=0x066defa8, void * pCaller=0x066df468)  Line 1238 + 0xf bytes	C++

The line in dp_gui_updatedialog.cxx:

bInserted = showDescription( m_disabledUpdates[pos].aUpdateInfo );

and m_disabledUpdates is invalid, null or whatever the right term is, at least the MSVS debugger displays its value as [0x00000000](). Or does that just mean m_disabledUpdates (a std::vector) is empty?
Comment 18 Don't use this account, use tml@iki.fi 2011-05-20 06:12:01 UTC
Created attachment 46950 [details]
Suggested patch

This seems to help.
Comment 19 Don't use this account, use tml@iki.fi 2011-05-20 11:39:05 UTC
Patch pushed to master, -3-4 and -3-4-0.