Bug 36629 - Display of Module Tabs broken
Summary: Display of Module Tabs broken
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
3.4.0 Beta2
Hardware: Other All
: medium normal
Assignee: Noel Power
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 04:49 UTC by Noel Power
Modified: 2011-04-29 08:41 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
screwed up tab display (19.64 KB, image/jpeg)
2011-04-27 04:50 UTC, Noel Power
Details
what it should look like (24.01 KB, image/jpeg)
2011-04-27 04:51 UTC, Noel Power
Details
a possible fix (1.82 KB, patch)
2011-04-27 04:59 UTC, Noel Power
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Noel Power 2011-04-27 04:49:43 UTC
If you open modules from different libraries ( without dismissing the basic IDE ) then the tabbed layout of the available modules is deeply screwed up

To reproduce, 

a) open the basic organizer
    Tools | Macros | Organize Macros | LibreOffice Macros | LibreOffice Basic

b) navigate to MyMacros / Standard / Module1 / Main 
   click 'Edit'

In the bottom left corner you will see the Module1 tab ( and tabs for any other modules you may have in the Standard library

c) open another library, e.g. open the basic organizer like in the first step above

d) navigate to LibreOffice Macros / FormWizard / develop / PositionControls
   click 'Edit'

you should see a really horrific rendition of the tabs ( see attachments )
Comment 1 Noel Power 2011-04-27 04:50:25 UTC
Created attachment 46114 [details]
screwed up tab display
Comment 2 Noel Power 2011-04-27 04:51:19 UTC
Created attachment 46115 [details]
what it should look like
Comment 3 Noel Power 2011-04-27 04:56:08 UTC
seems this is related to changes made to the tabbar control. It looks like a combination of the fact that the BasicIDE reuses the same tabbar control for different libraries and also probably the usage of the tabbar control from the BasicIDE implementation does not quite fit what's required given the new changes to the control. cc'ing Kohei here too
Comment 4 Noel Power 2011-04-27 04:59:30 UTC
Created attachment 46116 [details]
a possible fix

the patch above fixes the problem, it calls resize in various places to force ImplFormat to be called as it seems that the problems relate to the tab rectangles not getting updated as required. I'm pretty sure there is a better way to force that to happen. Kohei, any idea ?
Comment 5 Kohei Yoshida 2011-04-27 08:58:07 UTC
No ideas.  My change was already in effect in 3.3, and in 3.3 it seems to work fine.

Something may have changed in vcl with regard to refreshing of controls.  I've seen other oddities with painting in general.
Comment 6 Noel Power 2011-04-28 02:38:58 UTC
(In reply to comment #5)
> No ideas.
:-(
>  My change was already in effect in 3.3, and in 3.3 it seems to work
> fine.
ah ok ( I just assumed this was a more recent change ), at least now something to chase, I will hopefully be able to see why it works there and possibly work out why it fails now
> 
> Something may have changed in vcl with regard to refreshing of controls.  I've
> seen other oddities with painting in general.
hmm ok, good to know, I hoped this was a usage problem from the IDE implementation side ( since calc sheet tabs seem to work fine ) but... anyway you have at least given me a hint of where to look. I'll hold off the hacky fix for a little while anyway. Thanks again!!