Bug 40344 - [regression] graphics / objects in older documents positioned wrong
Summary: [regression] graphics / objects in older documents positioned wrong
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected)
Master old -3.6
Hardware: Other Linux (All)
: high major
Assignee: Cédric Bosdonnat
Keywords: regression
Depends on:
Reported: 2011-08-24 03:01 UTC by Cor Nouws
Modified: 2012-01-24 04:42 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

1 - bug document (234.75 KB, application/vnd.oasis.opendocument.text)
2011-08-24 03:07 UTC, Cor Nouws
2 - picture with screenshots of positioning in LibO343 (212.06 KB, image/png)
2011-08-24 03:08 UTC, Cor Nouws
3 - picture with screenshots of positioning in Lib35Master (233.80 KB, image/png)
2011-08-24 03:09 UTC, Cor Nouws
4 - simple test document from LibO343 (175.38 KB, application/vnd.oasis.opendocument.text)
2011-08-24 03:09 UTC, Cor Nouws
does this make sense, don't mistake this for "I know what I'm doing" (998 bytes, patch)
2011-08-25 06:01 UTC, Caolán McNamara

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2011-08-24 03:01:48 UTC
Build ID: 117281b-4eb4f62-260b7c1

Working with an older document [1], started 2007, with some grapics and objects in it.
These appear on the wrong place in 35Master [3] compared to LO343.

When I create a new document in LibO343 with some graphics [4], the problem is not there.

When opening another old document [5], with many graphics, it does show problems with placement. It takes many times PgUp, PgDown vice versa to get pictures in place.

When I open a guide from ODFAuthors, eg. http://www.odfauthors.org/openoffice.org/english/userguide3/writer3/V3_3_revisions/wg3.3-writer-guide-full-book-odt-10-jan-2011/view and scroll through it, there are some pictures not shown but I see hardly problems with positioning.
Notice that all graphics are inserted 'As character' in this guide.

I'll make some attachments:

1 - bug document
2 - picture with screenshots of positioning in LibO343 
3 - picture with screenshots of positioning in Lib35Master
4 - simple test document from LibO343
5) - I cannot attach this document
Comment 1 Cor Nouws 2011-08-24 03:07:51 UTC
Created attachment 50530 [details]
1 - bug document
Comment 2 Cor Nouws 2011-08-24 03:08:28 UTC
Created attachment 50531 [details]
2 - picture with screenshots of positioning in LibO343
Comment 3 Cor Nouws 2011-08-24 03:09:01 UTC
Created attachment 50532 [details]
3 - picture with screenshots of positioning in Lib35Master
Comment 4 Cor Nouws 2011-08-24 03:09:34 UTC
Created attachment 50533 [details]
4 - simple test document from LibO343
Comment 5 Cor Nouws 2011-08-24 06:22:26 UTC

   some text paragraphs
   empty paragraph
   graphic anchored here at paragraph
   empty paragraph
   some text paragraphs

When adding text in the first paragraph, so that new lines appear, it takes some time before the graphic is moved down.
Comment 6 Cor Nouws 2011-08-24 06:52:13 UTC
Another interesting behaviour

   a number of text, also some headings, and empty paragraphs
   some room at the bottom of the page
   paste a graphic that is too large for the remaining space

   > graphic and a whole lot of paragraphs are forced to the next page
Comment 7 Caolán McNamara 2011-08-24 07:30:07 UTC
do we have any idea, e.g. older master builds from the dailies, when this might
have come unstuck ?

The dream scenario is that we can state that build-id X from a few days ago works, while current build-id Y fails and its a trivial matter of bisecting the changes.

We may be too close to the start of available dailies for this to be possible for this bug though.
Comment 8 Cor Nouws 2011-08-24 09:34:47 UTC
That sounds as our ideal world :-)
maybe I am able to try some older build (local, nightly) in the weekend.

(but what the * is going on with the amil that I should recieve from this service :-( )
Comment 9 Cor Nouws 2011-08-24 09:36:27 UTC
Comment 10 Cor Nouws 2011-08-24 10:38:30 UTC
'oldest' masterbuidl I could find was from 2011-08-19
shows the same problems.

Any chance to dive up older deb_32 master builds somewhere?
Comment 11 Cor Nouws 2011-08-24 12:49:05 UTC
. (test)
Comment 12 Cor Nouws 2011-08-24 14:41:14 UTC
. (sorry, test again)
Comment 14 Caolán McNamara 2011-08-25 05:37:04 UTC
somewhere between acd3134..aea70b2
Comment 15 Caolán McNamara 2011-08-25 05:47:16 UTC
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f7bd90edcb68a67b63094eae6dae6f144edd5cc is the commit which breaks this.

A bit of a success story I reckon, help about gives the git ids, dailies provide a cache of pre-built install sets for bisecting the change.
Comment 16 Caolán McNamara 2011-08-25 06:01:25 UTC
Created attachment 50565 [details]
does this make sense, don't mistake this for "I know what I'm doing"
Comment 17 Caolán McNamara 2011-08-25 06:32:49 UTC
comment #16 is a stupid patch. Original commit's purpose is to try and not have drawing dropping on editing a footer when appending new paragraphs
Comment 18 Cor Nouws 2011-08-25 06:39:01 UTC
[ bugs.freedesktop does send me mail again and see your comments while traveling ...]
found a -maybe- related issue yesterday in LibO343. Can provide case this evening. So -maybe- it makes sense to look at that too .. just a few hours, pls ;-)
Comment 19 Caolán McNamara 2011-08-25 06:55:59 UTC
don't mangle this into a multi-bug catch-all
Comment 20 Cor Nouws 2011-08-25 07:25:18 UTC
[ next station ]
No fo course not ;-)

Tried to reproduce what happened again and again last evening (indeed with images close to/crossing the bottom of a page)
Cannot just reproduce it now ;-\
(Older documents ? Will have to pin it down immediately a next time)
so pls don't wait for another issue now, AFAIAC.
Sorry for the noise.
Comment 21 Caolán McNamara 2011-09-02 02:38:34 UTC
given: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca2568e30a5a9154dc17bdc2efed4e2cf3027885 can we close this now then ?
Comment 22 Cor Nouws 2011-10-31 04:39:10 UTC
could be related to 
Bug 33862 - FORMATTING - Some graphics are flipped vertically when opening prior OO documents ?
Comment 23 Cor Nouws 2012-01-24 04:42:49 UTC
Just checked in 350rc1 and it works fine there now
(also 3.4.5 is OK)