Bug 48112 - EDITING: Lightproof makes incorrect suggestion - unmatched quotation marks
Summary: EDITING: Lightproof makes incorrect suggestion - unmatched quotation marks
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.1 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Spell-Checking
  Show dependency tree / graph
 
Reported: 2012-03-31 00:10 UTC by Wyndham Clampett
Modified: 2023-10-02 03:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot illustrating the issue (107.09 KB, image/jpeg)
2012-03-31 00:10 UTC, Wyndham Clampett 		Details
test cases to illustrate problem (12.01 KB, application/vnd.oasis.opendocument.text)
2016-04-18 17:45 UTC, sdc.blanco 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wyndham Clampett 2012-03-31 00:10:48 UTC 
Created attachment 59300 [details]
Screenshot illustrating the issue

Lightproof says - in the Spell and Grammar dialog - "Extra space before the closing quotation mark?"

- on this paragraph:

Harry stared at Draco with tears rolling down his face, still not understanding. ” Why?” he asked.

What Lightproof has missed, is that the closing quotation mark it is referring to, should be an opening quotation mark - and that there is there is also a missing space before the first word in the quotation.

Perhaps, when it comes across this situation, it could check that the quotation marks match...
Comment 1 Joel Madero 2012-08-30 02:12:24 UTC 
@Laszlo - Is this a confirmed bug since you are assigned to it? If so can we
mark as NEW instead of UNCONFIRMED. Thanks
Comment 2 László Németh 2012-08-30 11:51:23 UTC 
@Joel. Thanks, I have set it. László
Comment 3 Kumāra 2013-09-23 08:49:56 UTC 
(In reply to comment #0)
> Harry stared at Draco with tears rolling down his face, still not
> understanding. ” Why?” he asked.

Interestingly, when I simply click Correct repeatedly, it gets into an endless loop. When I click close, Why? is gone!
Comment 4 QA Administrators 2015-04-01 14:40:50 UTC Comment hidden (obsolete)
Comment 5 tommy27 2016-04-16 07:27:01 UTC Comment hidden (obsolete)
Comment 6 sdc.blanco 2016-04-18 17:45:36 UTC 
Created attachment 124473 [details]
test cases to illustrate problem

I believe it is still a problem.  And I think that it has to do with which kind of "quote" is used.  The problem appears with U+201F , but not with U+201C 
File attached with examples.   (Tested/created with LO 5.1.2.2, Windows 7)
Comment 7 QA Administrators 2017-05-22 13:23:27 UTC Comment hidden (obsolete)
Comment 8 sdc.blanco 2017-05-24 19:45:12 UTC 
There are some improvements, but there are still some problems.

Tested with LO 5.3.3.2, Windows 7

Using the example given in the original description:

Harry stared at Draco with tears rolling down his face, still not understanding. ” Why?” he asked.

1.  Note that in the example there is a space between the first " and the word WHY.

If the first quote before WHY is the following character:

 U+201C  correctly asks if there is an extra space after opening quote.
 U+201F  (no error detected/reported)  (which is wrong)
 U+201D  gives the error in the original bug report  "Extra space before closing quotation mark?"  (which is wrong)

2.  If the extra space in the example is removed, and the first quote is:

U+201C  (no error detected) - correct
U+201F  (no error detected) - correct
U+201D   Reversed space and punctuation?  (which is wrong).

3.  If the closing quote (after "why") is:

U+201C  INCORRECTLY asks if there is an extra space after opening quote.
U+201F  (no error detected) - correct
U+201D  (no error detected) - correct

Probably it is a matter of convention which quotes are used -- so I will leave it others to decide if this is a bug or a feature.  But given that users can customize their choice of quotes, then perhaps this should be considered a bug?
Comment 9 Xisco Faulí 2017-07-13 09:56:53 UTC 
Setting Assignee back to default. Please assign it back to yourself if you're still working on this issue
Comment 10 QA Administrators 2018-07-14 02:45:42 UTC Comment hidden (obsolete)
Comment 11 sdc.blanco 2018-07-16 09:53:26 UTC 
Version: 5.4.7.2 (x64)
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU threads: 4; OS: Windows 6.19; UI render: default; 


A change for U+201D, but same basic problems remain.  

Note:  Probably, if U+201C is changed (to be like U+201D), then the only "problem" will be that when a single quote appears by itself, then no error message will be flagged -- and maybe that will be acceptable?


Here is a summary of the tests.

Test sentence:  Harry stared at Draco with tears rolling down his face, still not understanding. ” Why?” he asked.

1.  Note that in the example there is a space between the first " and the word WHY.

If the first quote before WHY is the following character:

 U+201C  correctly asks if there is an extra space after opening quote.
 U+201F  (no error detected/reported)  (which is wrong)
 U+201D  (change from original bug report) (no error detected/reported) (which is wrong)

2.  If the extra space in the example is removed  (i.e.,  "Why?"), and the first quote is:

U+201C  (no error detected) - correct
U+201F  (no error detected) - correct
U+201D  (no error detected) - correct   (improved from last report)

3.  If the closing quote (after "why") is:

U+201C  INCORRECTLY asks if there is an extra space after opening quote.
U+201F  (no error detected) - correct
U+201D  (no error detected) - correct
Comment 12 Thomas Lendo 2018-09-30 20:00:26 UTC 
Isn't this an extension problem instead of a Writer spell checker issue?
Comment 13 QA Administrators 2019-10-01 03:02:06 UTC Comment hidden (obsolete)
Comment 14 QA Administrators 2021-10-01 03:51:25 UTC Comment hidden (obsolete)
Comment 15 QA Administrators 2023-10-02 03:15:41 UTC 
Dear Wyndham Clampett,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug