You'll find the cppunit repository at http://cgit.freedesktop.org/libreoffice/cppunit
Compiling with -Weffc++ shows several warnings, some of them are only bad style but some also show serious bugs.
It would be good to make cppunit warning free. Currently compiling with -Wall -Wextra -Werror is already working and should be used as default.
One found serious bug by it is fixed with:
Both make and make check should be compiled with -Weffc++ and the warnings removed.
There are possibly also other nice gcc warnings that show some problems in the code.
I just configured and compiled cppunit with "-Wall -Wextra -Werror" and with "-Weffc++", and I didn't see any compiler warnings.
Here's what I did after I cloned cppunit:
./configure CFLAGS="-Wall -Wextra -Werror" # (or with -Weffc++)
What's the next step with this bug?
(In reply to comment #2)
> I just configured and compiled cppunit with "-Wall -Wextra -Werror" and with
> "-Weffc++", and I didn't see any compiler warnings.
> Here's what I did after I cloned cppunit:
> ./configure CFLAGS="-Wall -Wextra -Werror" # (or with -Weffc++)
> ./make check
> What's the next step with this bug?
The right configure line is:
./configure CXXFLAGS="-Wall -Wextra -Werror"
This bug is still valid?
I have built cppunit and I get only some doxygen warnings like this:
Generating docs for compound TestListener...
/home/radu/cppunitLibo/include/cppunit/TestListener.h:131: warning: argument 'test' of command @param is not found in the argument list of TestListener::endTestRun(Test *, TestResult *)
These warnings need also to be fixed?
Created attachment 77810 [details]
Patch for missing copy constructor/assignment operator.
Created attachment 84072 [details]
clean all cppunit compiler warnings
I have fixed all compiler warnings for cppunit with gcc 4.8.1
What do I do with this patch?
I have uploaded the patch to gerrit.
I hope that I have followed the instructions correctly.
I got the following message which I did not expect:
* [new branch] master -> refs/for/master
Anyways, the patch is available at
I'm on vacation but will commit it when I come back in the beginning of September. thanks a lot for this amazing work.
is there another task that you would be interested in?
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.
see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Marking this as fixed.
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp)
Remove LibreOffice Dev List from CC on EasyHacks
(curtailing excessive email to list)