Bug 51154 - cppunit warning cleaning
Summary: cppunit warning cleaning
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: Other All
: medium normal
Assignee: Not Assigned
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Reported: 2012-06-16 07:50 UTC by Markus Mohrhard
Modified: 2016-02-18 16:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Patch for missing copy constructor/assignment operator. (1.15 KB, patch)
2013-04-11 13:25 UTC, martin.kolleck
clean all cppunit compiler warnings (15.97 KB, patch)
2013-08-14 20:15 UTC, Tobias Lippert

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Mohrhard 2012-06-16 07:50:17 UTC
You'll find the cppunit repository at http://cgit.freedesktop.org/libreoffice/cppunit

Compiling with -Weffc++ shows several warnings, some of them are only bad style but some also show serious bugs.

It would be good to make cppunit warning free. Currently compiling with -Wall -Wextra -Werror is already working and should be used as default.
Comment 1 Markus Mohrhard 2012-06-16 07:53:54 UTC
One found serious bug by it is fixed with:


Both make and make check should be compiled with -Weffc++ and the warnings removed.

There are possibly also other nice gcc warnings that show some problems in the code.
Comment 2 Robinson Tryon (qubit) 2012-07-22 03:22:15 UTC
I just configured and compiled cppunit with "-Wall -Wextra -Werror" and with "-Weffc++", and I didn't see any compiler warnings.

Here's what I did after I cloned cppunit:

./configure CFLAGS="-Wall -Wextra -Werror"  # (or with -Weffc++)
./make check

What's the next step with this bug?
Comment 3 Markus Mohrhard 2012-07-22 17:26:02 UTC
(In reply to comment #2)
> I just configured and compiled cppunit with "-Wall -Wextra -Werror" and with
> "-Weffc++", and I didn't see any compiler warnings.
> Here's what I did after I cloned cppunit:
> ./autogen.sh
> ./configure CFLAGS="-Wall -Wextra -Werror"  # (or with -Weffc++)
> ./make
> ./make check
> What's the next step with this bug?

The right configure line is:

./configure CXXFLAGS="-Wall -Wextra -Werror"
Comment 4 Radu 2012-12-23 18:59:23 UTC
This bug is still valid?
I have built cppunit and I get only some doxygen warnings like this:

Generating docs for compound TestListener...
/home/radu/cppunitLibo/include/cppunit/TestListener.h:131: warning: argument 'test' of command @param is not found in the argument list of TestListener::endTestRun(Test *, TestResult *)

These warnings need also to be fixed?
Comment 5 martin.kolleck 2013-04-11 13:25:31 UTC
Created attachment 77810 [details]
Patch for missing copy constructor/assignment operator.
Comment 6 Tobias Lippert 2013-08-14 20:15:49 UTC
Created attachment 84072 [details]
clean all cppunit compiler warnings

I have fixed all compiler warnings for cppunit with gcc 4.8.1
What do I do with this patch?
Comment 7 Tobias Lippert 2013-08-14 21:00:03 UTC
I have uploaded the patch to gerrit.
I hope that I have followed the instructions correctly.
I got the following message which I did not expect:
 * [new branch]      master -> refs/for/master

Anyways, the patch is available at
Comment 8 Markus Mohrhard 2013-08-15 05:37:21 UTC
I'm on vacation but will commit it when I come back in the beginning of September. thanks a lot for this amazing work.

is there another task that you would be interested in?
Comment 9 Björn Michaelsen 2013-10-04 18:48:02 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 10 Markus Mohrhard 2013-10-05 00:55:12 UTC
Marking this as fixed.

Thanks everybody.
Comment 11 Robinson Tryon (qubit) 2015-12-15 12:15:56 UTC
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp)
Comment 12 Robinson Tryon (qubit) 2016-02-18 16:37:29 UTC
Remove LibreOffice Dev List from CC on EasyHacks
(curtailing excessive email to list)