Bug 53439 - shadow background overlaps pages at small zoom
Summary: shadow background overlaps pages at small zoom
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.0.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: BSA target:3.7.0 target:3.6.1
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-08-13 13:13 UTC by Ivan Timofeev (retired)
Modified: 2012-08-13 15:32 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
comparison - before and after (23.78 KB, image/png)
2012-08-13 13:16 UTC, Ivan Timofeev (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Timofeev (retired) 2012-08-13 13:13:04 UTC
Problem description: 
Commit cf7bd4852 (which is now in 3-6) introduced a regression

Steps to reproduce:
1. Open new writer document.
2. Create at least 2 pages.
3. Zoom out to 20%.

Current behavior:
grey rectangles get painted over the pages

Expected behavior:
shadows between pages looks normal

Please see also the screenshots before and after the mentioned commit.
Comment 1 Ivan Timofeev (retired) 2012-08-13 13:16:12 UTC
Created attachment 65495 [details]
comparison - before and after
Comment 2 Miklos Vajna 2012-08-13 13:28:14 UTC
Thanks, confirmed, I'll have a look.
Comment 3 Not Assigned 2012-08-13 14:06:57 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c5b9c197d70a0fb7d75bcedf2d70e6320175e846

fdo#53439 SwPageFrm::PaintBorderAndShadow fix painting at small zoom
Comment 4 Miklos Vajna 2012-08-13 14:08:36 UTC
Ivan,

Please double-check that it fixes the problem. If it does, it would be great if you could cherry-pick that fix to -3-6 as well.

Thanks!
Comment 5 Not Assigned 2012-08-13 15:19:12 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-3-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=93e819418070deb2750a918a1c3ea52376558d21&g=libreoffice-3-6

fdo#53439 SwPageFrm::PaintBorderAndShadow fix painting at small zoom


It will be available in LibreOffice 3.6.1.
Comment 6 Ivan Timofeev (retired) 2012-08-13 15:32:59 UTC
Yep, it works! I have pushed it to 3-6, thanks! :) However there is also problem with the page preview mode (which seems to paint shadows twice (wtf?) ) but it was already quite buggy, so... Hmm, dunno.