Bug 53997 - FILESAVE, MS-COMPAT: stop using table:number-columns-repeated
Summary: FILESAVE, MS-COMPAT: stop using table:number-columns-repeated
Status: CLOSED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 53998 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-24 08:52 UTC by Nicholas Shanks
Modified: 2013-03-15 10:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Shanks 2012-08-24 08:52:24 UTC
Microsoft Excel does not understand the number-columns-repeated attribute.


For exmaple:
<table:covered-table-cell table:number-columns-repeated="3"/>
will only produce one covered cell. Instead, Excel 2010 emits and understands:
<table:covered-table-cell/><table:covered-table-cell/><table:covered-table-cell/>

This applies to other elements too:
<table:table-column table:style-name="co1" table:default-cell-style-name="ce1" table:number-columns-repeated="3"/>
is not understood, and requires changing to:
<table:table-column table:style-name="co1" table:default-cell-style-name="ce1"/><table:table-column table:style-name="co1" table:default-cell-style-name="ce1"/><table:table-column table:style-name="co1" table:default-cell-style-name="ce1"/>


I think Excel compatability should be a higher priority than file size.
Please change the FILESAVE code to emit repeated elements instead of using the number-columns-repeated attribute.
Comment 1 Nicholas Shanks 2012-08-24 09:05:24 UTC
Once bug #53998 is implemented, the number-columns-repeated attribute can be re-introduced on the 'pure' codepath.
Comment 2 Nicholas Shanks 2012-08-24 09:08:11 UTC
I meant to add in the original bug description that this also applies to the number-rows-repeated attribute too.
Comment 3 Markus Mohrhard 2012-08-29 21:31:33 UTC
Compatibility to Excel2010 is not important. Excel2010 is not even able to read the formulas so using ODF as exchange format with Excel is useless anyway. Please check if this is still an issue with Excel2013 but even then I think that we should not change this for a bug in another product. We are already having enough problems with the Microsoft formats should concentrate on ODf compatibility and how our odf output works with other odf consumers.
Comment 4 bfoman (inactive) 2013-03-14 14:03:41 UTC
(In reply to comment #3)
> I think that we should not change this for a bug in another product.

Could you mark this bug as WONTFIX then?
Comment 5 bfoman (inactive) 2013-03-14 14:05:47 UTC
CCing as seems you are not on the CC list to notice a request.
Comment 6 Nicholas Shanks 2013-03-15 06:31:38 UTC
Another reason to prefer
<table:covered-table-cell/><table:covered-table-cell/><table:covered-table-cell/>
over <table:covered-table-cell table:number-columns-repeated="3"/> is that it compresses better, resulting in smaller file sizes for zlib-compressed saves.
Comment 7 Nicholas Shanks 2013-03-15 06:46:19 UTC
(In reply to comment #3)
> Compatibility to Excel2010 is not important.

I am trying to encourage ODS usage in an office where Excel 2010 is ubiquitous. I cannot send raw LO-exported files to my colleagues without first decompressing them, editing the file so that it uses syntax that Excel supports, and the recompressing them.

Surely I am not alone in trying to use free software in a Microsoft-dominated environment, though I may well be alone in hand-editing the XML!
Is it not a goal of yours (plural) to gain adoption of your product in a commercial surrounding? I believe anything that can ease the migration between the market leader and your own product, especially when such actions are of so little cost in terms of time, and have no detrimental effects, should be done.
Comment 8 Eike Rathke 2013-03-15 10:30:31 UTC
*** Bug 53998 has been marked as a duplicate of this bug. ***
Comment 9 Eike Rathke 2013-03-15 10:33:55 UTC
We should not cater for other applications' bugs in our native file format.

Besides, Excel 2013 reads table:number-columns-repeated attribute fine.