Bug 58623 - EDITING: Keep ratio checkbox status not captured by undo
Summary: EDITING: Keep ratio checkbox status not captured by undo
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.0.beta2
Hardware: Other Windows (All)
: low minor
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2012-12-21 15:28 UTC by john.pratt
Modified: 2020-06-08 20:06 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Example file with a bitmap (32.95 KB, application/vnd.oasis.opendocument.presentation)
2012-12-21 15:28 UTC, john.pratt
Details
You enable 'Keep Ratio', close Impress without saving, open ODP again, open 'Postition & Size' - the status is enabled (1.95 MB, video/x-matroska)
2020-06-08 20:02 UTC, Mike
Details

Note You need to log in before you can comment on or make changes to this bug.
Description john.pratt 2012-12-21 15:28:59 UTC
Created attachment 71938 [details]
Example file with a bitmap

Problem description: when changing the status of the keep ratio checkbox for a bitmap this is not captured by the undo list, so it cannot be undone.  If the bitmap is then enlarged separately then 2 undo items appear.  The first one undoes the enlargement, but the second one appears to do nothing.

Steps to reproduce (part 1):
1. open attached file or create one from scratch
2. right click the bitmap -> position and size
3. uncheck 'keep ratio' and close the dialogue

Current behavior: the undo list is blank

Expected behavior: this change should be recorded in the undo list

Steps to reproduce (part 2):
A. carry out steps to reproduce part 1
B. right click the bitmap -> position and size
C. change the size and close the dialogue

Current behavior: two undo items are created; the newest undoes the size change; the oldest appears to do nothing

Expected behavior: the two undo items undo one thing each (the oldest should undo the 'keep ratio' change)
Operating System: Windows XP
Version: 4.0.0.0.beta2
Comment 1 Joel Madero 2013-01-09 17:48:20 UTC
Confirmed, notes below:
First, two of us noticed that when we open the file the checkbox is already unchecked, what we did was check the box "keep ratio", close dialog, then go to Edit - Undo (not grayed out) but we saw that the undo does nothing.


Version: Changing to 3.6.4.3 as it was verified on this version. 
@Reporter - Version refers to the oldest version we can verify the bug on

New (Confirmed)
Minor: Doesn't prevent high quality work at all
Lowest: Easy workaround (just go in and change back your changes)

We know that the undo functionality in LibO needs some work, once a developer starts tackling the multiple bugs reported against undo, this one should be handled.


Thanks for reporting!
Comment 2 A (Andy) 2015-02-08 13:29:25 UTC
Reproducible with LO 4.4.0.3, Win 8.1

If I uncheck Keep Ratio in the attached sample, then the UNDO button is enabled, but if I press it, then the Keep Ratio function is still not checked.
Comment 3 QA Administrators 2016-02-21 08:38:01 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2017-03-06 16:06:09 UTC Comment hidden (obsolete)
Comment 5 Thomas Lendo 2018-10-27 18:12:38 UTC
Still reproducible.

Version: 6.2.0.0.alpha1+
Build ID: 5d2ab49cbda1d7aea1019478abe0163e1f40a121
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.UTF-8); Calc: threaded
from today
Comment 6 QA Administrators 2019-10-28 03:30:16 UTC Comment hidden (obsolete)
Comment 7 Mike 2020-06-08 20:00:56 UTC
reproduced in

Version: 7.0.0.0.beta1 (x64)
Build ID: 94f789cbb33335b4a511c319542c7bdc31ff3b3c
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-US
Calc: threaded

Version: 6.4.2.2
Build ID: 1:6.4.2-0ubuntu3
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-US (de_DE.UTF-8); UI-Language: en-US
Calc: threaded

Impress adds the undo "Transform Image" to the Edit menu, but it ignores it if you use it. 

Additionally I noted a weird issue:
Undo keeps the last status of "Keep ratio" setting, even if you close the document without saving. 
Impress 'can't forget' the last status if you close document (without closing Impress) and then reopen the ODP again. 

1. Open file
2. "Position and Size"
>Status "Keep Ratio: OFF"
3. Enable it
4. Click OK
7. Close Impress) without savin
8. Open file again
9. "Position and Size"
> Status is now "Keep Ratio: ON"
10. Disable it
11. Click okay
14. Close document without saving
15. Open file again ...

Now "Keep Ratio" is off again. And so on ....

I attach a screencast
Comment 8 Mike 2020-06-08 20:02:29 UTC
Created attachment 161779 [details]
You enable 'Keep Ratio', close Impress without saving, open ODP again, open 'Postition & Size' - the status is enabled
Comment 9 Mike 2020-06-08 20:06:41 UTC
>Impress 'can't forget' the last status if you close document (without closing >Impress) and then reopen the ODP again. 
I can close Impress complete. I continued testing after I wrote this.