Bug 60472 - No overlay controls displayed in the slides sidebar
Summary: No overlay controls displayed in the slides sidebar
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: high minor
Assignee: Not Assigned
URL:
Whiteboard: bibisected40
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-02-08 07:40 UTC by Bastián Díaz
Modified: 2013-12-12 22:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of controls (5.39 KB, image/png)
2013-02-22 16:57 UTC, Bastián Díaz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bastián Díaz 2013-02-08 07:40:53 UTC
I've noticed that in version 4.0 of LibreOffice, and not displayed overlay controls in the slides sidebar. To me this is a regression and I were very helpful, especially in view of sorter slides, as I constantly avoided using the context menu (I think there are redundancies in the context menu, as slide layout o slide transition).
Comment 1 Joel Madero 2013-02-21 20:56:30 UTC
Can you just give a quick picture showing what overlay controls are? Will help us triage and track down the issue
Comment 2 Bastián Díaz 2013-02-22 16:56:36 UTC
(In reply to comment #1)
> Can you just give a quick picture showing what overlay controls are? Will
> help us triage and track down the issue

I was referring to the controls that appear on the thumbnails on the slide side panel (start slide show, hide slide and duplicate slide).
However, other reports errors reading debate on the subject, I realized that remove was presented as an error function. If you remove an improvement has been ask to close this bug.

* I saw that changes were made in the context menu for the slide side panel but "start the slide show" option is needed (starts the presentation from that slide).

Thanks
Comment 3 Bastián Díaz 2013-02-22 16:57:57 UTC
Created attachment 75332 [details]
screenshot of controls
Comment 4 Joel Madero 2013-02-25 16:58:03 UTC
I see, yes I can confirm:

Version 4.1.0.0.alpha0+ (Build ID: b8e0455f201198b1deb8f8ca0181e6c9cadc335
Date:   Sat Feb 23 16:04:37 2013 -0600
Bodhi Linux 2.2

I'm going to assume this isn't Linux only, updating that information, also very unlikely that it's x86 only updating that as well
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Marking as:
New (confirmed)
Minor (doesn't prevent high quality work but slows it down)
High (regression so put it to high)
Comment 5 Joel Madero 2013-02-25 17:09:48 UTC
Bibisect -

 8004efc7f77e76e1dc66eeb0fa7f2b9b2cf9cc05 is the first bad commit
commit 8004efc7f77e76e1dc66eeb0fa7f2b9b2cf9cc05
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Mon Dec 10 15:00:52 2012 +0000

    source-hash-9351d0e4181924c3f72be24081fc7af027aa41f7
    
    commit 9351d0e4181924c3f72be24081fc7af027aa41f7
    Author:     Xisco Fauli <anistenis@gmail.com>
    AuthorDate: Mon Sep 24 22:15:09 2012 +0200
    Commit:     Xisco Fauli <anistenis@gmail.com>
    CommitDate: Mon Sep 24 22:32:33 2012 +0200
    
        pywizards: get rid of import * (3)
    
        Change-Id: Ibf7c6fc7863b6eccb28e5396587f2ec00ffcbe43

:100644 100644 a20479cbaa3727d1fffd44cec83df218caf9dbf1 0863ab0e8be4a2ddafd9dddc93ab1fece1d3531d M	autogen.log
:100644 100644 8e62d282e044f8e50129bb22cdbced4b96ebd1ca b2f4fccbfb31eeecda38bcf1e8530f4bcfe6404d M	ccache.log
:100644 100644 9ba22c3c21c7391056a1da76ecacf80f29ab767e 644c844c8c7f37845bcd509b30274fb3171f1b19 M	commitmsg
:100644 100644 aab3b069871ff5609a47327ae064d422aee26bb8 079818d37a3d997fb0b0444f800def75421c0006 M	dev-install.log
:100644 100644 2555d139468d77b5f654500831df091744b86a6e 94f774aa4e04a6a7af6ef5a36b8bfdbd2a14b563 M	make.log
:040000 040000 46fa8a5acb8fc14c2eaa23b7adef44367c114fe6 9d835c4339fa31db59424d45d5ac26a83cbdc83b M	opt






# bad: [5b4b36d87517a6ea96ff8c84c46b12f462fc9a1a] source-hash-8450a99c744e9005f19173e4df35d65640bcf5c4
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [16b0b88cbd4ef0f51816e97277e40c5cf78f7bf9] source-hash-099198a4224778fe6e43f5dc13b5b9b1b4dc828c
git bisect good 16b0b88cbd4ef0f51816e97277e40c5cf78f7bf9
# good: [f28b8f9a6c47fa59bf98fffe937a2f2db7a2445a] source-hash-a581d31b227623e09d2970a91214fda398f98eda
git bisect good f28b8f9a6c47fa59bf98fffe937a2f2db7a2445a
# bad: [114fd3b76bcba890e6d702d00cef910f1493c262] source-hash-64ab96cd15e52da88781e720d6f031dbcd0ba902
git bisect bad 114fd3b76bcba890e6d702d00cef910f1493c262
# good: [6af64581913aa7ce3fcf0890fe671830d416a6ea] source-hash-06a8ca9339f02fccf6961c0de77c49673823b35f
git bisect good 6af64581913aa7ce3fcf0890fe671830d416a6ea
# bad: [7e20e241c1d8819d8d5edb7894baeddde33f9d3a] source-hash-2c270eeff422ef93100376ce0717a131d4f3cc2f
git bisect bad 7e20e241c1d8819d8d5edb7894baeddde33f9d3a
# bad: [18ab426f67674e3ca169118f1f7a3527613374a4] source-hash-4df639baacd871cb2793e75dd9721ad2ae715e20
git bisect bad 18ab426f67674e3ca169118f1f7a3527613374a4
# bad: [8004efc7f77e76e1dc66eeb0fa7f2b9b2cf9cc05] source-hash-9351d0e4181924c3f72be24081fc7af027aa41f7
git bisect bad 8004efc7f77e76e1dc66eeb0fa7f2b9b2cf9cc05
# good: [7441b1f8a21611cc64d2c1c9a455adafc1cf213c] source-hash-93effcb0a2eade8309c53b74d0ea22e8a2217661
git bisect good 7441b1f8a21611cc64d2c1c9a455adafc1cf213c
Comment 6 Stéphane Guillou (stragu) 2013-06-18 22:08:52 UTC
I can confirm this regression in 4.0.4 on Ubuntu. Amazing this is still the case in the third bugfix version of this branch!

Any progression on this, Joel?

Should this be included in the 4.0 most annoying bugs?
Comment 7 Bastián Díaz 2013-09-21 07:51:46 UTC
In version 4.1.1.2, this feature is absent.

There any plans to resolve this bug for 4.2?

Thanks
Comment 8 Joel Madero 2013-09-21 15:59:41 UTC
We don't make plans that way - if the bug isn't assigned it means no dev has taken the bug. We have several thousand reported bugs, feature requests and the like, this bug is a minor issue compared to a lot of the bugs currently being worked on.

Thanks being said, patches are more than welcome, you can dig into the code and try to resolve it if you'd like
Comment 9 Bastián Díaz 2013-09-21 16:15:05 UTC
(In reply to comment #8)
> We don't make plans that way - if the bug isn't assigned it means no dev has
> taken the bug. We have several thousand reported bugs, feature requests and
> the like, this bug is a minor issue compared to a lot of the bugs currently
> being worked on.
> 
> Thanks being said, patches are more than welcome, you can dig into the code
> and try to resolve it if you'd like

I think with a "this bug has not been assigned" was enough.

Leaving aside formality, I have seen that some developers work some code, but not assigned to not commit the bug (due to lack of time).

Finally I'm not a developer, so seeing the code would not do much.

Regards
Comment 10 Joel Madero 2013-09-21 18:55:29 UTC
Sure and I understand. Just I get 50 emails a day from people saying essentially exactly what you said, "is this being worked on", in general we don't want people asking this question as it just clogs the comments and results in many of us on QA and busy developers getting emails from FDO. 

So, I apologize if it came off a bit stern, just keep in mind that you're one of millions of users and there are only so many hours that we have to deal with these kinds of questions.

In general we want comments to further explain the problem, offer some additional information, or do something more than "can I get a status check"
Comment 11 Andras Timar 2013-12-12 19:26:28 UTC
Sorry, the feature was removed on purpose.

commit 504d3ed897915bff3b3794dc3f069cb4fb528719
Author: Jan Holesovsky <kendy@suse.cz>
Date:   Sun Sep 23 16:11:47 2012 -0400

    Impress: Kill the so much hated ButtonBar in slide sorter.
    
    Change-Id: I9eb570e04fc43f2be2ceecd14cb3a41535e49b9b
Comment 12 Stéphane Guillou (stragu) 2013-12-12 22:10:00 UTC
Hi Andras

Do you know where I can find the rationale/discussion that led to this decision? Do you know why that feature was so "hated"?