Bug 62242 - Better handle custom menu and toolbar after LO update
Summary: Better handle custom menu and toolbar after LO update
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.1.0.0.alpha0+ Master
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: User-Profile
  Show dependency treegraph
 
Reported: 2013-03-12 16:00 UTC by Petr Mladek
Modified: 2017-12-18 09:05 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Mladek 2013-03-12 16:00:03 UTC
The current configuration migration code lose some custom changes in the menu and tollbar entries.

It seems that the menu entries are filtered by a pretty old code added by
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=97e96b230c86d10cb31793d3737c7d1d97041dfb

IMHO, the problem is that the code does not know if the menu entries were added/removed/renamed by the user or by the new version. It has to guess and it seems to be using the following approach:

           a) it ignores renamed entries because they might be renamed by the new version;
               It helps to be compatible with help and tutorials; By other words, it
                always enforces the name from the new version;

            d) It ignore moved entries because the move could be caused by new version.
                It again helps to be compatible with help and tutorials. The only exception are
                menu entries added by the user, see below. By other words, it resets
                the order according to the new menu. It keeps the entries that are not longer
                in the new menu on the location where they were before.

           b) It tries to do not lose any user added entry. It keep all entries from the old user
               menu that are not in the new menu.
     
           c) It tries to do not loose any new menu entry from the new application. It keep all entries from 
               the new menu that are not in the old user menu.

See https://bugs.freedesktop.org/show_bug.cgi?id=57061#c79 for more details.
Comment 1 Joel Madero 2013-03-18 16:13:28 UTC
@Petr- just marking this as NEW as it's you reporting :-D If you want independent confirmation or input let us know
Comment 2 Thomas Lendo 2017-12-07 16:14:52 UTC
Is this issue still valid or can it be closed as it addresses the move from /3 to /4?
Comment 3 Buovjaga 2017-12-18 09:05:24 UTC
(In reply to Thomas Lendo from comment #2)
> Is this issue still valid or can it be closed as it addresses the move from
> /3 to /4?

If we look at one of the files in the change mentioned in the description, we see that after 2013 it has received only fixes to correctness, typos etc. and not any rework to address this report: https://cgit.freedesktop.org/libreoffice/core/log/desktop/source/migration/migration.cxx