Bug 63133 - write tools/tempfiles.hxx out
Summary: write tools/tempfiles.hxx out
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: Other All
: medium normal
Assignee: Mihály Palenik
Whiteboard: target:4.2.0
Keywords: difficultyInteresting, easyHack, skillCpp, topicCleanup
Depends on:
Reported: 2013-04-04 19:32 UTC by Andras Timar
Modified: 2015-12-16 00:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Andras Timar 2013-04-04 19:32:06 UTC
Background: tools is a library packed full of deprecated code, that has equivalents in sal/ (the system abstraction layer). Of course the sal/ versions are often less usable than the tools/ version, so some API improvements may be required on the way too.

tools/tempfiles.hxx defines the TempFile class, which is still used at some random places in the codebase. To find them all:

git grep "<tools/tempfile.hxx>"

The equivalent class from sal is osl::FileBase::createTempFile.
Comment 1 Andras Timar 2013-04-04 20:15:34 UTC
Having a second look at the code, I don't think it is a great idea to kill this. Not a big win at least.
Comment 2 Michael Stahl (allotropia) 2013-04-04 20:54:15 UTC
actually it should be very easy to kill tools TempFile because
it has a clone in unotools called utl::TempFile...

...which is not that much better of course but it's an easy win.

perhaps something better would make sense in the URE...
but currently the createTempFile there is incomplete
and difficult to use since it's apparently not even possible
to create an osl::File from the oslFileHandle it returns.
Comment 3 Commit Notification 2013-07-16 18:46:18 UTC
Palenik Mihaly committed a patch related to this issue.
It has been pushed to "master":


fdo#63133: Write tools/tempfile.hxx out

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Comment 4 Robinson Tryon (qubit) 2015-12-16 00:37:01 UTC
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyInteresting,SkillCpp,TopicCleanup )