Bug 65930 - UI: List Custom document properties collapses after first property (properties are placed on the same position)
Summary: UI: List Custom document properties collapses after first property (propertie...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.1.0.0.beta1
Hardware: Other All
: medium major
Assignee: Caolán McNamara
URL:
Whiteboard: target:4.2.0 target:4.1.0.2
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-06-19 12:29 UTC by Johan Vromans
Modified: 2013-06-22 15:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Dialog with 4.1 (30.93 KB, image/png)
2013-06-19 12:29 UTC, Johan Vromans
Details
Dialog with 4.0 (41.47 KB, image/png)
2013-06-19 12:30 UTC, Johan Vromans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Vromans 2013-06-19 12:29:35 UTC
Created attachment 81065 [details]
Dialog with 4.1

When setting document variables (Edit > Properties > Custom Properties) the variables collapse under the first entry. The screendumps show the dialog for a document with 4 variables, after hitting the [Add] button.
Comment 1 Johan Vromans 2013-06-19 12:30:01 UTC
Created attachment 81066 [details]
Dialog with 4.0
Comment 2 Cor Nouws 2013-06-19 13:32:21 UTC
and when having added some in a new document, closed the dialog, and open the File > Properties dialog again... only the first one is present

Set the component to LibreOffice: is the same in (e.g.) Calc

@johan: thanks for reporting!
Comment 3 Johan Vromans 2013-06-19 13:59:25 UTC
I once got a situation where the border of the fields revealed that the other fields were actually stacked under the single, visible field. I could not reproduce this to make a screenshot. 

That's why I used the word "collapsed".
Comment 4 Cor Nouws 2013-06-19 17:18:16 UTC
@johan: ah thanks for clarifying.

@caolán: one for you?
Comment 5 Caolán McNamara 2013-06-19 19:31:26 UTC
it must be, though how it ended up quite so cruddy is a mystery at the moment
Comment 6 Caolán McNamara 2013-06-19 20:21:40 UTC
Silly me. Fixed in master, pending review on gerrit for 4-1
Comment 7 Commit Notification 2013-06-19 20:27:18 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7694bb997a68f6f8ebc03817be7e31ceb872ceb4

Resolves: fdo#65930 line height needs to be calculated in ctor



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Cor Nouws 2013-06-19 21:06:24 UTC
(In reply to comment #5)
> ... though how it ended up quite so cruddy is a mystery at the moment

You mean that is exceptional ? Well let me confirm that too ;)
thanks for the quick patch!
Comment 9 Commit Notification 2013-06-20 06:18:17 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=722ce13234182692996c586607868a0cd4b039b5&h=libreoffice-4-1

Resolves: fdo#65930 line height needs to be calculated in ctor


It will be available in LibreOffice 4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 10 Johan Vromans 2013-06-21 06:23:43 UTC
It seems that there haven't been nightly buids for the last couple of days...
Comment 11 Johan Vromans 2013-06-22 15:25:28 UTC
Fix confirmed in build 2013-06-21. Thanks.