Problem description: With MacOS 10.7.5 (my version) and 10.8.5 (a user from a forum) and Safari 6.1 (in both cases), BSA doesn't work. The left green toolbar appears + top green banner but no select box. I enable development menu then debug console and noticed this: [Error] SyntaxError: Expected token ')' (bugzilla.js, line 18) [Error] TypeError: 'undefined' is not an object (evaluating '$.bugzilla.isLoggedIn') main (bug.js, line 519) (fonction anonyme) (bug.html, line 1401) c (jquery-1.10.1.min.js, line 4) fireWith (jquery-1.10.1.min.js, line 4) ready (jquery-1.10.1.min.js, line 4) q (jquery-1.10.1.min.js, line 4) Steps to reproduce: 1. Open Safari 6.1 in MacOs 2. Go to https://www.libreoffice.org/get-help/bug/ Current behavior: No Select box Expected behavior: Select box appears Operating System: Mac OS X Version: unspecified
Alex: would you have some time to give it a try?
Reproducible, tested using Mac OSX 10.9 with Safari Version 7.0 (9537.71)
@Julien: I don't think I've ever used the BSA so far, but I see that Joren has confirmed. Alex
Thank you Joren and Alex for your quick feedback! :-) Rob: one for you?
Raising to "high" "major" since it's not obvious for OS X users (a lot of them use safari) what is going on. Also since there's no info on BSA to try another browser this totally cripples the ability to report OS X bugs. Adjusting title since it's confirmed for Safari 6 and 7.
*** Bug 72570 has been marked as a duplicate of this bug. ***
Bug 72570 reports the same behavior using Google Chrome on Linux. Marking as platform 'All'
Update summary per current repro status
About bugzilla.js, line 18, we've got this: // This function calls the XMLRPC-function. // Returns the data or throws an error. call: function(method, parameters = null, async = false, returnFunction = null) { But default value arguments seems to be in ECMAScript 6 which isn't supported by Chrome and Safari for the moment. See: - http://ariya.ofilabs.com/2013/02/es6-and-default-argument.html - http://stackoverflow.com/questions/14657117/do-function-arguments-support-a-default-value-in-javascript
Regarding syntax of default params to javascript functions: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/default_parameters Looks like only Firefox supports default params like this: function(method, parameters = null, async = false, returnFunction = null) { ... } Everyone supports function(method, parameters, async, returnFunction) { params = params || null; // etc... ... } I'm working up a patch right now for this. Bigger Picture: Perhaps we should have a testing policy whenever we update the BSA? Really simple testing policy: 1) Test in FF 2) Test in Chromium or Chrome 3) Test in Safari 4) Test on at least 2 of Win, Mac, GNU/Linux
Michael: just in case if Rob is unavailable and/or busy, do you know who may help here?
(In reply to comment #10) > > I'm working up a patch right now for this. https://github.com/colonelqubit/www-bugassistant/commit/856d69a5ce496addd1753b1a3982e2b35bdd8453 commit 856d69a5ce496addd1753b1a3982e2b35bdd8453 Author: Robinson Tryon <qubit@runcibility.com> Date: Tue Dec 10 13:47:32 2013 -0500 fdo#7249 - Fix syntax for optional function params Only FireFox currently supports the PHP/Python/etc... syntax for referencing optional javascript function arguments: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/default_parameters https://bugs.freedesktop.org/show_bug.cgi?id=72497 Testing w/joren right now. > Bigger Picture: Perhaps we should have a testing policy whenever we update > the BSA? > > Really simple testing policy: > 1) Test in FF done > 2) Test in Chromium or Chrome done > 3) Test in Safari done > 4) Test on at least 2 of Win, Mac, GNU/Linux done :-)
(In reply to comment #12) > (In reply to comment #10) > > > > I'm working up a patch right now for this. > > https://github.com/colonelqubit/www-bugassistant/commit/ > 856d69a5ce496addd1753b1a3982e2b35bdd8453 Sorry Ron about my previous comment! I hadn't matched in my mind your name and your pseudo! (stupid me! :-))
(In reply to comment #11) > Michael: just in case if Rob is unavailable and/or busy, do you know who may > help here? Patch written. Tested w/Joren. Site updated. Email sent: http://lists.freedesktop.org/archives/libreoffice-qa/2013-December/006149.html :-)
Resolved and fixed.
Verified using Mac OSX 10.9 with Safari 7.0. Thanks Qubit :)!
Ok for me too, thank you ! :-)
Verified then
And finally closed.
Awesome. Thanks to all involved and the super-fast fix. Very happy to see this working :)