Bug Hunting Session
Bug 75923 - EDITING: Spelling and Grammar: English - "Always Correct" button is undocumented and nonfunctional
Summary: EDITING: Spelling and Grammar: English - "Always Correct" button is undocum...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Spell-Checking-Dialog Help-Changes-Features
  Show dependency treegraph
 
Reported: 2014-03-08 22:00 UTC by Peter CM
Modified: 2019-09-04 21:57 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter CM 2014-03-08 22:00:26 UTC
I'm running OpenOffice 4.2.0.4 on Windows 7 (using the US-International Keyboard). 

When I run a Spelling and Grammar check in Writer and come across a misspelled word, the module offers three correction buttons: "Correct", "Correct All", and "Always Correct". 

The "Always Correct" button doesn't appear to be documented anywhere and does not appear to actually do anything. 

(The "Correct All" button only corrects a single instance of a misspelled word, a bug I have submitted in a separate report.)

Related bug, to be filed separately:

* The error correction buttons in the actual Spelling and Grammar module are labeled "Correct", "Correct All", and "Always Correct". The help module and online documentation (still?) refer to them as "Change" and "Change All".
Comment 1 Julien Nabet 2014-05-04 06:53:02 UTC
Peter: please keep in mind that Apache OpenOffice and LibreOffice are 2 different softwares. Could you give a try to LibreOffice 4.2.3?
Comment 2 Urmas 2014-05-04 07:43:06 UTC
That button is functional, but gives no feedback. It could be improved if it was working as Change All after adding the Autocorrect entry.
Comment 3 MartinPC 2015-08-12 21:43:48 UTC
Actually, what the "Always Correct" button does is to add the selected correction pair to the AutoCorrect table. If AutoCorrect is turned off, or if you're not actively typing the misspelling, it doesn't get corrected. The "Always Correct" button should probably be relabeled to something like "Add to AutoCorrect" or if space is short, "+→AutoCorrect" or just "AutoCorrect". (Someone told me the button is more accurately labeled "AutoCorrect" in the German-language interface.)
Comment 4 Thomas Lendo 2019-08-30 23:24:47 UTC
Adding needsUXEval.
Is changing the button name something that Heiko or Andreas csn change? Only a fixed bug is a good bug.
Comment 5 Thomas Lendo 2019-08-30 23:33:07 UTC
I couldn't find any info about that on https://help.libreoffice.org/6.3/en-US/text/shared/01/06010000.html
Comment 6 Heiko Tietze 2019-08-31 16:26:01 UTC
Ping ux-advice
Comment 7 Roman Kuznetsov 2019-09-01 15:10:32 UTC
That button had name "AutoCorrect" in the OOo and in our Help we have (now!):

> AutoCorrect
Adds the current combination of the incorrect word and the replacement word to the AutoCorrect replacements table.

https://help.libreoffice.org/latest/en-US/text/shared/01/06010000.html

I think we should rename that button to "Add to AutoCorrect"
Comment 8 MartinPC 2019-09-01 17:04:34 UTC
(In reply to Roman Kuznetsov from comment #7)
> 
> I think we should rename that button to "Add to AutoCorrect"

That sounds like an *excellent* idea! In fact, I think a commenter higher up on this thread already proposed it! ;-)
Comment 9 Julien Nabet 2019-09-01 17:12:26 UTC
Heiko/Xisco: thought you might be interested in this one since it concerns UX.
Comment 10 Heiko Tietze 2019-09-02 06:07:26 UTC
Let's go with this solution. This is definitely an easyhack.
Comment 11 Mike Kaganski 2019-09-02 16:19:17 UTC
FTR: the change from AutoCorrect to Always Correct was in https://git.libreoffice.org/core/+/2c78a8cd8a299fc7ec44947f0f7cb0de7d28f391 "Better wording for Spellcheck buttons/context menu" in master toward 4.1.
Comment 12 Heiko Tietze 2019-09-03 14:19:09 UTC
Missed the point of Samuel's patch, it was just "Change" to "Correct" and "AutoCorrect" to "Always correct".
Comment 13 MartinPC 2019-09-04 01:57:33 UTC
"Add to AutoCorrect" is clearer and more accurate than "Always Correct." (Pressing that button doesn't "always correct" the misspelling when AutoCorrect is turned off or when you're spellchecking a document that's already been typed. It just adds the correction pair to the AutoCorrect table.) I've been using word processors since WordStar for DOS and it took me an *unreasonably* long time  to figure out what the "Always Correct" button was actually doing. If display space is a serious issue, "AutoCorrect" would be okay in a pinch, but "Add to AutoCorrect" is more explicit and won't leave anyone scratching their head.

I appreciate your work on this, Heiko, and I'm sure other users who haven't yet figured out what "Always Correct" actually does will appreciate it even more!

PS: I was actually the Peter CM who filed this bug, and I misspoke in my initial post when I said I was using OpenOffice. It was definitely LibreOffice, since I haven't used OpenOffice since 2008. I tried to correct my mistake, but I seem to recall LibreOffice's bug reporting moved from FreeDesktop.org to DocumentFoundation.org at around that time. I got locked out of my old account and couldn't create a new one using the same email address. By the time I figured out a workaround for creating a new account, I had forgotten the need to follow up on my OpenOffice misstatement. I apologize for any confusion and wasted time that might have caused.
Comment 14 MartinPC 2019-09-04 21:57:36 UTC Comment hidden (off-topic)