Bug 77236 - FILESAVE: DOCX: Shape color changed to white after roundtrip
Summary: FILESAVE: DOCX: Shape color changed to white after roundtrip
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
4.3.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Balázs Regényi
URL:
Whiteboard: target:7.1.0 target:7.0.3
Keywords: filter:docx
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
 
Reported: 2014-04-09 10:53 UTC by Jacobo Aragunde Pérez
Modified: 2020-09-29 14:36 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Test case (21.48 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2014-04-09 10:53 UTC, Jacobo Aragunde Pérez
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jacobo Aragunde Pérez 2014-04-09 10:53:23 UTC
Created attachment 97132 [details]
Test case

Steps to reproduce:

1. Open the attached file.
2. Save as a different docx file.
3. Reopen with LibreOffice or Word.
4. The arrow that used to be black is now white.

I think the cause of this bug is the following change in document.xml:

72,80c69,71
<                         <a:lnRef idx="0">
<                           <a:scrgbClr r="0" g="0" b="0" />
<                         </a:lnRef>
<                         <a:fillRef idx="0">
<                           <a:scrgbClr r="0" g="0" b="0" />
<                         </a:fillRef>
<                         <a:effectRef idx="0">
<                           <a:scrgbClr r="0" g="0" b="0" />
<                         </a:effectRef>
---
>                         <a:lnRef idx="0"></a:lnRef>
>                         <a:fillRef idx="0" />
>                         <a:effectRef idx="0"></a:effectRef>

As a curiosity, the attached document is derived from sw/qa/extras/ooxmlexport/data/dml-textshape.docx removing all the shapes excepting one arrow, and this problem doesn't happen in the original document.
Comment 1 Jorendc 2014-04-15 20:20:00 UTC
Reproducible, tested using Windows 8.1 with LibreOffice Version: 4.3.0.0.alpha0+
Build ID: d2555ebb240fea2780f152e5ea39d145aab508fe
TinderBox: Win-x86@39, Branch:master, Time: 2014-04-14_07:59:52

The 'white' arrow isn't selectable anymore (in LibreOffice). So not sure it really is a white arrow, or it is just something 'empty'.

Kind regards,
Joren
Comment 2 Jorendc 2015-05-15 18:50:03 UTC
Still reproducible, Linux Mint x64 LibreOffice Version: 5.0.0.0.alpha1+
Build ID: f3070563c3071e05e9c448e261fec1e397bffb48
Locale: nl-BE (nl_BE.UTF-8)
Comment 3 QA Administrators 2016-09-20 09:41:51 UTC Comment hidden (obsolete)
Comment 4 Jacobo Aragunde Pérez 2016-10-19 11:11:15 UTC
Still reproducible as originally reported.

Version: 5.1.6.1.0+
Build ID: 5.1.6.1-1.fc24
CPU Threads: 4; OS Version: Linux 4.7; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 5 QA Administrators 2017-12-08 08:07:54 UTC Comment hidden (obsolete)
Comment 6 Jacobo Aragunde Pérez 2017-12-11 12:14:38 UTC
Still reproducible.

Version: 5.3.7.2.0+
Build ID: 5.3.7.2-4.fc26
CPU Threads: 4; OS Version: Linux 4.13; UI Render: default; VCL: gtk3; Layout Engine: new; 
Locale: es-ES (en_US.UTF-8); Calc: group
Comment 7 Xisco Faulí 2018-03-07 14:55:42 UTC
Still reproducible in

Version: 6.1.0.0.alpha0+
Build ID: 16605d0cdc2c15ab4ae175531ba52824bf52bc70
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 8 QA Administrators 2019-03-08 03:41:02 UTC Comment hidden (obsolete)
Comment 9 Jacobo Aragunde Pérez 2019-03-13 07:26:09 UTC
Still reproducible.

Version: 6.3.0.0.alpha0+
Build ID: bb6f5dc046966b7295dc199ea07008098757f0ef
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 10 Commit Notification 2020-09-11 13:36:37 UTC
Regényi Balázs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83c30743eaf44d8eded4a73e3ac2585b5bdbaffc

tdf#77236 DOCX shape export: fix missing solidFill

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2020-09-29 12:32:12 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: cd85546a2fbdade42f80fd3b6bd650791db9f32d
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11
Locale: tr-TR (en_US.UTF-8); UI: en-US
Calc: threaded

@Balázs Regényi, thanks for fixing this issue!!
Comment 12 Commit Notification 2020-09-29 14:36:41 UTC
Regényi Balázs committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/ecb06c0c5af4563d2feae5a927ab23542f63001b

tdf#77236 DOCX shape export: fix missing solidFill

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.