Bug 77540 - [EDITING] Record changes wrong when deleting data
Summary: [EDITING] Record changes wrong when deleting data
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: Other All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2014-04-16 19:47 UTC by Olivier Hallot
Modified: 2015-12-15 11:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
How it looks LibO 4.0 vs 4.1 (and above) (98.95 KB, image/png)
2014-06-08 10:52 UTC, Yousuf Philips (jay) (retired) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2014-04-16 19:47:58 UTC 
With Edit -> Changes -> Record activated, Delete the content of any cell.

Hover the mouse on the just-emptied cell.

The callout says: "Cell <reference> changed from <content> to <content>"

where
<reference> is the cell reference just emptied
<content> is the content deleted.

IMHO the correct infromation should be:

Cell <reference> changed from <content> to nothing"
Comment 1 Yousuf Philips (jay) (retired) 2014-06-08 10:51:44 UTC 
Confirmed in Linux Mint in 4.1.6, 4.2.4 and 4.3 beta. Its fine in 4.0.6 and below and labelled as Cell <reference> changed from <content> to '<empty>'.
Comment 2 Yousuf Philips (jay) (retired) 2014-06-08 10:52:32 UTC 
Created attachment 100649 [details]
How it looks LibO 4.0 vs 4.1 (and above)
Comment 3 Joel Madero 2014-06-09 19:45:16 UTC 
 9ac72638fdc1adf45f17c71f66baf9b20b606891 is the first bad commit
commit 9ac72638fdc1adf45f17c71f66baf9b20b606891
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Wed Oct 16 18:24:29 2013 +0000

    source-hash-1ed4210d8e6cbf1b25cd1eb8666be6578cc45845
    
    commit 1ed4210d8e6cbf1b25cd1eb8666be6578cc45845
    Author:     Miklos Vajna <vmiklos@suse.cz>
    AuthorDate: Tue Mar 26 16:21:37 2013 +0100
    Commit:     Miklos Vajna <vmiklos@suse.cz>
    CommitDate: Tue Mar 26 16:21:37 2013 +0100
    
        logerrit: kill copy-paste
    
        Change-Id: I2478ef0f886867c2d2247febf1b29b90fd32e5e7

:100644 100644 130fdd19f07fd29fe21d8dd85f19551bf3bc8c3d f528bc211004dbb5d139655ba3b3478f452ec314 M	ccache.log
:100644 100644 5320e6782589448ead56cec8147ac5d5505e9840 f6b4482b7e6ca4efdd40eab4d8b2a349e4d7655e M	commitmsg
:100644 100644 6a051d6b4d934414f3b3604c3973fd6bdccbf5c7 4c9b538e67f0cf763ea40057dfddd3e2c6f0a4e6 M	dev-install.log
:100644 100644 9ff32a3153cd4652d88c70c49a0beaa87cee1f73 239377e2eff3627460afb41c690f7447c0c10e6b M	make.log
:040000 040000 19588e79d57a83a75b248a6e41e41565cf60baa4 21a5779a55faf7ac5fdddee684c97fcbbd116062 M	opt


# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# bad: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect bad e02439a3d6297a1f5334fa558ddec5ef4212c574
# good: [8f4aeaad2f65d656328a451154142bb82efa4327] source-hash-1885266f274575327cdeee9852945a3e91f32f15
git bisect good 8f4aeaad2f65d656328a451154142bb82efa4327
# good: [9995fae0d8a24ce31bcb5e9cd0459b69cfbf7a02] source-hash-8600bc24bbc9029e92bea6102bff2921bc10b33e
git bisect good 9995fae0d8a24ce31bcb5e9cd0459b69cfbf7a02
# bad: [8ad82bc1416a07501651e8d96fe268e47d3931d3] source-hash-13821254f88d2c5488fba9fe6393dcf4ae810db4
git bisect bad 8ad82bc1416a07501651e8d96fe268e47d3931d3
# good: [238338bc4111eb82429ea47384d4012bcd7cdc3e] source-hash-b6ba04639b9922f6717f79ac4be215e09691d7a9
git bisect good 238338bc4111eb82429ea47384d4012bcd7cdc3e
# bad: [f24a67989fadc0affdfed9edf28f2f59fd6c279f] source-hash-930fe0581794e2ae6aaa62c2c716ed655a0f2885
git bisect bad f24a67989fadc0affdfed9edf28f2f59fd6c279f
# good: [c1631ee90606d0a7928496fb9548bcd0dbe69dbf] source-hash-28fb57daa77438f5e63132d3417062a11a44461e
git bisect good c1631ee90606d0a7928496fb9548bcd0dbe69dbf
# good: [af0ca5c674c36b4b4043864ae66fbb3f4cb97f51] source-hash-79c0bd64be68161ea16f132a015f7143e09f3eaf
git bisect good af0ca5c674c36b4b4043864ae66fbb3f4cb97f51
# bad: [19c2ac3a993134a30098bd0fcd9389ecbf8e6c18] source-hash-c947d49b5e2cd96de137460311e54952d03414d2
git bisect bad 19c2ac3a993134a30098bd0fcd9389ecbf8e6c18
# bad: [9ac72638fdc1adf45f17c71f66baf9b20b606891] source-hash-1ed4210d8e6cbf1b25cd1eb8666be6578cc45845
git bisect bad 9ac72638fdc1adf45f17c71f66baf9b20b606891
# first bad commit: [9ac72638fdc1adf45f17c71f66baf9b20b606891] source-hash-1ed4210d8e6cbf1b25cd1eb8666be6578cc45845
Comment 4 Kohei Yoshida 2014-10-15 01:48:54 UTC 
Ok.  I didn't see this bug report, but I did fix this one as I discovered it myself awhile ago when working on a different problem.

Not sure if I backported it to 4.2 and 4.3 (I believe I did, but not 100% positive), but it's fixed at least on master.
Comment 5 Kohei Yoshida 2014-10-15 01:49:36 UTC 
And I even wrote a unit test for this.
Comment 6 Joel Madero 2014-10-15 01:57:28 UTC 
Thanks Kohei!
Comment 7 Robinson Tryon (qubit) 2015-12-15 11:03:43 UTC 
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]