Bug 78007 - Regression: icons from toolbar don't reflect current text state
Summary: Regression: icons from toolbar don't reflect current text state
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
4.3.0.0.alpha0+ Master
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-27 16:54 UTC by Douglas Mencken
Modified: 2015-06-08 14:27 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot from 4.3.0...master (248.09 KB, image/png)
2014-04-27 16:54 UTC, Douglas Mencken
Details
In 4.0.x, these icons were active (211.91 KB, image/png)
2014-04-27 16:55 UTC, Douglas Mencken
Details
non-native rendering gives the same results (61.41 KB, image/png)
2014-04-27 20:24 UTC, Douglas Mencken
Details
result of find via grep "italic" (226.60 KB, text/plain)
2014-05-13 15:32 UTC, Douglas Mencken
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Mencken 2014-04-27 16:54:40 UTC
Created attachment 98084 [details]
Screenshot from 4.3.0...master

Current master's toolbar buttons ("bold"-"italic"-"underline") don't change it's state according to current text.

As you can see from attachments, they are static now. And this is regression, because in 4.0.x they were "active" (see next attachment).
Comment 1 Douglas Mencken 2014-04-27 16:55:40 UTC
Created attachment 98085 [details]
In 4.0.x, these icons were active
Comment 2 Jorendc 2014-04-27 17:17:21 UTC
No repro, tested using Windows 8.1 with LibreOffice Version: 4.3.0.0.alpha1+
Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f
TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36

Lets mark it as Mac OSX only for now.
Comment 3 tommy27 2014-04-27 19:49:41 UTC
no repro under Win7x64 as well

Version: 4.3.0.0.alpha0+
Build ID: 870ce1188ef7bfb6e57eed2894a20b2ea30b2225
TinderBox: Win-x86@39, Branch:master, Time: 2014-04-22_00:13:36

@Douglas
please copy and paste here your master build infos from menu "Help"
Comment 4 Jorendc 2014-04-27 19:59:10 UTC
Not reproducible using Mac OSX 10.9 with LibreOffice Version: 4.3.0.0.alpha0+
Build ID: 619b4c40da9e85febbb08a3f7cf8aa8d10963fc1
TinderBox: MacOSX-x86@49-TDF, Branch:master, Time: 2014-04-18_00:07:53

And also not reproducible using Version: 4.3.0.0.alpha1+
Build ID: 60cd850d672bc1dcc3eb24adfffa7a6ab98a44bd
TinderBox: MacOSX-x86@49-TDF, Branch:master, Time: 2014-04-27_00:04:50

Kind regards,
Joren
Comment 5 Douglas Mencken 2014-04-27 20:23:41 UTC
>please copy and paste here your master build infos from menu "Help"
From menu "LibreOfficeDev", your mean?
Version: 4.3.0.0.alpha1+
Build ID: Built by Douglas Mencken for PowerPC

I can add that:
1) paragraph alignment icons in the same toolbar are "active", so their state is switched accordingly to current alignment;
2) font name and size pull-downs (in the same toolbar) reflect correct name and size under text cursor;
3) BIU (bold--italic--underline) buttons are static even when rendering them "non-natively": see screenshot.
Comment 6 Douglas Mencken 2014-04-27 20:24:28 UTC
Created attachment 98093 [details]
non-native rendering gives the same results
Comment 7 Douglas Mencken 2014-05-13 15:32:24 UTC
Created attachment 98984 [details]
result of find via grep "italic"

Still present with 0bd49edc1ffd3717a75952bb8512110a5503d74b

Where's in the source tree the code which deals with triggering tollbar buttons?
Comment 8 Jorendc 2014-05-13 17:33:28 UTC
(In reply to comment #7)
> Where's in the source tree the code which deals with triggering tollbar
> buttons?

I think you might get that answer faster by mailing the developer mailinglist (http://lists.freedesktop.org/mailman/listinfo/libreoffice) or ask in the IRC freenode #libreoffice-dev chat (see https://wiki.documentfoundation.org/IRC)

Kind regards,
Joren
Comment 9 Alex Thurgood 2014-10-07 12:42:22 UTC
Works for me on

Version: 4.3.2.2
Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d
Comment 10 Alex Thurgood 2014-10-07 12:44:49 UTC
Also works on my master build
Version: 4.4.0.0.alpha0+
Build ID: 9bcd96a36e323a1c70eeefa81f2c8ea595f59444
Comment 11 Alex Thurgood 2014-10-07 13:05:38 UTC
@Doug : is this still the case for you ?
Comment 12 QA Administrators 2015-05-06 14:14:21 UTC
Dear Bug Submitter,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INVALID
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.
 
Thank you for helping us make LibreOffice even better for everyone!


Warm Regards,
QA Team
Comment 13 QA Administrators 2015-06-08 14:27:02 UTC
Dear Bug Submitter,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INVALID due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

-- The LibreOffice QA Team 

This INVALID Message was generated on: 2015-05-06

Warm Regards,
QA Team