Bug 79281 - AppData files for Linux software centers do not validate
Summary: AppData files for Linux software centers do not validate
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.3.0.0.beta1
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-26 22:44 UTC by Alexander Wilms
Modified: 2023-02-16 11:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Wilms 2014-05-26 22:44:24 UTC
All of these files fail to validate:
http://cgit.freedesktop.org/libreoffice/core/tree/sysui/desktop/appstream-appdata

Validator:
http://people.freedesktop.org/~hughsient/appdata/

Error message:
Validation failed!

libreoffice-*.appdata.xml did not validate:

[project_license] is not present
[screenshot] url not found
Comment 1 Adolfo Jayme Barrientos 2014-05-27 07:15:59 UTC
Thanks for your report, Alexander.

Well, these files were provided by Richard Hughes (AppData developer) himself. I’m not very familiar with the AppData protocol, but I understand it’s still very much changing and AppData files in every project must keep up with the changes.

I’m CCing Richard to let him know of this :-)
Comment 2 Richard Hughes 2014-05-27 10:33:30 UTC
> project_license is not present

This is a new tag and although advised is not a hard requirement -- it's a nice to have -- see http://people.freedesktop.org/~hughsient/appdata/#project_license for details.

> url not found

http://www.libreoffice.org/assets/Uploads/EN-Project_images/800x600/Base/Screenshot-87.png is indeed missing -- did someone perhaps move them somewhere else?
Comment 3 QA Administrators 2015-06-08 14:41:21 UTC Comment hidden (obsolete)
Comment 4 Buovjaga 2015-08-02 09:29:18 UTC
Seem to be missing still.
Comment 5 QA Administrators 2016-09-20 10:20:37 UTC Comment hidden (obsolete)
Comment 6 Alexander Wilms 2018-08-28 01:55:25 UTC
Now there's only warnings left:

appstreamcli validate libreoffice-writer.appdata.xml
W - libreoffice-writer.appdata.xml:libreoffice-writer.desktop:3
    The component ID is not a reverse domain-name. Please update the ID and that of 
    the accompanying .desktop file to follow the latest version of the Desktop-Entry 
    and AppStream specifications and avoid future issues.

I - libreoffice-writer.appdata.xml:libreoffice-writer.desktop:47
    Found invalid tag: 'kudos'. This tag is a GNOME-specific extension to AppStream 
    and is not supported by all implementations.

I - libreoffice-writer.appdata.xml:libreoffice-writer.desktop:3
    The component ID [libreoffice-writer.desktop] contains a hyphen/minus. Using a 
    hyphen is strongly discouraged, to keep interoperability with other tools such as 
    D-Bus. Ideally, replace any hyphens with an underscore ('_')

Validation failed: warnings: 1, infos: 2

The appdata should conttain a <launchable type="desktop-id">libreoffice-writer.desktop</launchable> field and as mentioned above, the ID should be changed to org.libreoffice.LibreOffice.Writer or something similar.
Comment 7 QA Administrators 2019-09-02 09:27:38 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2021-09-02 03:53:07 UTC Comment hidden (obsolete)
Comment 9 Alexander Wilms 2023-02-16 11:07:47 UTC
The validator still shows a warning due to the metainfo files not using the reverse-DNS scheme as specified here: 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic

Version: 7.4.4.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

The validator output is the same for all libreoffice-*.appdata.xml files

alexander@PC:~> LC_ALL=C appstreamcli validate libreoffice-writer.appdata.xml 
W: libreoffice-writer.desktop:3: cid-desktopapp-is-not-rdns libreoffice-writer.desktop
I: libreoffice-writer.desktop:3: cid-contains-hyphen libreoffice-writer.desktop
I: libreoffice-writer.desktop:29: url-not-secure http://www.libreoffice.org/discover/writer/
I: libreoffice-writer.desktop:33: url-not-secure
     http://www.libreoffice.org/get-help/documentation/
I: libreoffice-writer.desktop:47: nonstandard-gnome-extension kudos
I: libreoffice-writer.desktop:~: desktop-app-launchable-omitted

? Validation failed: warnings: 1, infos: 5, pedantic: 1
alexander@PC:~> LC_ALL=C appstreamcli validate org.libreoffice.kde.metainfo.xml 
I: org.libreoffice.kde:16: url-not-secure http://www.libreoffice.org/discover/writer/
I: org.libreoffice.kde:20: url-not-secure http://www.libreoffice.org/get-help/documentation/

? Validation was successful: infos: 2, pedantic: 1