Bug 79976 - GALLERY: enlarged image not crisp
Summary: GALLERY: enlarged image not crisp
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
(earliest affected) release
Hardware: Other All
: low trivial
Assignee: Not Assigned
Keywords: implementationError
Depends on:
Blocks: Gallery
  Show dependency treegraph
Reported: 2014-06-13 11:37 UTC by Yousuf Philips (jay) (retired)
Modified: 2020-11-11 07:58 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

LibO 4.1 (top) vs LibO 4.3 beta 2 (bottom) (154.96 KB, image/png)
2014-06-13 11:37 UTC, Yousuf Philips (jay) (retired)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-06-13 11:37:07 UTC
Created attachment 100973 [details]
LibO 4.1 (top) vs LibO 4.3 beta 2 (bottom)

This is a regression starting in 4.2. Tested in 4.2.4, 4.2.6 and 4.3 beta 2.
Comment 1 Jorendc 2014-06-13 11:45:04 UTC
Related to bug 79010 ? 

I fail to reproduce using LibreOffice 4.3b2.

Kind regards,
Comment 2 Yousuf Philips (jay) (retired) 2014-06-13 11:56:48 UTC
Doubt it could be related as i'm not exporting anything, i'm just viewing it in the gallery list.
Comment 3 Tomaz Vajngerl 2014-06-13 12:22:30 UTC
I reproduce this easily with 4.3 and 4.2. Just double-click on an image in gallery.
Comment 4 Yousuf Philips (jay) (retired) 2014-06-13 20:26:55 UTC
In addition to the enlarged image not being crisp, the transparency of the image (bug 79975) isnt shown in the enlarged image.
Comment 5 Xisco Faulí 2014-08-12 14:21:43 UTC
 fa729323917d7e0d45129bc21c08d8e19faab69b is the first bad commit
commit fa729323917d7e0d45129bc21c08d8e19faab69b
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Thu Oct 17 12:37:25 2013 +0000

    commit 7275a051677b5646e56623b3addc783880ce8e9b
    Author:     Stephan Bergmann <sbergman@redhat.com>
    AuthorDate: Sat Jun 15 09:22:09 2013 +0200
    Commit:     Stephan Bergmann <sbergman@redhat.com>
    CommitDate: Sat Jun 15 09:22:09 2013 +0200
        loplugin warnings
        Change-Id: I23ce5efe4ba20e1da5ffd169a2f3140a73dd035f

:100644 100644 8c5e50bd1bf7d186e24a574b9462462f74986bd8 c9359d81b04711e56766c241e142f499205cfbbd M	autogen.log
:100644 100644 0cf6236b9d5dde5c57d4a12847bee37338c34630 d25bc0bcb253a826d3c3a5b3fa3dcd9c99e83717 M	ccache.log
:100644 100644 c9dc12cedacb3166e93d8a357364c623904f37ff 268be1db6baea1be136ec48c00bef4febd8889ba M	commitmsg
:100644 100644 d478f1a28e2f5762b631d2fffd30e63885d1fbfc 02487bebcef47c83284a8054fb5b432a589e4d55 M	dev-install.log
:100644 100644 bcdfd152efb2c54f1b5be1ff400afd2e3c85502d de8e8bdfa29581a2bd41b0a76f6483ac9446bc7c M	make.log
:040000 040000 572b4cd4d3105d37cfd78bc6d44a3e166b8daa9c 0ed952cbef76f304a48be162089c809cf0c34174 M	opt

# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574
# bad: [4850941efe43ae800be5c76e1102ab80ac2c085d] source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b
git bisect bad 4850941efe43ae800be5c76e1102ab80ac2c085d
# skip: [a043626b542eb8314218d7439534dce2fc325304] source-hash-9379a922c07df3cdb7d567cc88dfaaa39ead3681
git bisect skip a043626b542eb8314218d7439534dce2fc325304
# skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a
git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6
# skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a
git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [1d4980621741d3050a5fe61b247c157d769988f2] source-hash-89d01a7d8028ddb765e02c116d202a2435894217
git bisect bad 1d4980621741d3050a5fe61b247c157d769988f2
# bad: [ba096f438393091574da98fe7b8e6b05182a8971] source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8
git bisect bad ba096f438393091574da98fe7b8e6b05182a8971
# bad: [9daa289e178460daaafa4b3911031df5b8736218] source-hash-704292996a3731a61339b1a4a5c90c9403aa095f
git bisect bad 9daa289e178460daaafa4b3911031df5b8736218
# bad: [69bf614869471f46413fe1d2af5976b2e6d85084] source-hash-76dea8b2db906156e77f78738a68f932a15afd4b
git bisect bad 69bf614869471f46413fe1d2af5976b2e6d85084
# good: [91c3e68c86f5b7143ab0de18c70c46de8314d6e1] source-hash-4e41227dd6af52ec562d10efcb365defba6bd36e
git bisect good 91c3e68c86f5b7143ab0de18c70c46de8314d6e1
# good: [70cea68b2de84c293ea8adbe2de81f75c23d0beb] source-hash-4a143c44fe7ad266ab9ab7dca317b0099b1438d0
git bisect good 70cea68b2de84c293ea8adbe2de81f75c23d0beb
# bad: [fa729323917d7e0d45129bc21c08d8e19faab69b] source-hash-7275a051677b5646e56623b3addc783880ce8e9b
git bisect bad fa729323917d7e0d45129bc21c08d8e19faab69b
# first bad commit: [fa729323917d7e0d45129bc21c08d8e19faab69b] source-hash-7275a051677b5646e56623b3addc783880ce8e9b
Comment 6 Xisco Faulí 2014-08-12 14:26:00 UTC
Issue reproduced in AOO 4.0.1 as well, so I guess it was merged from there.
Comment 7 QA Administrators 2015-09-04 02:48:50 UTC Comment hidden (obsolete)
Comment 8 Xisco Faulí 2015-09-04 09:16:24 UTC
This issue is still present in

Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: es-ES (es_ES)

on Windows 7 (64-bit)
Comment 9 Robinson Tryon (qubit) 2015-12-13 11:09:42 UTC Comment hidden (obsolete)
Comment 10 Aron Budea 2016-09-01 23:33:06 UTC
This is not really a regression. In v4.2 PNG images were replaced with SVGs, and it's the SVG that looks blurry.

These two commits could be starting points:
"Resolves: #i121656# Replaced many gallery base graphics with SVG"

"add components to gallery importer needed for svg"

Commit date 2013-06-13 is very close to bibisect results.
Comment 11 Aron Budea 2016-09-01 23:38:20 UTC
Might as well add Armin and Caolán.
Also, adjusting importance to low/trivial, as it really doesn't affect professional work.
Comment 12 Yousuf Philips (jay) (retired) 2017-10-21 22:43:37 UTC
Still present in the sidebar by right-clicking an image and clicking the 'Preview' entry.

Build ID: 8ba60ca42d4d1873b8cd85c5d3b5ed2f0e19df60
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 13 QA Administrators 2019-06-22 02:50:00 UTC Comment hidden (obsolete)
Comment 14 Buovjaga 2020-11-11 07:58:00 UTC
(In reply to Yousuf Philips (jay) (retired) from comment #0)
> Created attachment 100973 [details]
> LibO 4.1 (top) vs LibO 4.3 beta 2 (bottom)
> This is a regression starting in 4.2. Tested in 4.2.4, 4.2.6 and 4.3 beta 2.

If I right-click and preview, the only thing I notice currently is that the shapes are rendered without anti-aliasing. However, they are not blurry like in Jay's screenshot. I will close this and I think the current state is fine, because they are only previews after all and look OK to me.

Arch Linux 64-bit
Build ID: c9b320c32aceab7e22d381b688e7b44030e01c2d
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 8 November 2020