Bug 81041 - UI: tick indicating that dictionary is available for spellchecking in Language textbox in Format Character dialog
Summary: UI: tick indicating that dictionary is available for spellchecking in Languag...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.3.0.2 rc
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-08 10:36 UTC by Cor Nouws
Modified: 2014-08-06 17:43 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshots (245.35 KB, image/png)
2014-07-16 13:11 UTC, Cor Nouws
Details
character dialog in 4.3 (51.45 KB, image/png)
2014-07-16 13:58 UTC, Yousuf Philips (jay) (retired)
Details
character dialog in 4.2 (53.89 KB, image/png)
2014-07-29 23:15 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2014-07-08 10:36:40 UTC
as per subject
Comment 1 Cor Nouws 2014-07-08 10:38:05 UTC
OK in 4.2.5 > regression

- TODO : find first version where this happens
Comment 2 Urmas 2014-07-09 05:25:14 UTC
Looks fine in master.
Comment 3 Joel Madero 2014-07-09 06:55:11 UTC
Sorry Cor but I have no experience with these dialogs. Can you tell me exactly which one you are referring to and I will bibisect it
Comment 4 Yousuf Philips (jay) (retired) 2014-07-16 04:22:36 UTC
looks fine to me in 4.3.1. I have english, spanish, and french dictionaries checked.
Comment 5 Joel Madero 2014-07-16 04:23:23 UTC
@Cor - closing as WFM. If you can still repro please set back to NEW and give us a bit more details about what you're doing to see the issue. Thanks!
Comment 6 Cor Nouws 2014-07-16 13:09:37 UTC
doesn't work for me in 4.3.0.2
Comment 7 Cor Nouws 2014-07-16 13:11:32 UTC
Created attachment 102922 [details]
screenshots

the screen shot at the bottom shows that the dictionaries are indicated in the list as it is expanded
not at the box that shows the selected language
Comment 8 Cor Nouws 2014-07-16 13:13:22 UTC
pls give me some time to respond

or if you can't wait: send me a direct mail without qa or [bug #####] in the summary

I've no possibility to keep track of all immediately. By far not..
Comment 9 Yousuf Philips (jay) (retired) 2014-07-16 13:58:37 UTC
Created attachment 102923 [details]
character dialog in 4.3

Confirmed in Linux Mint on 4.3.1. You can see that the wrong control is being used for western fonts. This is a regression as it was the correct control in 4.2.5.
Comment 10 Urmas 2014-07-25 14:19:40 UTC
-> Enhancement.
Comment 11 Yousuf Philips (jay) (retired) 2014-07-25 18:03:20 UTC
@Urmas: how can a regression be an enhancement?
Comment 12 Urmas 2014-07-27 23:56:39 UTC
You need a textbox with an icon instead of simple textbox? It's enhancement.
Comment 13 Yousuf Philips (jay) (retired) 2014-07-28 01:42:51 UTC
When it was a textbox in a previous version and now is simple textbox, its not an enhancement to return it to a textbox.
Comment 14 Urmas 2014-07-29 12:26:25 UTC
Textbox is used for entering language codes directly. May be you LEARN your product features before spamming Bugzilla?
Comment 15 Yousuf Philips (jay) (retired) 2014-07-29 23:15:48 UTC
Created attachment 103660 [details]
character dialog in 4.2

Here is the 4.2.7 screenshot and lets see who is the one who is spamming bugzilla. And if you read people's words, like when Cor Nouws states "OK in 4.2.5 > regression" or when i said "This is a regression as it was the correct control in 4.2.5.", you wouldnt be wasting my time.
Comment 16 Yousuf Philips (jay) (retired) 2014-08-06 11:03:45 UTC
Yes i noticed that i was wrong about this issue a few days back after reading the 4.3 release notes, as this change was intentional, so this is an enhancement.
Comment 17 Cor Nouws 2014-08-06 14:10:39 UTC
So I guess it's about this feature
 https://wiki.documentfoundation.org/ReleaseNotes/4.3#Adding_a_new_language_tag

I do not understand why this is not a regression. The fact that a change has been made to make something new possible, does not imply that it's logic that existing functionality is removed at the same time?
A well ..
Comment 18 Yousuf Philips (jay) (retired) 2014-08-06 17:12:15 UTC
Yep thats the feature, "the language list box is now a combo box". I doubt that it would be possible to add the tick sign to the editable textbox field, as you'd have to add logic that if a user changes the text that the tick should be removed, and the tick should only be applied if a new entry is selected which has a tick. If its is possible, quite an undertaking for very little benefit.

Already found problems with the logic in the textbox. With a language already set (e.g. 'English (USA)'), type in a new language (e.g. 'Spanish (Argentina)'), then press up or down and it wont go to the next or previous entry, it will still remember its old selection and start going up and down from that entry.
Comment 19 Cor Nouws 2014-08-06 17:43:47 UTC
(In reply to comment #18)

> Already found problems with the logic in the textbox. 

Already known as bug 81429 ;)