Bug 82052 - FILEOPEN: .PPT textbox imported in wrong position
Summary: FILEOPEN: .PPT textbox imported in wrong position
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2014-08-02 12:54 UTC by tommy27
Modified: 2015-12-15 11:03 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot MS PP Viewer vs LibO (493.75 KB, image/jpeg)
2014-08-02 12:54 UTC, tommy27
Details
minimal test case (899.50 KB, application/vnd.ms-powerpoint)
2014-08-02 13:05 UTC, tommy27
Details
PPT open in MSO 2010. (478.83 KB, image/png)
2015-03-10 11:06 UTC, Yogesh Bharate
Details
PPT open in LibreOffice (452.33 KB, image/png)
2015-03-10 11:07 UTC, Yogesh Bharate
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tommy27 2014-08-02 12:54:38 UTC
Created attachment 103863 [details]
screenshot MS PP Viewer vs LibO

download attachment 103860 [details] and compare textboxes positions in MS PowerPoint Viewer and LibO. specifically take a look at slides 9, 10, 16, 17, 19 etc. etc.

as you may see in the screenshot, the textboxes are shown in lower position in LibO and the text is partially hidden below the diagrams.

issue reproduced under Win7x64 using LibO 4.1.0.4, 4.2.5.2, 4.3.0.4 and 4.4.0.0.alpha0+ Build ID: 9f803ee4b64e11e481ae9bf92ffac7cbf568675a
TinderBox: Win-x86@42, Branch:master, Time: 2014-07-28_06:27:11

textbox position looks fine in LibO 3.6.7.2

interestingly AOO 4.1 has the same problem as newer LibO versions.

this makes me suppose that the regression of LibO 4.1.x
is due to some code acquired by AOO.
Comment 1 tommy27 2014-08-02 12:58:08 UTC
just to add that bug is not present in 4.0.4.2, so early 4.1.x regression
Comment 2 tommy27 2014-08-02 13:05:16 UTC
Created attachment 103864 [details]
minimal test case

single slide .PPT showing the bug
Comment 3 ign_christian 2014-08-02 15:11:54 UTC
Confirm same as screenshot in: 4.2.7.0.0+ Time: 2014-07-30_13:16:10

It's ok with 4.0.6.2 under Ubuntu 12.04 x86

@Tommy, perhaps we can add BibisectRequest with this kind of bug?
Comment 4 tommy27 2014-08-02 15:25:07 UTC
yes, added bibisectRequest to whiteboard
Comment 5 Xisco Faulí 2014-08-04 12:23:57 UTC
bibisected:
 2a05be5f2465d8bf3a527ebbee1884df2b967f43 is the first bad commit
commit 2a05be5f2465d8bf3a527ebbee1884df2b967f43
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Wed Oct 16 20:33:09 2013 +0000

    source-hash-52770659d33f8f08a769043392cfb5a926019fef
    
    commit 52770659d33f8f08a769043392cfb5a926019fef
    Author:     Efe Gürkan YALAMAN <efeyalaman@gmail.com>
    AuthorDate: Sun Mar 31 17:27:57 2013 +0300
    Commit:     Thomas Arnhold <thomas@arnhold.org>
    CommitDate: Sun Mar 31 15:39:44 2013 +0000
    
        fdo#62096 Replace O(U)String compareTo with ==
    
        Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4
        Reviewed-on: https://gerrit.libreoffice.org/3136
        Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
        Tested-by: Thomas Arnhold <thomas@arnhold.org>

:100644 100644 a89b2bde62a9195357c72c8b044eb5980537936c 93a88cfedfa15dc1b3a1150dcbabbf7193598736 M	ccache.log
:100644 100644 112973bc018caa2c25bdd03d9eda92dc58d2438b 020ab520533e43b2ae6aa12e3940e9918cf58112 M	commitmsg
:100644 100644 d464c2cbc2721c7d223053fd9d6b81b3edf0b822 cdb5cb63e5d62ca1b93cdbf1d0d01bcf9219cbd4 M	dev-install.log
:100644 100644 5b84b188a4b5a3b7ca3db53e21c69d21d868d067 e306c84733623489aae556bc8f06764fef788eee M	make.log
:040000 040000 df82a74a524f96b74ee4d4dfd7f401784801b4c3 6375f713f48656b4b0f7c0be02847d7232d345ea M	opt

# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# bad: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect bad e02439a3d6297a1f5334fa558ddec5ef4212c574
# good: [8f4aeaad2f65d656328a451154142bb82efa4327] source-hash-1885266f274575327cdeee9852945a3e91f32f15
git bisect good 8f4aeaad2f65d656328a451154142bb82efa4327
# good: [9995fae0d8a24ce31bcb5e9cd0459b69cfbf7a02] source-hash-8600bc24bbc9029e92bea6102bff2921bc10b33e
git bisect good 9995fae0d8a24ce31bcb5e9cd0459b69cfbf7a02
# bad: [8ad82bc1416a07501651e8d96fe268e47d3931d3] source-hash-13821254f88d2c5488fba9fe6393dcf4ae810db4
git bisect bad 8ad82bc1416a07501651e8d96fe268e47d3931d3
# good: [238338bc4111eb82429ea47384d4012bcd7cdc3e] source-hash-b6ba04639b9922f6717f79ac4be215e09691d7a9
git bisect good 238338bc4111eb82429ea47384d4012bcd7cdc3e
# good: [f24a67989fadc0affdfed9edf28f2f59fd6c279f] source-hash-930fe0581794e2ae6aaa62c2c716ed655a0f2885
git bisect good f24a67989fadc0affdfed9edf28f2f59fd6c279f
# bad: [2a05be5f2465d8bf3a527ebbee1884df2b967f43] source-hash-52770659d33f8f08a769043392cfb5a926019fef
git bisect bad 2a05be5f2465d8bf3a527ebbee1884df2b967f43
# good: [ebb65cb393af31cb2876fe16279b72c1d1ac90c6] source-hash-23085e3bec84f8d07a594f8c1bbbbdbbe18d8121
git bisect good ebb65cb393af31cb2876fe16279b72c1d1ac90c6
# good: [53c33d1db1fb0d76badd5351c7b7b612b22fc16a] source-hash-ce9bf0f868304a95ace987f90dcf2466e70bfe51
git bisect good 53c33d1db1fb0d76badd5351c7b7b612b22fc16a
# first bad commit: [2a05be5f2465d8bf3a527ebbee1884df2b967f43] source-hash-52770659d33f8f08a769043392cfb5a926019fef
Comment 6 Matthew Francis 2015-01-01 22:42:09 UTC
The behaviour seems to have changed as of the below commit.

Adding Cc: to anistenis@gmail.com. Is there any chance you could have a look at this? Thanks

commit ec585b964e26de967f0373da0d2d9dfd20f8866c
Author:     Lei De Bin <leidb@apache.org>
AuthorDate: Fri Jul 20 00:57:59 2012 +0000
Commit:     Xisco Fauli <anistenis@gmail.com>
CommitDate: Sun Mar 31 16:22:34 2013 +0200

    #119581# fix import issue for left and right horizontal alignment in text box
    
    Reported by: liu ping tan
    Patch by: Li Jian Yuan
    Review by: Lei De Bin
Comment 7 Yogesh Bharate 2015-03-10 11:04:25 UTC
This issue is not seen on latest LibreOffice version 
MSO 2010 measures the position in inches where as LO measures it in centimeter. 
[ 1 inch = 2.54 cm ]
As Horizontal position of textbox is 0.5" i.e 1.27 cm. and vertical position of textbox is 0.5" i.e. 1.27 cm. which is right conversion of inch to centimeter.

I also locally revert the patch of Lei De Bin 
[Link : http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec585b964e26de967f0373da0d2d9dfd20f8866c ] which mention in comment, which does not affect any change in position of textbox.

Also attached the screenshots of ppt Open-in-LO and Open-in-MSO2010.
Comment 8 Yogesh Bharate 2015-03-10 11:06:15 UTC
Created attachment 114011 [details]
PPT open in MSO 2010.
Comment 9 Yogesh Bharate 2015-03-10 11:07:28 UTC
Created attachment 114012 [details]
PPT open in LibreOffice
Comment 10 Yogesh Bharate 2015-03-10 11:09:30 UTC
LibreOffice version is :

Version: 4.5.0.0.alpha0+
Build ID: 5a308b1239a09417507b0d05090ff2d3418d5133
Locale: en_IN
Comment 11 Yogesh Bharate 2015-03-10 11:11:18 UTC
LibreOffice version is :

Version: 4.5.0.0.alpha0+
Build ID: 5a308b1239a09417507b0d05090ff2d3418d5133
Locale: en_IN
Comment 12 Robinson Tryon (qubit) 2015-12-15 11:03:01 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]