vcl/osx/salinst.cxx has a chunk of code - particularly around the SalYieldMutex - that is duplicated in vcl/generic/app/geninst.cxx. It'd be great to use the generic code wherever possible there - either by inheriting (as the gtk2 backend does) and killing that duplication. I hope that that's reasonably easy - but of course, it needs compile testing on the Mac and a clean 'make check' run before and after that =) Thanks !
I want to take this assignment,do i need to install mac? I am using ubuntu.
"but of course, it needs compile testing on the Mac and a clean 'make check' run before and after that =)" So - I think that means yes. If you don't have a mac this is not a suitable task for you.
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup)
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
(In reply to Michael Meeks from comment #0) > vcl/osx/salinst.cxx has a chunk of code - particularly around the > SalYieldMutex - that is duplicated in vcl/generic/app/geninst.cxx. > > It'd be great to use the generic code wherever possible there - either by > inheriting (as the gtk2 backend does) and killing that duplication. > > I hope that that's reasonably easy - but of course, it needs compile testing > on the Mac and a clean 'make check' run before and after that =) > > Thanks ! I cannot find vcl/generic/app/geninst.cxx. Did you mean vcl/unx/generic/app/geninst.cxx ? https://opengrok.libreoffice.org/search?project=core&q=&defs=&refs=&path=vcl%2Fgeneric%2Fapp%2Fgeninst.cxx&hist=&type=
Hmm; it is possible that we made progress on this =) The files moved too. I would read (copy/paste it into a buffer) all of the SalYieldMutex implementations from each backend, and see if common code remains, and if so - factor it out into a shared class =) Thanks!
Re-evaluating the EasyHack in 2022 This issue is no longer relevant. Comparing these two files: vcl/unx/generic/app/geninst.cxx (moved from above address) vcl/osx/salinst.cxx shows that there is only a member function with similar name in each class in which has different implementation: getOSVersion(). For more information, please take a look at this commit: commit 3840aede596e6fc24f7ed7df9100fb028134aac6 Author: Jan-Marek Glogowski <glogow@fbihome.de> Date: Tue Aug 15 08:05:51 2017 +0200 Unify SolarMutex implementations