Bug 100052 - Insert rows / columns before / after for the Impress tables
Summary: Insert rows / columns before / after for the Impress tables
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:5.3.0
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2016-05-25 13:35 UTC by Jan Holesovsky
Modified: 2016-10-25 18:40 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Holesovsky 2016-05-25 13:35:28 UTC
In commit

https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=99b8598495ba76e8fd32af2ace17e0b29b3beffd

I've implemented .uno:InsertColumnsBefore, .uno:InsertColumnsAfter, .uno:InsertRowsBefore, .uno:InsertRowsAfter for Impress to act the similar way as in Writer.

I did not add them to any context menus or anything though - Jay, any chance to have a look how it should be presented or where?

Thank you!
Comment 1 Cor Nouws 2016-05-25 14:56:41 UTC
nice :)
Comment 2 Yousuf Philips (jay) (retired) 2016-05-27 08:14:41 UTC
Kendy: Similar to Writer, the table context menu should have an insert submenu with all 4 commands in it, as well as the 'insert rows...' and 'insert columns...' commands found in the row and column submenus.

http://opengrok.libreoffice.org/xref/core/sd/uiconfig/sdraw/popupmenu/table.xml

The 4 commands should also be added to the table toolbar and replace the existing .uno:InsertRows and .uno:InsertColumns commands.

http://opengrok.libreoffice.org/xref/core/sd/uiconfig/simpress/toolbar/tableobjectbar.xml
Comment 3 Jan Holesovsky 2016-05-27 08:16:34 UTC
Jay: Sounds great :-)  Please do you think you'll have some time to do the appropriate changes in the xml's?
Comment 4 Commit Notification 2016-07-05 12:36:38 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4c09bceca3dc86987fd4d5f701b66535d3f3fe21

tdf#100052 Add insert before/after for sd tables

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2016-07-05 12:44:58 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a20b4e242bd0eee468352a7135975a57298c7a2f

tdf#100052 Add insert before/after for draw tables also

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2016-07-05 12:53:21 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c0f1dc146b74bd3ad58f9c5b7cfa8c4a6606283

tdf#100052 Add insert before/after to sd table context menu

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2016-07-08 14:52:53 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ddd78b0706cb6ac67867f3ce3d23f6076d14df50

tdf#100052 sd: Add labels to insert before/after commands

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.