Bug 100240 - Windows version stopped being notified of updates
Summary: Windows version stopped being notified of updates
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
5.1.2.1 rc
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2016-06-06 19:00 UTC by Pedro
Modified: 2016-06-10 08:21 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Check for update LO5.1.2.2 reports up to date, stacktrace -- see thread 15 (14.94 KB, text/plain)
2016-06-06 20:12 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro 2016-06-06 19:00:30 UTC
See topic

http://nabble.documentfoundation.org/Check-for-update-td4181351.html

Tested under Windows 7 and 10 

This is a regression from version 5.1.1
Comment 1 V Stuart Foote 2016-06-06 20:12:37 UTC
Created attachment 125519 [details]
Check for update LO5.1.2.2 reports up to date, stacktrace -- see thread 15

Confirming.

On Windows 10 Pro 64-bit en-US with /a admin install of 
Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US)

Help -> Check for Updates dialog launches and returns

Status
LibreOffice 5.1 is up to date.

The check update PHP looks to have matching signature.
https://cgit.freedesktop.org/libreoffice/website/tree/check.php?h=update

So, for some reason this is not being parsed.

=-clipped from WinDbg 64-bit Stack Trace w/symbols attached-=
  15  Id: 149c.8c8 Suspend: 1 Teb: 00000021`ff85b000 Unfrozen
Child-SP          RetAddr           Call Site
00000021`90bbf538 00007ffe`ffaa3b4f ntdll!NtWaitForMultipleObjects+0x14
00000021`90bbf540 00007fff`021d2259 KERNELBASE!WaitForMultipleObjectsEx+0xef
00000021`90bbf840 00007fff`021d20db USER32!RealMsgWaitForMultipleObjectsEx+0x119
00000021`90bbf920 00007ffe`f24703ad USER32!MsgWaitForMultipleObjects+0x6b
00000021`90bbf970 00007ffe`dc4e4f5e sal3!osl_waitCondition(void * Condition = 0x00000000`00000620, struct TimeValue * pTimeout = 0x00000193`b46cd670)+0x5d [c:\cygwin64\home\buildslave\source\libo-core\sal\osl\w32\conditn.c @ 99]
00000021`90bbf9e0 00007ffe`dc4e6f98 updchklo!`anonymous namespace'::UpdateCheckThread::run(void)+0x19e [c:\cygwin64\home\buildslave\source\libo-core\extensions\source\update\check\updatecheck.cxx @ 528]
00000021`90bbfa70 00007ffe`f2472eb3 updchklo!threadFunc(void * param = 0x00000193`b4f2afe0)+0x18 [c:\cygwin64\home\buildslave\source\libo-core\include\osl\thread.hxx @ 186]
00000021`90bbfaa0 00007ffe`dfa54f7f sal3!oslWorkerWrapperFunction(void * pData = 0x00000193`a8bd5360)+0x23 [c:\cygwin64\home\buildslave\source\libo-core\sal\osl\w32\thread.c @ 59]
00000021`90bbfad0 00007ffe`dfa55126 MSVCR120!beginthreadex+0x107
00000021`90bbfb00 00007fff`02488102 MSVCR120!endthreadex+0x192
00000021`90bbfb30 00007fff`0298c5b4 KERNEL32!BaseThreadInitThunk+0x22
00000021`90bbfb60 00000000`00000000 ntdll!RtlUserThreadStart+0x34
Comment 2 Pedro 2016-06-06 20:23:12 UTC
Stuart, the Version box is for the Earliest affected and 5.1.2.1rc is affected.
Comment 3 V Stuart Foote 2016-06-06 20:44:48 UTC
Right you are. Sorry, I missed the first post of the ML thread and only saw 5.1.1.2 -> 5.1.2.2, rather than the Version: 5.1.2.1 (x64)
Build ID: 2603b69c5ec5981bb5f053f8ebfd1f3de00a4c29
Comment 4 Aron Budea 2016-06-07 12:52:55 UTC
The issue is that the update service doesn't believe LibreOffice is LibreOffice.

After meddling with Wireshark, this is what comes back as response:
<html>
<head><title>LibreOffice Update Service</title></head>
<body>
  <h1>LibreOffice Update Service</h1>
  <p><b>Error:</b> Only LibreOffice can access the update service.</p>
</body>
</html>

Happens both with 5.1.2.2 and the current 5.1.3.2, also with 5.1.4.1!
Comment 5 Aron Budea 2016-06-07 13:02:53 UTC
I believe the cultprit might be the handling of the User-Agent field in the request, which changed liked this recently:

LibreOffice 5.1.0.3 (5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737; Windows; x86; BundledLanguages=en-US af am ar as ast be bg bn bn-IN bo br brx bs ca ca-valencia cs cy da de dgo dz el en-GB en-ZA eo es et eu fa fi fr ga gd gl gu gug he hi hr hu id is it ja ka kk km kmr-Latn kn ko kok ks lb lo lt lv mai mk ml mn mni mr my nb ne nl nn nr nso oc om or pa-IN pl pt pt-BR ro ru rw sa-IN sat sd sr-Latn si sid sk sl sq sr ss st sv sw-TZ ta te tg th tn tr ts tt ug uk uz ve vi xh zh-CN zh-TW zu)

LibreOffice 5.1.2.2 (d3bf12ecb743fc0d20e0be0c58ca359301eb705f; Windows; x86; )
LibreOffice 5.1.3.2 (644e4637d1d8544fd9f56425bd6cec110e49301b; Windows; x86; )
Comment 6 Aron Budea 2016-06-09 22:37:59 UTC
Christian fixed this earlier today. I checked, update is correctly offered with versions 5.1.0.3 and 5.1.2.2. 5.1.3.2 is reported as up-to-date.
Comment 7 Pedro 2016-06-10 08:21:39 UTC
Verified fixed with version 5.1.2.1 under Windows 10.
Thank you Christian for fixing it and thank you Aron for investigating and updating bugzilla!