Bug 100533 - Scottish Gaelic dictionary's directory structure does not match what is generally used by dictionaries
Summary: Scottish Gaelic dictionary's directory structure does not match what is gener...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Extensions (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: All All
: low trivial
Assignee: Aron Budea
URL:
Whiteboard:
Keywords: notBibisectable, regression
Depends on:
Blocks:
 
Reported: 2016-06-21 23:41 UTC by Aron Budea
Modified: 2017-06-10 12:33 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2016-06-21 23:41:53 UTC
Each dictionary generally resides in the main directory of its extension (see French dictionary in 'share/extensions/dict-fr' for example), while in this case it's in an additional 'dictionaries' directory, so the dictionary files are in 'share/extensions/dict-gd/dictionaries'.
For consistency it would be nice if it had the same structure as other dictionaries.

Since Scottish Gaelic dictionary is maintained as a separate extension [1], the best would be to make this change in the extension, and then update the files, and 'Dictionary_gd.mk' in the LibreOffice dictionaries git repository, to make future updates in the repository more straightforward.

This is also a regression, as in LO 4.2.0.4 the directory structure of this dictionary was as expected, and was changed in 4.3.0.4.
Version of Scottish Gaelic dictionary extension in 4.2.0.4: 2.6
Version of Scottish Gaelic dictionary extension in 4.3.0.4: 2.8

[1] https://extensions.libreoffice.org/extension-center/an-dearbhair-beag-scottish-gaelic-spellchecker
Comment 1 Caolán McNamara 2016-07-07 20:24:38 UTC
That'll have to be reported to the extension author and not us, there's nothing we can do about it.
Comment 2 Aron Budea 2016-07-07 20:46:32 UTC
I'm following up on this, and would like to keep the report open until it's resolved.
Comment 3 Aron Budea 2016-07-28 07:04:10 UTC
Michael, as I read you are maintaining the Scottish-Gaelic dictionary.
In the next release, would you mind moving the files from the 'dictionaries' directory up a level, and update 'dictionaries.xcu' accordingly?
(whenever that next release is, it doesn't affect the behavior, but will make updating the dictionary in the LibreOffice repository easier)
Comment 4 Michael Bauer 2016-07-28 09:28:22 UTC
cc Kevin, as I'm not sure if this relates to the way we build the dictionaries or not.
Comment 5 Kevin Scannell 2016-07-28 12:57:19 UTC
I updated the scripts I use to package the gd extension (and many others):
https://github.com/kscanne/make-extensions/commit/a02ecbc197e5460d2d8b67cb1f0f50b1b7728861
Comment 6 Michael Bauer 2016-07-28 13:05:23 UTC
Thanks Kevin, so this issue should resolved the next time I update the dictionary.
Comment 7 Kevin Scannell 2016-07-28 13:11:14 UTC
Yes, it should, but I'd be happy to cast an eye over the oxt to be sure everything looks good before you upload it.   Might also be worth doing a bit of extra installation testing, etc.
Comment 8 Aron Budea 2016-07-28 19:38:02 UTC
Kevin, Michael, thank you!