Bug 100733 - FILEOPEN block arc is missing attributes in enhanced geometry
Summary: FILEOPEN block arc is missing attributes in enhanced geometry
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.0.beta2
Hardware: x86 (IA32) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0
Keywords: filter:pptx
Depends on:
Blocks:
 
Reported: 2016-07-01 17:45 UTC by Regina Henschel
Modified: 2017-01-13 18:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
"block arc" to test import from PowerPoint (39.50 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2016-07-01 17:45 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2016-07-01 17:45:06 UTC
Created attachment 126028 [details]
"block arc" to test import from PowerPoint

Open attached file. It has been created with PowerPoint 2010. It contains a "block arc". This shape has two polar handle. One for to set the start angle and one for setting end angle and inner radius. It works similar to the "Circular Arrow" of LibreOffice.

On import the block arc should be converted to a custom shape. That is done partly. You can see the handles, but they do not work.

When you look at the custom geometry, you see, that the attribute "draw:handle-polar" is missing. But that attribute is necessary for to interpret the handles correctly.

In addition the attribute svg:viewBox has wrong values for width and height. Currently both are zero. The viewBox is needed to get the correct interpretation of the coordinates in the path of the shape.

The "block arc" of LibreOffice has only one handle, therefore a mapping to a shape predefined in LibreOffice is not possible. But that is not needed at all, if you only set all attributes correctly.
Comment 1 Buovjaga 2016-07-16 17:14:27 UTC
Confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: 046244bcfe1c5c1cd2325fe74b933c05e43cf190
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on July 7th 2016
Comment 2 Commit Notification 2016-11-12 03:19:47 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4c742c4726e9dee47f6ae9fa3654bfb486b86e54

tdf#100733 oox: imports RefR and RefAngle of polar handles.

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2016-11-12 03:21:45 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a241009fea0375d82dda24e10f9a5736652e2753

tdf#100733 oox: update preset shape definition for polar handles.

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2016-11-12 03:21:52 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a39a2d28acb7f6034379a3c7ad47974f9c703fb6

tdf#100733 svx: use RefR and RefAngle for polar handles.

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2017-01-13 12:35:41 UTC
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Comment 6 Regina Henschel 2017-01-13 18:57:25 UTC
The handles work now, but the viewBox attribute still has zero values. But that seems to be an error not only with this special shape. So I will close this issue and write a new one for the wrong viewBox values.

I have used Version: 5.4.0.0.alpha0+
Build ID: 5adab0927483d039037b0f93894627e41a2c72f2
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-09_23:34:00
Locale: de-DE (de_DE); Calc: group