Created attachment 126147 [details] sample Steps: 1) Open attached document 2) Right-click on shape and click Area in context menu 3) Notice in the transparency tab that it is set to 'No transparency' 4) Open it in MS Word and it has a 50% transparency Version: 5.3.0.0.alpha0+ Build ID: 54f2a4184d1296814e64cfeab1d06ae90d002357 CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-07-08_01:43:14 Locale: en-US (en_US.UTF-8); Calc: group
Confirmed. 64-bit, KDE Plasma 5 Build ID: 5.1.4.2 Arch Linux build-1 CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; Locale: fi-FI (fi_FI.UTF-8)
This is somewhat of a regression, at least the transparency setting. v4.2.0.4: transparency is set to 50%, but Heiko's face is not shown, only the oval outline. Same if transparency is set to No transparency. v4.3.0.4: transparency is set to No transparency, Heiko's face is shown. If transparency is set to 50%, face is not shown, only the oval outline. v5.2.0.4: transparency is set to No transparency, Heiko's face is shown. If transparency is set to 50%, transparency is adjusted properly. I'd say, let's consider it a regression for the import of transparency setting (noting that there were other issues that were fixed later). After this is fixed, test export of transparency as well.
git bisect log # bad: [74b89c3193673ba9897dc4a4541500ef6e8d9bf7] source-hash-8f97326bdd3f42fc82aa5e1989fd03b0af1daf64 # good: [9c392cfdfe6e9a9bce98555ea989283a957aa3ad] source-hash-fc8f44e82de4ebdd50ac5fbb9207cd1a59a927e3 git bisect start 'latest' 'oldest' # bad: [e289d9d328719fd70e9a2680fd0e4f586a97b3be] source-hash-3c0a7cf4f67720f2cca2c4eb543f838d5b644e7f git bisect bad e289d9d328719fd70e9a2680fd0e4f586a97b3be # skip: [0327d0bc45d60df0d1c8ac2470cf252b6bb8f780] source-hash-38fed70782ae6ac6b0282897c7abc6fa33a6de9e git bisect skip 0327d0bc45d60df0d1c8ac2470cf252b6bb8f780 # skip: [49983d52ba71075b818df4414a7dbd275720ee2f] source-hash-9dea39c177e61385770311077cf082aa581671fd git bisect skip 49983d52ba71075b818df4414a7dbd275720ee2f # skip: [eeec746d9b9a090137faa72c3f93865364531e04] source-hash-d1c2f9849e82e6c5d2297fc43f787d5c3483fe6c git bisect skip eeec746d9b9a090137faa72c3f93865364531e04 # bad: [a79356d9267623d5610ca888cef3087a1056ce88] source-hash-44bfdc408eb65bc357adb8404c0451c89293dea7 git bisect bad a79356d9267623d5610ca888cef3087a1056ce88 # bad: [a7c6a0dca388ced598ab878168eca32f51c0434a] source-hash-88e9329265a60ff7c88772507cb099ade61cf1b9 git bisect bad a7c6a0dca388ced598ab878168eca32f51c0434a # bad: [171c193665fd0b0ca69a812f074812841943cbff] source-hash-bd225bc2b8e0c46a2aa0e7366211452439caa622 git bisect bad 171c193665fd0b0ca69a812f074812841943cbff # bad: [20ea35d89b657d36baba5b27ebe826ff8165a3c2] source-hash-0d9bd19c5b1740b41581faba9f78e7ea56143c83 git bisect bad 20ea35d89b657d36baba5b27ebe826ff8165a3c2 # skip: [bd1dbd78b167970d11b9fc2bd0113e5931dc4b56] source-hash-83a918016d317d5fb58bb778124310a97204574f git bisect skip bd1dbd78b167970d11b9fc2bd0113e5931dc4b56 # good: [85e502a9005c8c1a2dfc7dd6a66558d4b28016b0] source-hash-1366e61fcbdd63bb87a9709338ad66bd0fd525ab git bisect good 85e502a9005c8c1a2dfc7dd6a66558d4b28016b0 # good: [01b9a4ed1485749dfc1a8ecb9e074e8881101f61] source-hash-3b79cc5fad948f129b643189e78fd539b8882fe7 git bisect good 01b9a4ed1485749dfc1a8ecb9e074e8881101f61 # good: [c1f04ca22c3f1107cb9787b7576747485a535e6d] source-hash-4420650bb08794506bcc476994e628986d079991 git bisect good c1f04ca22c3f1107cb9787b7576747485a535e6d # good: [73b100e3cfa9a72b478fee48ce7bb5bf7489abc4] source-hash-1ef873db6e5d38fd24e71cbdb61556f9d39cac73 git bisect good 73b100e3cfa9a72b478fee48ce7bb5bf7489abc4 # bad: [6ea1683c17da2b0f24d700774f35154d21868e1b] source-hash-e7c10fba9083e8ec9498a1fee4ef3ce31eb3e8d1 git bisect bad 6ea1683c17da2b0f24d700774f35154d21868e1b # bad: [5400496a2eecda6b414695e2b5e9f93206523d4f] source-hash-d83328b233f51d4a70bfeaae90129a68dccf825b git bisect bad 5400496a2eecda6b414695e2b5e9f93206523d4f # bad: [c506f2e2ba98a68692da4aa726d93464926d36e6] source-hash-57450afb768c085df0ba2344aa94b5f843060178 git bisect bad c506f2e2ba98a68692da4aa726d93464926d36e6 # good: [5abb73c9be4802a7f699da2997df954805ed9148] source-hash-4c9ddd594e26c517b8515f77206bfeb2fb063e03 git bisect good 5abb73c9be4802a7f699da2997df954805ed9148 # good: [a705dc498e1835f17b6538e04b31d2acd213a462] source-hash-48dad589e319c3545d9764b101a9834d55a09e43 git bisect good a705dc498e1835f17b6538e04b31d2acd213a462 # good: [f04d909c4e69aa1fc5ad22377d7fd54455915fcf] source-hash-ddbeaada1c7abb0fee88e709f3d6d824f06b39e0 git bisect good f04d909c4e69aa1fc5ad22377d7fd54455915fcf # first bad commit: [c506f2e2ba98a68692da4aa726d93464926d36e6] source-hash-57450afb768c085df0ba2344aa94b5f843060178
Adding Miklos to the CC, based on the commit details below. Miklos, I understand this is not particularly useful, because the commit only enables wps. Anyway, please take a look and see if it's enough of a hint or not. c506f2e2ba98a68692da4aa726d93464926d36e6 is the first bad commit commit c506f2e2ba98a68692da4aa726d93464926d36e6 Author: Matthew Francis <mjay.francis@gmail.com> Date: Thu May 28 17:36:37 2015 +0800 source-hash-57450afb768c085df0ba2344aa94b5f843060178 commit 57450afb768c085df0ba2344aa94b5f843060178 Author: Miklos Vajna <vmiklos@collabora.co.uk> AuthorDate: Tue Dec 3 11:59:42 2013 +0100 Commit: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Tue Dec 3 15:39:04 2013 +0100 DOCX import: declare wps as a supported feature This means in case we hit an mc:AlternateContent element, we will read the mc:Choice branch of it, in case wps is the required feature, not the mc:Fallback one, which contains the information in VML format (after a lossy conversion). Change-Id: I476156bd1a39927dda903d14540155d1e62a211e
Created attachment 127327 [details] sample pptx file affected Transparency values are not imported for all bitmap filled DrawingML objects. This affects all OOXML formats. Miklos, Do you want to track the general issue here or just this specific regression?
Adding Cc: to Miklos Vajna
Luke, Let's please use this bug just for the regression. Needless to say the drawingML import fix will also affect all formats, it won't be for DOCX only.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ecfcee8b05e45ec82dec6ed417e9ac53d4d7b4ff tdf#100830 drawingML import: handle <a:alphaModFix> It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos, Thanks for fixing this regression. I'm happy to report that your fix works for all OOXML documents not just .docx. Unfortunately, there appears to be an error in your transparency conversion math. 70 -> 30 and 30 -> 70. It only gives the correct value for 50%. I think you can fix it by subtracting from one on the import. See Bug 102997.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=21122a831aee1d548c9c539b27f15588675ceee5&h=libreoffice-5-2 tdf#100830 drawingML import: handle <a:alphaModFix> It will be available in 5.2.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.