Amazingly on Windows adding a *((int *)42) = 42; into the OpenCL code paths to test crash recovery - results in the CL driver passing the test - but not on master/4.3. This is due to the SEH exception handling throwing an exception there, which is caught; we fall-back to traditional calculation - and "life is good" ;-) unfortunately this mis-tags a failing CL kernel as a passing one. Need a way to count such failures in the shared opencl/ module.
Of course, I tested various scenarios before pushing this - but mostly correctly compiled CL formulae that yielded the wrong results =) exercising the OpenCLZone was the issue I guess. Fixes pushed to gerrit.
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9a1afbd3e12c6935cbacbff84b1b70fea0add85 tdf#100883 - opencl impls. that use SEH are still bad. It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b1f1030bf642d1b9c8af91aa78683a9fb95e6f4&h=libreoffice-5-1 tdf#100883 - opencl impls. that use SEH are still bad. It will be available in 5.1.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ad26139b5e8a4df469399378baeac5083f2fcf5&h=libreoffice-5-2 tdf#100883 - opencl impls. that use SEH are still bad. It will be available in 5.2.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.