Bug 100929 - Windows Installer: The "ADDLOCAL=ALL" set not all features
Summary: Windows Installer: The "ADDLOCAL=ALL" set not all features
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Juergen Funk (CIB)
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-15 09:51 UTC by Juergen Funk (CIB)
Modified: 2016-09-27 06:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Funk (CIB) 2016-07-15 09:51:09 UTC
Here, LHM, we build a msi Package with languages (de, fr, it, es, pt) and the install is unattended and we want to install the whole packed with the switch ADDLOCAL=ALL and in this case all languages and Dictionaries should be installed, on the Germany-Windows 7.
But we get, the GUI-langaguge is only Germany all other advertised. 
The Dictonaries we get, English, French, Germany, Italian but Spain and Portuguese is advertised, too.

For normal installation is that okay, but not when set the ADDLOACAL switch with this switch you can set "all" or a set of features you want set, this works but not for the above descript languages or dictonaries.
Comment 1 Juergen Funk (CIB) 2016-07-15 10:11:09 UTC
I have found the problem, the CustomAction "SelectLanguage" is guilty. 

The patch has follow behavior:
------------------------------
When you start the msi without the ADDLOCAL-switch the behavior is similar  without my patch, the CustomAction is execute and switched off the Langauge, Dictionaries.

But when the ADDLOCAL ist set (with "ALL" or other Feature) then the CustomAction is skippt, and the ADDLOCAL can set all the features.

here: https://gerrit.libreoffice.org/27230
Comment 2 Commit Notification 2016-07-19 08:33:47 UTC
Juergen Funk committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a76a41ae7a2ebd53f80f01ea9e2bcff3026d155

tdf#100929 - Windows Installer: "ADDLOCAL=ALL" doesn't set all features

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Xisco Faulí 2016-09-26 10:23:43 UTC
Hello Juergen,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Changing status to NEW.
Comment 4 Juergen Funk (CIB) 2016-09-27 06:48:46 UTC
Fixed and tested