Bug 101076 - Drag-create makes unfilled shape
Summary: Drag-create makes unfilled shape
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.1 rc
Hardware: All All
: highest normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0 target:5.2.1
Keywords: regression
Depends on:
Blocks:
 
Reported: 2016-07-22 19:51 UTC by Regina Henschel
Modified: 2016-10-25 18:40 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2016-07-22 19:51:35 UTC
Start Impress with a new file.
From context menu select 'slide properties'. Goto Background tab, set list to 'color' and choose a color. I have used 'Chart 8'. OK. Confirm to use it for all slides.
Click on a shape icon and drag with the mouse to create the shape. Notice, the shape is not filled.

The step to set a color as background is essential. With background "none" the error does not happen.

From those versions, which I have got on my PC the last good is
Version: 5.2.0.0.alpha1+
Build ID: 51e953a3579fb91f30f7f0d6159b737684976959
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-04-30_03:08:13
Locale: de-DE (de_DE)

With version
Version: 5.2.0.0.alpha1+
Build ID: 7b704dfbdb23540ff6366fa60c73474bbda9dc26
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-05-20_05:45:40
Locale: de-DE (de_DE)
I get a crash, if I try to set a background color.

And these versions fail
Version: 5.3.0.0.alpha0+
Build ID: e10a4c1cc9f8b2033997c7f032255071aafab9c9
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-05-26_23:59:52
Locale: de-DE (de_DE)

Version: 5.2.0.1.0+
Build-ID: 313543cd7b8d8614dec08925894fb5eb95c8fc95
CPU-Threads: 4; BS-Version: Windows 6.1; UI-Render: Standard; 
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-07-06_14:20:05
Gebietsschema: de-DE (de_DE)
Comment 1 Katarina Behrens (Inactive) 2016-07-22 20:46:17 UTC
Yep.

(Linux, self-built master)

Contrary to what I've expected, this only happens when setting the colour in  .uno:PageSetup dialog.  Doing the same from sidebar works okay.

Once the slide background is set, the damage is done. Even after undoing slide background change, the new shapes are created without fill. 

Happens w/ all fill types, not only w/ colour
Comment 2 MM 2016-07-22 22:14:43 UTC
Unconfirmed with v5.1.5.1 under ubuntu 16.04 x64.
Confirmed with v5.2.0.3 under ubuntu 16.04 x64.

Doesn't only affects impress, but also draw. Can only set 1 component though.
If you set the 'properties' *after* you've made a basic shape, at least the area fill will stay. If you do that (for example) with 'symbol shapes' and 'block arrows' the area might be lost instantly. To get them back use 'undo' - ctrl z. Strangely from this point on, no area fills are lost anymore.
Comment 3 Heiko Tietze 2016-07-23 08:14:32 UTC
Also an issue in 5.2 (RC3), so raising the priority. The bug itself is rather an inconsistency.
Comment 4 Caolán McNamara 2016-07-24 16:36:05 UTC
it appears to be the mpView->SetAttributes part of 

commit c4170770def6abdfa4201101b8ca5fd7769135f2
Author: Katarina Behrens <Katarina.Behrens@cib.de>
Date:   Tue Apr 26 10:41:38 2016 +0200

    tdf#89466: Give those slots a separate GetState method
    
    only SID_ATTR_PAGE_SIZE does anything so far

That triggers this
Comment 5 Caolán McNamara 2016-07-24 20:31:28 UTC
https://gerrit.libreoffice.org/#/c/27487/ makes it work for me, I can't see any negative sideeffects but maybe bubli could have a look over it first
Comment 6 Commit Notification 2016-07-25 06:49:11 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=60ab08c6c5c4b5730c1cb54eca5558be214e8925

Resolves: tdf#101076 drag-create creates an unfilled shape...

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2016-07-26 12:25:44 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f54aa12797d0c2d6dc5c35b3c11a9c37c744edc&h=libreoffice-5-2

Resolves: tdf#101076 drag-create creates an unfilled shape...

It will be available in 5.2.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.