Bug 101088 - [l10n, dutch] Overtranslation in Dutch example xml for classification
Summary: [l10n, dutch] Overtranslation in Dutch example xml for classification
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-23 14:16 UTC by Gabor Kelemen (allotropia)
Modified: 2016-09-16 14:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2016-07-23 14:16:35 UTC
In https://cgit.freedesktop.org/libreoffice/core/tree/sfx2/classification/example_nl-NL.xml
the value of <baf:Scale> is translated as 
<baf:Scale>NL Overheid</baf:Scale>

This is wrong as https://cgit.freedesktop.org/libreoffice/core/tree/sfx2/source/view/classificationhelper.cxx#n629 
says there can only be two values:
    // The spec defines two valid scale values: FIPS-199 and UK-Cabinet.

Maybe the original example.xml could have a comment about this, as UK-Cabinet looks like an arbitrary user-specific value.

There was already a similar problem with the Slovenial xml:  
https://cgit.freedesktop.org/libreoffice/core/commit/?id=463fe57dc9527602bc92b0ba74505a1934949dd5&h=libreoffice-5-2
Comment 1 Gabor Kelemen (allotropia) 2016-07-23 14:23:44 UTC
https://gerrit.libreoffice.org/27460
Comment 2 Commit Notification 2016-07-24 21:58:12 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=49edd6d296c5bccbcc614d87b7f1265ede6e6334

tdf#101088 fix Dutch translation of <baf:Scale> tags

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Cor Nouws 2016-07-27 12:13:02 UTC
thanks for your help here too.(In reply to Gabor Kelemen from comment #0)

> Maybe the original example.xml could have a comment about this, as
> UK-Cabinet looks like an arbitrary user-specific value.

Indeed.
Comment 4 Xisco Faulí 2016-09-15 22:45:36 UTC
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Comment 5 Commit Notification 2016-09-16 13:13:22 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e488d3c9527e0e7cfd3dd56479db4ed6d4035ea3

tdf#101088 Add comments about translatable elements of classification

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Gabor Kelemen (allotropia) 2016-09-16 14:24:35 UTC
Original problem fixed and the new comments should give a bit of protection against similar mistakes in the future.