Bug Hunting Session
Bug 101305 - UI - dark blue selection within template browser as well as within recent documents view
Summary: UI - dark blue selection within template browser as well as within recent doc...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Start-Center Template-Manager
  Show dependency treegraph
 
Reported: 2016-08-04 17:30 UTC by Thorsten Wagner
Modified: 2019-05-06 21:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (390.89 KB, image/png)
2016-08-04 17:30 UTC, Thorsten Wagner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Wagner 2016-08-04 17:30:34 UTC
Created attachment 126596 [details]
Screenshot

Since LO 5.2 selection colors within template browser as well as within recent documents view changed from light gray / dark gray to light grey / dark blue (see screenshot attached).

I'm not sure whether it is intended or a bug. From my point of view selection colors should be reverted to light gray / dark gray.
Comment 1 Alex Thurgood 2016-08-05 07:52:06 UTC
Confirming also on

Version: 5.3.0.0.alpha0+
Build ID: 66fc20335348ec195237c711edca821d8771439c
CPU Threads: 2; OS Version: Mac OS X 10.11.6; UI Render: default; 
Locale: fr-FR (fr.UTF-8); Calc: group
Comment 2 Alex Thurgood 2016-08-05 07:54:16 UTC
@Jay : do you know if this choice was intended ? (I guess so)
Comment 3 Yousuf Philips (jay) (retired) 2016-08-05 10:03:55 UTC
I noticed this as well a few days back. In 5.1, the selected entry was light gray and went dark gray, while now its light gray to dark blue.
Comment 4 Akshay Deep 2016-08-06 10:48:37 UTC
This is not a bug, it's a feature.

In LO 5.1, the templates view has only three states: unselected(white), selected(dark grey) and hover(light grey).

In the new template view, we have four states: unselected(white), selected(dark grey), hover(light grey) and selected + hover (blue).

Note that these colour may change depending on system configuration.
Comment 5 Yousuf Philips (jay) (retired) 2016-08-24 14:39:48 UTC
(In reply to Akshay Deep from comment #4)
> In the new template view, we have four states: unselected(white),
> selected(dark grey), hover(light grey) and selected + hover (blue).

The colors in the template manager look good but the ones in the start center dont look as good, so please swap the colors of selected and selected + hover (selected to blue and selected + hover to dark grey)
Comment 6 Xisco Faulí 2016-09-12 12:50:16 UTC
Adding keyword 'bibisectRequest'.
Comment 7 Thorsten Wagner 2016-11-12 23:43:00 UTC
Issue is already present with current master. New four state behavior seems to be only used when selecting "Templates" from Start Center before. Without selecting "Templates" from Start Center behavior is as known from the past.
Comment 8 Philippe Hemmel 2017-04-21 12:14:07 UTC
1339374c9eee9abf83a165cda082ceef3e504b63 is the first bad commit
commit 1339374c9eee9abf83a165cda082ceef3e504b63
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Sep 27 13:52:14 2016 +0200

    source sha:934908168ebdb4a021e18e6bea57accc21d5ad86
    
    source sha:934908168ebdb4a021e18e6bea57accc21d5ad86

:040000 040000 1c49c419464868e001c42e456e4622976056a2cb 576de6db379dc5960cc974e6a323da6a94de69a5 M	instdir
Comment 9 Philippe Hemmel 2017-04-21 12:14:53 UTC
# bad: [1bfd8dda84f0dd2c5662b64f382637d75b8bf227] source sha:6238f71ddbdc766e733b1c808a4fa7d66f7bde87
# good: [33e60eae04c889baf52713a73dc9944015408914] source sha:5b168b3fa568e48e795234dc5fa454bf24c9805e
git bisect start '1bfd8dda84f0dd2c5662b64f382637d75b8bf227' 'oldest'
# bad: [964789dfd0674f0447da363a8c52114097796fa3] source sha:e473e0e1b9bc354d53908cb0ca84db06c3051fe2
git bisect bad 964789dfd0674f0447da363a8c52114097796fa3
# bad: [e076e507d65a9ac4e63569e22b7384a0eb67c5a0] source sha:8550366138d576123b9e66a1a7915a04026d79cd
git bisect bad e076e507d65a9ac4e63569e22b7384a0eb67c5a0
# bad: [720bbf801075947ba622f09ee203a45582abbc37] source sha:6b3eb4788f63602c0a446ad8f56539d3b65bb302
git bisect bad 720bbf801075947ba622f09ee203a45582abbc37
# good: [b3cece56b78e9650587bb1d2cf67ea09a6386e56] source sha:2a11499583cfc8c65e2fa99fbcdfdd7b94e966c1
git bisect good b3cece56b78e9650587bb1d2cf67ea09a6386e56
# bad: [aff42b2b4d7417bf87e012f814f47496b18aad29] source sha:99226f343e4ad9ebcbb4e31c17d3fb706153e18b
git bisect bad aff42b2b4d7417bf87e012f814f47496b18aad29
# bad: [791dd96fd23f4152197b00ea470d5dac13868c6c] source sha:a7415828b86a02216ffed44a4fa5b785f17d657c
git bisect bad 791dd96fd23f4152197b00ea470d5dac13868c6c
# bad: [819d07d26f254d871438c19c52daa3f101fc950d] source sha:d106ffc5f1c611657e7ccd96ac9dab70cc7ebe53
git bisect bad 819d07d26f254d871438c19c52daa3f101fc950d
# bad: [a138f67ed7ef4f0a9280e68c423222c2752d48b4] source sha:45a6fdad8101e4ba552ca4d4532d0b03b79dd15a
git bisect bad a138f67ed7ef4f0a9280e68c423222c2752d48b4
# good: [9c77eee0c75eb77571587b988b6c101714cd7fd7] source sha:8f6ce60fdb9a8a583f3a925ef345265cee299b89
git bisect good 9c77eee0c75eb77571587b988b6c101714cd7fd7
# good: [6ac5f1472e47426b6911c4cf766d8e1c14b9e4ac] source sha:d8df3ed9dfef931d5384a18f3ac3b1f49ee3200c
git bisect good 6ac5f1472e47426b6911c4cf766d8e1c14b9e4ac
# good: [2adf7ecbee036767339ad1ef1b2bb360d3583803] source sha:b5ad72bbfca85946e352b56d9d2ee5eb71cd2132
git bisect good 2adf7ecbee036767339ad1ef1b2bb360d3583803
# good: [cfa971662ead21a290aac472f4cc04b37ff3ec56] source sha:15436c009e756dd4c94046f9849ad5a186454af8
git bisect good cfa971662ead21a290aac472f4cc04b37ff3ec56
# bad: [1339374c9eee9abf83a165cda082ceef3e504b63] source sha:934908168ebdb4a021e18e6bea57accc21d5ad86
git bisect bad 1339374c9eee9abf83a165cda082ceef3e504b63
# first bad commit: [1339374c9eee9abf83a165cda082ceef3e504b63] source sha:934908168ebdb4a021e18e6bea57accc21d5ad86
Comment 10 Philippe Hemmel 2017-04-21 12:17:03 UTC
With this commit, selected + hover is blue, before that, dark grey
Comment 11 Xisco Faulí 2017-09-13 18:08:03 UTC
bisected keyword is missing here...

Regression introduced by:

author	Akshay Deep <akshaydeepiitr@gmail.com>	2016-06-07 10:57:25 (GMT)
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2016-06-07 12:58:17 (GMT)
commit	934908168ebdb4a021e18e6bea57accc21d5ad86 (patch)
tree	3ab87af564a6f62c55282cc005d09cf25873b6e0
parent	15436c009e756dd4c94046f9849ad5a186454af8 (diff)
Missing selected + hover state in Template Manager

Adding Cc: to Akshay Deep
Comment 12 QA Administrators 2018-09-14 02:47:35 UTC Comment hidden (obsolete)
Comment 13 Thorsten Wagner 2019-05-06 21:08:03 UTC
Issue still exists in current revision from master (LO 6.3).