Bug 101943 - BETAINV and BETA.INV constraints
Summary: BETAINV and BETA.INV constraints
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Winfried Donkers
URL:
Whiteboard: target:5.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-06 18:24 UTC by raal
Modified: 2016-10-18 14:44 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2016-09-06 18:24:12 UTC
Both BETA.INV and BETAINV are Excel functions, the first being the
newest and recommended one. There may be differences in accuracy between
the 2, but essentially they are identical and could be combined in 1
test document.

ODFF1.2 only mentions BETAINV.

The code does neither fully comply with the published Excel constraints,
nor with the ODFF1.2 constraints:
The code accepts a probability of 0 but not of 1 (which does comply
neither with ODFF1.2 nor with Excel);
The code does not accept A == B, but does accept A > B (which is not
allowed in both ODFF1.2 and Excel (not published, but constraint is
applied in Excel);
The code returns 0 when p equals 0, which is incorrect when A is not 0.
Comment 1 Regina Henschel 2016-09-06 18:43:16 UTC
Do you have got a test document with all this corner cases? If yes, please attach it.
Comment 2 Eike Rathke 2016-09-16 17:37:57 UTC
IIRC Raal prepared a function test document for which this bug actually was created. The corresponding fix is in https://gerrit.libreoffice.org/28723
Comment 3 Commit Notification 2016-10-05 21:40:08 UTC
Winfried Donkers committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ac7968435e556ee23e517a19521eac34ca04296

tdf#101943 Make Calc functions BETAINV and BETA.INV comply with

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Eike Rathke 2016-10-05 21:42:22 UTC
@Raal:
Please push your function test document to gerrit. Thanks.